From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BE36C77B7C for ; Mon, 23 Jun 2025 15:50:31 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4bQsx2054Bz30W5; Tue, 24 Jun 2025 01:50:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1750693829; cv=none; b=kO8KVZh5yfYRAt5R7XqOW7YGsrddmWvmdpLcvi9Yi5taMH8XAceN60a7rNBmTv6OhKv5iZnuctTE4iiaP6wRO0cGXAPJh4KlEadUu3U7Rg4tnt+Jh6bQnggO4JHfM+2FxpiWzfKYzQTSJ5HSKNyKUyQf0L1pU/BloG2oJz21qGALDsiLLlZ0KYHttbOYLIql8+P40pDURZuyIHjn1krFTV1BZsj0jvsd9CsB4yrVBMiLUGqVE726zBvJZW1t3Wc2kK6hQmmnrtuYKmoTAtcMTr3Go0dT+tu+4har0STslMq3Jlu6q3f8YtaRJjQDHydxSCXZIscZRQ+EI3fLBiZdZw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1750693829; c=relaxed/relaxed; bh=yRC43xoNyhfCsplc/KR++YxoYFjBMRcRCyrGGtLCdu4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EnaTWeaLxhVZYHsj/OqiFFGww4QTLXeKfXdFGUDps9Cfg25oQBuebp+/Ylzm6L5rAoe+MmlCQOMealGZIsh/xlBZLrcOOtPv51wdth81ivL1NCotYlpN8pd+F6hRKzNqwhDi2j1y1Zf0vwhNFyN+8eYN2OlrHLodS4ZCo9iz1eslulgbfn0PbzBJ9ZTjdHWtA5iGhlevcLiFioGakwx9ETlTwo9fQ667suZJ3nuM2eiVMch7TGIJPITwS8sevZN4iCd7xXsig9tR1jN1T5fQPtfYy2e2J1xTC9mHMBLAGUdyguBhDEngWOh/ngHMxk5nLkziR77W2LAEwmZJ5ZKiAA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fXym090h; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fXym090h; dkim-atps=neutral; spf=pass (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fXym090h; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fXym090h; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4bQsx10Flsz30VV for ; Tue, 24 Jun 2025 01:50:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750693826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yRC43xoNyhfCsplc/KR++YxoYFjBMRcRCyrGGtLCdu4=; b=fXym090hj1LyR0yCmoprEi0qqck84crFKxAJS5ytOM9C//DTg6V6aAO79VwCCvUzbcBtQ+ NBPvIJxOxoZBpwKKvIxayGAtRbP2jH+5G7kni/1+zbfGI9uEzCI+ctF8iYgMUvG7BG7Nxn g7FglGFGQGGr0a5Zo0OTKWrBA2Z/v/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750693826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yRC43xoNyhfCsplc/KR++YxoYFjBMRcRCyrGGtLCdu4=; b=fXym090hj1LyR0yCmoprEi0qqck84crFKxAJS5ytOM9C//DTg6V6aAO79VwCCvUzbcBtQ+ NBPvIJxOxoZBpwKKvIxayGAtRbP2jH+5G7kni/1+zbfGI9uEzCI+ctF8iYgMUvG7BG7Nxn g7FglGFGQGGr0a5Zo0OTKWrBA2Z/v/0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-HDohzm_-PSq2pJi10-yKdA-1; Mon, 23 Jun 2025 11:50:24 -0400 X-MC-Unique: HDohzm_-PSq2pJi10-yKdA-1 X-Mimecast-MFC-AGG-ID: HDohzm_-PSq2pJi10-yKdA_1750693823 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so1891085f8f.2 for ; Mon, 23 Jun 2025 08:50:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750693823; x=1751298623; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yRC43xoNyhfCsplc/KR++YxoYFjBMRcRCyrGGtLCdu4=; b=Tyz3h28KCic55vnT/b7zNdQHBLVoLL1Myd5kSJhTPimQf10clkZM4AoqBBO9tIzhYW VA+DSfmLp4iRp8kfmQgzx9CRPXiiQkicdET6Q12r0hiyFk5wdOKjsapL57vB/G0xU7PK ePShRZGqwn5lawdRObVw76kxeGm/fe8GDRExZ9T2h4rarpIKynGMNXnBsOT7NbR9gsUu DphrywgNWwRGM6GIY93ET9zXoVkEa+NJhKJKFdLGIGMN1ism/m4WeeftbQbBO/RAbN9a 4JHeZCahr8I0Cp10xCxONGiOWJ3qiKG1w0vU6KVbMJ/GAQazw8AGrgLVQ8Cag+jVUr7N 0QVQ== X-Forwarded-Encrypted: i=1; AJvYcCV173MOfMGVa/VcGX3rv+2cE2KmcLGHwhJjXAoYJlfC+jRHBZ3HMq5SGcuapTumSexU4IerAwoSRTe1Y5U=@lists.ozlabs.org X-Gm-Message-State: AOJu0Yz16c+/M5tben4G2xrPqAKzC9vzJRr6/zQpPzEE9KeheqCYxlMy kSa9UBpGXkJcd9W8xZImwazDCN8BbiVR6RFONvLviNkUKPb0VxQxhdXOGB5oXTKm/WEtxDgrZb1 dcQ9e+J3Tey24Mo7X9d3hSRSElu0q3mqippteon1irKhjqDOYiNIY6/UM0MElIMkWZBs= X-Gm-Gg: ASbGncsioj5f7IHTZaaxtv2PTK/hHA3Yo7WuHfb1PmyorZmeRbJix8SjrmNKR6kXame U8lyv3gSr7RLE0G1rh4QqTF23WHCYcWd5z1OyqvXSWaUgdXgskVVhenqNgtrKPPA3b+0w5oNyt4 i+Fv9hu4/f0BTf/uPvt8i/uDbji6gIqWIJjwPZyFdKcZ2uj7xBEaby+JBqUD+9DGTZvFcquurQu mP0O6dJHX2oCztTWvrWwo+9akzZNkq2vjyWEz5d6/W2RgU+wHu0W1ZTMTsW2zRWRUoUnnz7AFI1 yySvcKaDSDeVZ69qctoCJNr92OXdWgg9F/CzaAl1CgRfPjSO2L0qOLgVBuCQc85w0zPttzJJUX/ C0TxyZqcyH6bulgmNUe3pmDqzQ/k3gu43h0Yxby6X3b7Nf1u5Pw== X-Received: by 2002:a05:6000:2412:b0:3a6:c923:bc5f with SMTP id ffacd0b85a97d-3a6d13019e7mr9836588f8f.17.1750693823113; Mon, 23 Jun 2025 08:50:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7nWn2XFwK6TT8ZAkqrEp9zhAtjyd7MNgn344l/d1NlIJSnSP6B7frYWb4hjnDR6A7h3gMKg== X-Received: by 2002:a05:6000:2412:b0:3a6:c923:bc5f with SMTP id ffacd0b85a97d-3a6d13019e7mr9836566f8f.17.1750693822675; Mon, 23 Jun 2025 08:50:22 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45365af83easm108398715e9.25.2025.06.23.08.50.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 08:50:21 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 17:50:18 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 20/29] mm: convert "movable" flag in page->mapping to a page flag To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-21-david@redhat.com> <2EE119E0-C71C-43C6-A445-E9CB8AAA86E6@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2EE119E0-C71C-43C6-A445-E9CB8AAA86E6@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Rcfr1vxFlsgrnIAlo-aPCPd7tb2Ra-LvUqwSYGo8F6I_1750693823 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.06.25 16:14, Zi Yan wrote: > On 18 Jun 2025, at 13:40, David Hildenbrand wrote: > >> Instead, let's use a page flag. As the page flag can result in >> false-positives, glue it to the page types for which we >> support/implement movable_ops page migration. >> >> Signed-off-by: David Hildenbrand >> --- >> include/linux/balloon_compaction.h | 2 +- >> include/linux/migrate.h | 8 ----- >> include/linux/page-flags.h | 52 ++++++++++++++++++++++++------ >> mm/compaction.c | 6 ---- >> mm/zpdesc.h | 2 +- >> 5 files changed, 44 insertions(+), 26 deletions(-) >> > > > >> + >> +/** >> + * page_has_movable_ops - test for a movable_ops page >> + * @page The page to test. >> + * >> + * Test whether this is a movable_ops page. Such pages will stay that >> + * way until freed. >> + * >> + * Returns true if this is a movable_ops page, otherwise false. >> + */ >> +static inline bool page_has_movable_ops(const struct page *page) >> +{ >> + return PageMovableOps(page) && >> + (PageOffline(page) || PageZsmalloc(page)); >> +} >> + > > Should we do the code below in case PageMovableOps is set on pages > other than PageOffline and PageZsmalloc? > > return PageMovableOps(page) && > !VM_WARN_ON_ONCE_PAGE(!(PageOffline(page) || PageZsmalloc(page)), > page); I think this could trigger in some corner when other pages (esp. folios?) reuse the flag and we run into some weird races while we don't hold any reference on the page. -- Cheers, David / dhildenb