From: Milton Miller <miltonm@bga.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: ppcdev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] generic check_legacy_ioport
Date: Tue, 24 Apr 2007 10:45:22 -0500 [thread overview]
Message-ID: <b4976cbe7c1e829b9be1ae5bdb7b6219@bga.com> (raw)
In-Reply-To: <20070424112530.GA11489@aepfle.de>
On Tue Apr 24 21:25:30 EST 2007, Olaf Hering wrote:
> Thats how it may look finally, currently only compile tested.
>
> int check_legacy_ioport(unsigned long base_port)
> {
> struct device_node *parent, *np = NULL;
> int ret = -ENODEV;
...
> if (np) {
> parent = of_get_parent(np);
> if (parent) {
> ret = strcmp(parent->type, "isa");
This calculates the return as 0 / anything, vs 0 / -ENODEV.
> of_node_put(parent);
> }
> of_node_put(np);
> }
> return ret;
> }
next prev parent reply other threads:[~2007-04-24 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 21:07 [PATCH] generic check_legacy_ioport Olaf Hering
2007-04-17 21:22 ` Arnd Bergmann
2007-04-17 23:28 ` Segher Boessenkool
2007-04-20 18:51 ` Olaf Hering
2007-04-22 5:15 ` Milton Miller
2007-04-22 6:46 ` Olaf Hering
2007-04-23 8:15 ` [PATCH] " Olaf Hering
2007-04-24 0:53 ` Benjamin Herrenschmidt
2007-04-24 11:25 ` Olaf Hering
2007-04-24 15:45 ` Milton Miller [this message]
2007-04-24 18:54 ` Olaf Hering
2007-04-24 22:01 ` Arnd Bergmann
2007-04-25 0:12 ` Benjamin Herrenschmidt
2007-04-25 1:54 ` Segher Boessenkool
2007-04-25 7:49 ` Arnd Bergmann
2007-04-25 13:33 ` Segher Boessenkool
2007-04-25 22:02 ` Arnd Bergmann
2007-04-25 0:09 ` Benjamin Herrenschmidt
2007-04-24 22:34 ` Benjamin Herrenschmidt
2007-04-25 20:36 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4976cbe7c1e829b9be1ae5bdb7b6219@bga.com \
--to=miltonm@bga.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).