linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
To: Daniel Axtens <dja@axtens.net>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv/prd: Unregister OPAL_MSG_PRD2 notifier during module unload
Date: Thu, 28 Oct 2021 22:27:46 +0530	[thread overview]
Message-ID: <b4b9310e-76a6-4d29-0cba-af7ae7ab7945@linux.vnet.ibm.com> (raw)
In-Reply-To: <87r1d5mg1a.fsf@linkitivity.dja.id.au>

On 10/1/21 11:40 AM, Daniel Axtens wrote:
> Hi Vasant,
> 
>> Commit 587164cd, introduced new opal message type (OPAL_MSG_PRD2) and added
>> opal notifier. But I missed to unregister the notifier during module unload
>> path. This results in below call trace if you try to unload and load
>> opal_prd module.
>>
>> Fixes: 587164cd ("powerpc/powernv: Add new opal message type")
> 
> In reviewing this patch, I've become a bit worried the underlying patch
> has another issue that we should fix.

Thanks for the review. I have addressed below comments in v2.

-Vasant


      reply	other threads:[~2021-10-28 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 12:09 [PATCH] powerpc/powernv/prd: Unregister OPAL_MSG_PRD2 notifier during module unload Vasant Hegde
2021-10-01  6:10 ` Daniel Axtens
2021-10-28 16:57   ` Vasant Hegde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4b9310e-76a6-4d29-0cba-af7ae7ab7945@linux.vnet.ibm.com \
    --to=hegdevasant@linux.vnet.ibm.com \
    --cc=dja@axtens.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).