From: "Arnd Bergmann" <arnd@arndb.de>
To: "Christoph Hellwig" <hch@infradead.org>,
"Julian Vetter" <jvetter@kalrayinc.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, guoren <guoren@kernel.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Matt Turner" <mattst88@gmail.com>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Richard Weinberger" <richard@nod.at>,
"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Naveen N Rao" <naveen@kernel.org>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-alpha@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-um@lists.infradead.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-sound@vger.kernel.org,
"Yann Sionneau" <ysionneau@kalrayinc.com>
Subject: Re: [PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c
Date: Tue, 08 Oct 2024 12:29:32 +0000 [thread overview]
Message-ID: <b54a6f76-fcfd-40bd-b478-ca0a7e1af128@app.fastmail.com> (raw)
In-Reply-To: <ZwUbsviaqFUtjKEQ@infradead.org>
On Tue, Oct 8, 2024, at 11:46, Christoph Hellwig wrote:
> On Tue, Oct 08, 2024 at 09:50:09AM +0200, Julian Vetter wrote:
>> lib/iomap_copy.c | 127 +++++++++++++++++++++++++++++++++++++++
>
> On top of the previous comments: this really should be iomem_copy.c
> instead.
Right, I suggested adding it to the existing file since the
functions are logically related, but the naming of that file
identifiers in it is unfortunate:
__iowrite32_copy/__iowrite64_copy/__ioread32_copy sound like
they are meant to work on both IORESOURCE_MEM and IORESOURCE_IO
mappings the same way that iowrite64/ioread64/ioread32 do,
but actually using them on x86 port I/O (from pci_iomap or
ioport_map) would lead to a NULL pointer dereference.
Arnd
next prev parent reply other threads:[~2024-10-08 12:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 7:50 [PATCH v8 00/14] Consolidate IO memcpy functions Julian Vetter
2024-10-08 7:50 ` [PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c Julian Vetter
2024-10-08 9:27 ` Arnd Bergmann
2024-10-08 9:32 ` Christoph Hellwig
2024-10-08 11:46 ` Christoph Hellwig
2024-10-08 12:29 ` Arnd Bergmann [this message]
2024-10-08 7:50 ` [PATCH v8 02/14] arm64: Use generic IO memcpy/memset Julian Vetter
2024-10-08 7:50 ` [PATCH v8 03/14] csky: " Julian Vetter
2024-10-08 7:50 ` [PATCH v8 04/14] loongarch: " Julian Vetter
2024-10-08 7:50 ` [PATCH v8 05/14] m68k: Align prototypes of " Julian Vetter
2024-10-08 7:50 ` [PATCH v8 06/14] alpha: " Julian Vetter
2024-10-08 14:54 ` Richard Henderson
2024-10-08 7:50 ` [PATCH v8 07/14] parisc: " Julian Vetter
2024-10-08 7:50 ` [PATCH v8 08/14] sh: " Julian Vetter
2024-10-08 7:50 ` [PATCH v8 09/14] arm: Align prototype of IO memset Julian Vetter
2024-10-08 7:50 ` [PATCH v8 10/14] powerpc: Align prototypes of IO memcpy and memset Julian Vetter
2024-10-08 7:50 ` [PATCH v8 11/14] s390: Add wrappers around zpci_memcpy/zpci_memset Julian Vetter
2024-10-08 13:42 ` Niklas Schnelle
2024-10-08 7:50 ` [PATCH v8 12/14] bus: mhi: ep: Add HAS_IOMEM || INDIRECT_IOMEM dependency Julian Vetter
2024-10-08 7:50 ` [PATCH v8 13/14] mtd: " Julian Vetter
2024-10-08 8:33 ` Miquel Raynal
2024-10-08 7:50 ` [PATCH v8 14/14] sound: Make CONFIG_SND depend on INDIRECT_IOMEM instead of UML Julian Vetter
2024-10-08 8:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b54a6f76-fcfd-40bd-b478-ca0a7e1af128@app.fastmail.com \
--to=arnd@arndb.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dalias@libc.org \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hch@infradead.org \
--cc=ink@jurassic.park.msu.ru \
--cc=johannes@sipsolutions.net \
--cc=jvetter@kalrayinc.com \
--cc=kernel@xen0n.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mattst88@gmail.com \
--cc=mhi@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=perex@perex.cz \
--cc=richard.henderson@linaro.org \
--cc=richard@nod.at \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tiwai@suse.com \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
--cc=ysionneau@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).