[PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings

[PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings

[GONG, Ruiqi]

Fix the following Sparse warnings that got noticed when the PPC-dev
patchwork was checking another patch (see the link below):

init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?

Which in fact are triggered on all architectures that have
HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
etc).

Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
---

v2: remove unnecessary #ifdef around the header

 init/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/main.c b/init/main.c
index e2490387db2b..eb9bf7c5b28b 100644
--- a/init/main.c
+++ b/init/main.c
@@ -99,6 +99,7 @@
 #include <linux/kcsan.h>
 #include <linux/init_syscalls.h>
 #include <linux/stackdepot.h>
+#include <linux/randomize_kstack.h>
 #include <net/net_namespace.h>
 
 #include <asm/io.h>
-- 
2.25.1

Re: [PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings

[Christophe Leroy]

Le 29/06/2022 à 08:04, GONG, Ruiqi a écrit :
> [Vous ne recevez pas souvent de courriers de gongruiqi1@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fix the following Sparse warnings that got noticed when the PPC-dev
> patchwork was checking another patch (see the link below):
> 
> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
> 
> Which in fact are triggered on all architectures that have
> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
> etc).
> 
> Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> 
> v2: remove unnecessary #ifdef around the header
> 
>   init/main.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/init/main.c b/init/main.c
> index e2490387db2b..eb9bf7c5b28b 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -99,6 +99,7 @@
>   #include <linux/kcsan.h>
>   #include <linux/init_syscalls.h>
>   #include <linux/stackdepot.h>
> +#include <linux/randomize_kstack.h>
>   #include <net/net_namespace.h>
> 
>   #include <asm/io.h>
> --
> 2.25.1
> 

Re: [PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings

[Kees Cook]

On Wed, 29 Jun 2022 14:04:23 +0800, GONG, Ruiqi wrote:
> Fix the following Sparse warnings that got noticed when the PPC-dev
> patchwork was checking another patch (see the link below):
> 
> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
> 
> Which in fact are triggered on all architectures that have
> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
> etc).
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
      https://git.kernel.org/kees/c/375561bd6195

-- 
Kees Cook