Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Madhavan Srinivasan <maddy@linux.ibm.com>]

On 7/27/26 6:47 PM, Christophe Leroy (CS GROUP) wrote:
>
>
> Le 12/07/2026 à 17:13, Thorsten Blum a écrit :
>> The local table structure is not used - remove it.
>>
>> Remove % in the comment while at it.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> Looks like it's never been used since commit de91a5342995 ("[POWERPC] 
> ps3: add spu support") that introduced it.
>
>
> Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
>
> I have no opinion about the %0 versus 0, is it worth the change ?
FYI.. I have added this patch as-is to my fixes-test
not waiting for v2
Maddy
>
>
>> ---
>>   arch/powerpc/platforms/ps3/spu.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/ps3/spu.c 
>> b/arch/powerpc/platforms/ps3/spu.c
>> index e817def7f424..c904f9fa1caa 100644
>> --- a/arch/powerpc/platforms/ps3/spu.c
>> +++ b/arch/powerpc/platforms/ps3/spu.c
>> @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
>>    * The current HV requires the spu shadow regs to be mapped with the
>>    * PTE page protection bits set as read-only.
>>    *
>> - * Returns: %0 on success or -errno on error.
>> + * Returns: 0 on success or -errno on error.
>>    */
>>     static int __init setup_areas(struct spu *spu)
>>   {
>> -    struct table {char* name; unsigned long addr; unsigned long size;};
>> -
>>       spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
>>                             sizeof(struct spe_shadow),
>> pgprot_noncached_wc(PAGE_KERNEL_RO));
>