linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Kernel Bug/oops during boot (PowerVM LPAR w/vTPM)
@ 2019-07-03 10:24 Sachin Sant
  2019-07-03 11:17 ` Michal Suchánek
  0 siblings, 1 reply; 4+ messages in thread
From: Sachin Sant @ 2019-07-03 10:24 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: nayna, gcwilson

Booting mainline kernel on PowerVM LPAR with vTPM enabled results
into a kernel crash.

[    0.365989] BUG: Kernel NULL pointer dereference at 0x00000012
[    0.365995] Faulting instruction address: 0xc00000000073dd80
[    0.366000] Oops: Kernel access of bad area, sig: 11 [#1]
[    0.366005] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
[    0.366010] Modules linked in:
[    0.366015] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc7-autotest-autotest #1
[    0.366020] NIP:  c00000000073dd80 LR: c00000000073dcd0 CTR: 0000000000000000
[    0.366026] REGS: c0000018ed8e7550 TRAP: 0380   Not tainted  (5.2.0-rc7-autotest-autotest)
[    0.366031] MSR:  8000000000009033 <SF,EE,ME,IR,DR,RI,LE>  CR: 28002448  XER: 20040001
[    0.366038] CFAR: c000000000b6d1c4 IRQMASK: 0
[    0.366038] GPR00: c00000000073dcd0 c0000018ed8e77e0 c000000001524a00 0000000000000000
[    0.366038] GPR04: 0000000000000003 0000000000000000 0000000000010000 000000000000000e
[    0.366038] GPR08: 0000000000000022 0000000000010000 c0000018e5510000 00000000883bfecd
[    0.366038] GPR12: 0000000048002448 c00000001ec6ee00 c0000000000107a8 0000000000000000
[    0.366038] GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
[    0.366038] GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
[    0.366038] GPR24: c0000018eb9eaaa0 0000000000000000 c000000000bce810 c000000000e2ed28
[    0.366038] GPR28: c0000018e70a4000 000000000000000a 0000000000000012 c0000018e5510000
[    0.366085] NIP [c00000000073dd80] tpm1_pcr_extend+0x130/0x230
[    0.366090] LR [c00000000073dcd0] tpm1_pcr_extend+0x80/0x230
[    0.366094] Call Trace:
[    0.366098] [c0000018ed8e77e0] [c00000000073dcd0] tpm1_pcr_extend+0x80/0x230 (unreliable)
[    0.366105] [c0000018ed8e7890] [c00000000073c8c4] tpm_pcr_extend+0xd4/0x180
[    0.366111] [c0000018ed8e78d0] [c0000000005745f8] ima_add_template_entry+0x198/0x320
[    0.366117] [c0000018ed8e79b0] [c000000000577058] ima_store_template+0xc8/0x160
[    0.366124] [c0000018ed8e7a30] [c000000000f6081c] ima_add_boot_aggregate+0xf8/0x184
[    0.366130] [c0000018ed8e7b30] [c000000000f6093c] ima_init+0x94/0xbc
[    0.366135] [c0000018ed8e7b90] [c000000000f60aac] init_ima+0x44/0xe8
[    0.366140] [c0000018ed8e7c10] [c000000000010448] do_one_initcall+0x68/0x2c0
[    0.366146] [c0000018ed8e7ce0] [c000000000f14738] kernel_init_freeable+0x318/0x47c
[    0.366152] [c0000018ed8e7db0] [c0000000000107c4] kernel_init+0x24/0x150
[    0.366158] [c0000018ed8e7e20] [c00000000000ba54] ret_from_kernel_thread+0x5c/0x68
[    0.366163] Instruction dump:
[    0.366167] 7d404d2c 81210068 792a07e1 e9410070 392a0002 7d004c2c 79070020 40c20048
[    0.366174] 39080014 3d200001 7f884840 419d00a4 <807e0000> 809e0004 80be0008 80de000c
[    0.366182] ---[ end trace ec40127c4fe87b2c ]—

Thanks
-Sachin

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Kernel Bug/oops during boot (PowerVM LPAR w/vTPM)
  2019-07-03 10:24 Kernel Bug/oops during boot (PowerVM LPAR w/vTPM) Sachin Sant
@ 2019-07-03 11:17 ` Michal Suchánek
  2019-07-03 21:15   ` Michal Suchánek
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Suchánek @ 2019-07-03 11:17 UTC (permalink / raw)
  To: Sachin Sant; +Cc: nayna, linuxppc-dev, gcwilson

On Wed, 3 Jul 2019 15:54:59 +0530
Sachin Sant <sachinp@linux.vnet.ibm.com> wrote:

> Booting mainline kernel on PowerVM LPAR with vTPM enabled results
> into a kernel crash.
> 
> [    0.365989] BUG: Kernel NULL pointer dereference at 0x00000012
> [    0.365995] Faulting instruction address: 0xc00000000073dd80
> [    0.366000] Oops: Kernel access of bad area, sig: 11 [#1]
> [    0.366005] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
> [    0.366010] Modules linked in:
> [    0.366015] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc7-autotest-autotest #1
> [    0.366020] NIP:  c00000000073dd80 LR: c00000000073dcd0 CTR: 0000000000000000
> [    0.366026] REGS: c0000018ed8e7550 TRAP: 0380   Not tainted  (5.2.0-rc7-autotest-autotest)
> [    0.366031] MSR:  8000000000009033 <SF,EE,ME,IR,DR,RI,LE>  CR: 28002448  XER: 20040001
> [    0.366038] CFAR: c000000000b6d1c4 IRQMASK: 0
> [    0.366038] GPR00: c00000000073dcd0 c0000018ed8e77e0 c000000001524a00 0000000000000000
> [    0.366038] GPR04: 0000000000000003 0000000000000000 0000000000010000 000000000000000e
> [    0.366038] GPR08: 0000000000000022 0000000000010000 c0000018e5510000 00000000883bfecd
> [    0.366038] GPR12: 0000000048002448 c00000001ec6ee00 c0000000000107a8 0000000000000000
> [    0.366038] GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> [    0.366038] GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> [    0.366038] GPR24: c0000018eb9eaaa0 0000000000000000 c000000000bce810 c000000000e2ed28
> [    0.366038] GPR28: c0000018e70a4000 000000000000000a 0000000000000012 c0000018e5510000
> [    0.366085] NIP [c00000000073dd80] tpm1_pcr_extend+0x130/0x230
> [    0.366090] LR [c00000000073dcd0] tpm1_pcr_extend+0x80/0x230
> [    0.366094] Call Trace:
> [    0.366098] [c0000018ed8e77e0] [c00000000073dcd0] tpm1_pcr_extend+0x80/0x230 (unreliable)
> [    0.366105] [c0000018ed8e7890] [c00000000073c8c4] tpm_pcr_extend+0xd4/0x180
> [    0.366111] [c0000018ed8e78d0] [c0000000005745f8] ima_add_template_entry+0x198/0x320
> [    0.366117] [c0000018ed8e79b0] [c000000000577058] ima_store_template+0xc8/0x160
> [    0.366124] [c0000018ed8e7a30] [c000000000f6081c] ima_add_boot_aggregate+0xf8/0x184
> [    0.366130] [c0000018ed8e7b30] [c000000000f6093c] ima_init+0x94/0xbc
> [    0.366135] [c0000018ed8e7b90] [c000000000f60aac] init_ima+0x44/0xe8
> [    0.366140] [c0000018ed8e7c10] [c000000000010448] do_one_initcall+0x68/0x2c0
> [    0.366146] [c0000018ed8e7ce0] [c000000000f14738] kernel_init_freeable+0x318/0x47c
> [    0.366152] [c0000018ed8e7db0] [c0000000000107c4] kernel_init+0x24/0x150
> [    0.366158] [c0000018ed8e7e20] [c00000000000ba54] ret_from_kernel_thread+0x5c/0x68
> [    0.366163] Instruction dump:
> [    0.366167] 7d404d2c 81210068 792a07e1 e9410070 392a0002 7d004c2c 79070020 40c20048
> [    0.366174] 39080014 3d200001 7f884840 419d00a4 <807e0000> 809e0004 80be0008 80de000c
> [    0.366182] ---[ end trace ec40127c4fe87b2c ]—
> 
> Thanks
> -Sachin

You need to revert (or fix up) commit 0b6cf6b97b7e ("tpm: pass an array
of tpm_extend_digest structures to tpm_pcr_extend()". At least
reverting it fixes the issue for me.

Thanks

Michal


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Kernel Bug/oops during boot (PowerVM LPAR w/vTPM)
  2019-07-03 11:17 ` Michal Suchánek
@ 2019-07-03 21:15   ` Michal Suchánek
  2019-07-04  3:36     ` Nayna
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Suchánek @ 2019-07-03 21:15 UTC (permalink / raw)
  To: Sachin Sant; +Cc: nayna, linuxppc-dev, gcwilson

On Wed, 3 Jul 2019 13:17:16 +0200
Michal Suchánek <msuchanek@suse.de> wrote:

> On Wed, 3 Jul 2019 15:54:59 +0530
> Sachin Sant <sachinp@linux.vnet.ibm.com> wrote:
> 
> > Booting mainline kernel on PowerVM LPAR with vTPM enabled results
> > into a kernel crash.
> > 
> > [    0.365989] BUG: Kernel NULL pointer dereference at 0x00000012
...
> > [    0.366085] NIP [c00000000073dd80] tpm1_pcr_extend+0x130/0x230
> > [    0.366090] LR [c00000000073dcd0] tpm1_pcr_extend+0x80/0x230
...
> 
> You need to revert (or fix up) commit 0b6cf6b97b7e ("tpm: pass an array
> of tpm_extend_digest structures to tpm_pcr_extend()". At least
> reverting it fixes the issue for me.

FTR this is the revert on lkml https://lkml.org/lkml/2019/7/1/423

> 
> Thanks
> 
> Michal
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Kernel Bug/oops during boot (PowerVM LPAR w/vTPM)
  2019-07-03 21:15   ` Michal Suchánek
@ 2019-07-04  3:36     ` Nayna
  0 siblings, 0 replies; 4+ messages in thread
From: Nayna @ 2019-07-04  3:36 UTC (permalink / raw)
  To: Michal Suchánek, Sachin Sant
  Cc: nayna, linuxppc-dev, Mimi Zohar, gcwilson

Hi Sachin and Michal,


On 07/03/2019 05:15 PM, Michal Suchánek wrote:
> On Wed, 3 Jul 2019 13:17:16 +0200
> Michal Suchánek <msuchanek@suse.de> wrote:
>
>> On Wed, 3 Jul 2019 15:54:59 +0530
>> Sachin Sant <sachinp@linux.vnet.ibm.com> wrote:
>>
>>> Booting mainline kernel on PowerVM LPAR with vTPM enabled results
>>> into a kernel crash.
>>>
>>> [    0.365989] BUG: Kernel NULL pointer dereference at 0x00000012
> ...
>>> [    0.366085] NIP [c00000000073dd80] tpm1_pcr_extend+0x130/0x230
>>> [    0.366090] LR [c00000000073dcd0] tpm1_pcr_extend+0x80/0x230
> ...
>> You need to revert (or fix up) commit 0b6cf6b97b7e ("tpm: pass an array
>> of tpm_extend_digest structures to tpm_pcr_extend()". At least
>> reverting it fixes the issue for me.
> FTR this is the revert on lkml https://lkml.org/lkml/2019/7/1/423
>
>


I have just now posted the fix for this to the mailing list and copied 
both of you. I would appreciate your testing and confirming that the 
patch "tpm: fixes uninitialized allocated banks for IBM vtpm driver" 
addresses this bug.

Thanks & Regards,
       - Nayna



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-04  3:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-03 10:24 Kernel Bug/oops during boot (PowerVM LPAR w/vTPM) Sachin Sant
2019-07-03 11:17 ` Michal Suchánek
2019-07-03 21:15   ` Michal Suchánek
2019-07-04  3:36     ` Nayna

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).