* [PATCH] cxl: Drop unused detach_spa()
@ 2023-08-23 4:48 Michael Ellerman
2023-08-23 4:51 ` Andrew Donnellan
2023-08-31 4:02 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Michael Ellerman @ 2023-08-23 4:48 UTC (permalink / raw)
To: linuxppc-dev; +Cc: fbarrat, ajd
Clang warns:
drivers/misc/cxl/native.c:272:20: error: unused function 'detach_spa' [-Werror,-Wunused-function]
It was created as part of some refactoring in commit 05155772f642 ("cxl:
Allocate and release the SPA with the AFU"), but has never been called
in its current form. Drop it.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/misc/cxl/native.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c
index 50b0c44bb8d7..fbe16a6ab7ad 100644
--- a/drivers/misc/cxl/native.c
+++ b/drivers/misc/cxl/native.c
@@ -269,11 +269,6 @@ static void attach_spa(struct cxl_afu *afu)
cxl_p1n_write(afu, CXL_PSL_SPAP_An, spap);
}
-static inline void detach_spa(struct cxl_afu *afu)
-{
- cxl_p1n_write(afu, CXL_PSL_SPAP_An, 0);
-}
-
void cxl_release_spa(struct cxl_afu *afu)
{
if (afu->native->spa) {
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cxl: Drop unused detach_spa()
2023-08-23 4:48 [PATCH] cxl: Drop unused detach_spa() Michael Ellerman
@ 2023-08-23 4:51 ` Andrew Donnellan
2023-08-31 4:02 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2023-08-23 4:51 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: fbarrat
On Wed, 2023-08-23 at 14:48 +1000, Michael Ellerman wrote:
> Clang warns:
> drivers/misc/cxl/native.c:272:20: error: unused function
> 'detach_spa' [-Werror,-Wunused-function]
>
> It was created as part of some refactoring in commit 05155772f642
> ("cxl:
> Allocate and release the SPA with the AFU"), but has never been
> called
> in its current form. Drop it.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Indeed it looks unused.
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cxl: Drop unused detach_spa()
2023-08-23 4:48 [PATCH] cxl: Drop unused detach_spa() Michael Ellerman
2023-08-23 4:51 ` Andrew Donnellan
@ 2023-08-31 4:02 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2023-08-31 4:02 UTC (permalink / raw)
To: linuxppc-dev, Michael Ellerman; +Cc: fbarrat, ajd
On Wed, 23 Aug 2023 14:48:03 +1000, Michael Ellerman wrote:
> Clang warns:
> drivers/misc/cxl/native.c:272:20: error: unused function 'detach_spa' [-Werror,-Wunused-function]
>
> It was created as part of some refactoring in commit 05155772f642 ("cxl:
> Allocate and release the SPA with the AFU"), but has never been called
> in its current form. Drop it.
>
> [...]
Applied to powerpc/next.
[1/1] cxl: Drop unused detach_spa()
https://git.kernel.org/powerpc/c/fe32945203ffc8d6fed815f7ed7729219f8b0ab6
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-31 4:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-23 4:48 [PATCH] cxl: Drop unused detach_spa() Michael Ellerman
2023-08-23 4:51 ` Andrew Donnellan
2023-08-31 4:02 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).