From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE94C433E0 for ; Fri, 5 Feb 2021 18:02:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62D8464DD4 for ; Fri, 5 Feb 2021 18:02:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62D8464DD4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DXNXl1lbHzDwlP for ; Sat, 6 Feb 2021 05:01:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.microsoft.com (client-ip=13.77.154.182; helo=linux.microsoft.com; envelope-from=nramas@linux.microsoft.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b=VwTrdKn5; dkim-atps=neutral Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lists.ozlabs.org (Postfix) with ESMTP id 4DXNVC4cKSzDwl8 for ; Sat, 6 Feb 2021 04:59:47 +1100 (AEDT) Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id B10A620B6C40; Fri, 5 Feb 2021 09:59:45 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B10A620B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1612547985; bh=R/hf6T7IfqycaEkvWUWCsy5KS7kYt+/f6lu60uKrZc4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VwTrdKn5QuH+ugavR1sYZ5ODTerDlLe18JCTYyCKTjteoD/lFzarEpsTQ4bbioy+G b4IYR48kTdBa6sQRz/NH/HOOJjWJAgaas5xt9LnO9E0hS525NHdqeLiswFlevo0QWi 400UzuFEoDfX7Xiyhc8PQTw5A601cG/sMH4Cxwak= Subject: Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error To: Mimi Zohar , Greg KH References: <20210204174951.25771-1-nramas@linux.microsoft.com> <7000d128-272e-3654-8480-e46bf7dfad74@linux.microsoft.com> <6a5b7a1767265122d21f185c81399692d12191f4.camel@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: Date: Fri, 5 Feb 2021 09:59:45 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <6a5b7a1767265122d21f185c81399692d12191f4.camel@linux.ibm.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sashal@kernel.org, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, tyhicks@linux.microsoft.com, ebiederm@xmission.com, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2/5/21 9:49 AM, Mimi Zohar wrote: Hi Mimi, > On Fri, 2021-02-05 at 09:39 -0800, Lakshmi Ramasubramanian wrote: >> On 2/5/21 2:05 AM, Greg KH wrote: >>> On Thu, Feb 04, 2021 at 09:49:50AM -0800, Lakshmi Ramasubramanian wrote: >>>> IMA allocates kernel virtual memory to carry forward the measurement >>>> list, from the current kernel to the next kernel on kexec system call, >>>> in ima_add_kexec_buffer() function. In error code paths this memory >>>> is not freed resulting in memory leak. >>>> >>>> Free the memory allocated for the IMA measurement list in >>>> the error code paths in ima_add_kexec_buffer() function. >>>> >>>> Signed-off-by: Lakshmi Ramasubramanian >>>> Suggested-by: Tyler Hicks >>>> Fixes: 7b8589cc29e7 ("ima: on soft reboot, save the measurement list") >>>> --- >>>> security/integrity/ima/ima_kexec.c | 1 + >>>> 1 file changed, 1 insertion(+) >>> >>> >>> >>> This is not the correct way to submit patches for inclusion in the >>> stable kernel tree. Please read: >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>> for how to do this properly. >>> >>> >>> >> >> Thanks for the info Greg. >> >> I will re-submit the two patches in the proper format. > > No need. I'm testing these patches now. I'm not exactly sure what the > problem is. Stable wasn't Cc'ed. Is it that you sent the patch > directly to Greg or added "Fixes"? > I had not Cced stable, but had "Fixes" tag in the patch. Fixes: 7b8589cc29e7 ("ima: on soft reboot, save the measurement list") The problem is that the buffer allocated for forwarding the IMA measurement list is not freed - at the end of the kexec call and also in an error path. Please see the patch description for [PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall IMA allocates kernel virtual memory to carry forward the measurement list, from the current kernel to the next kernel on kexec system call, in ima_add_kexec_buffer() function. This buffer is not freed before completing the kexec system call resulting in memory leak. thanks, -lakshmi