From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EC9D10BA421 for ; Fri, 27 Mar 2026 02:56:12 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fhldl1HBVz2xmX; Fri, 27 Mar 2026 13:56:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c04:e001:324:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774580171; cv=none; b=eoyZPAzY08nzJ8/XWFDFHPpAi+fIRd9VM4L2aifiyLvatDuxmUWZtrWIVKuVFKIouESyz3EmLxKk0FYiO0sKHWoEffrJA/MAZsFUccVBSomW6qah8fU5pICQilzFQgSfy0v6lCKSpXlYA/yb/XfNWxOGgVEXI4gnT8fGLrCO88hAlzfMqhnGQIaZdk/36L2JfMGzD55T9Q2fnPy2S91UAmJ/cwCDoPUe/dfawER0SlB0/2A3OwWdBSQAnKBGPgG94onBlIqdEYEdItmOfH5+51q682uTJCEC9nCY/XgEzWLf3kP6IsboUPO9iBWoxOUZQBLuDPQZ0zHOemNaS9KOzQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774580171; c=relaxed/relaxed; bh=/x34Ij2kuXzsnJRKdh7n98HuULH2/zRsLD1v43nFDFY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=hP7gJbf0zUG1n9j2YUzmRJAU5E2fAf1h+WKPJH15kOxfyII6D2FG5uLbTVaNVk+3KPBaaFj30/XnPNH1PsSW71B2Y2+uv8AnSDKI6uOMSgGtuHYlgYxJ9vvcgDDABTsY20mM+/+7XQ7Tg/rcQkvo/NIWcA7hOyTv9Z9gq5wncHmeSZbE//IXv8pyIk6/+bXbasQ95bhl34/Q1N/B8Dgcn6ilL71DePU8rSwu7LAvqFhp8ZoO+WpXQZ/04QMjQstyOg3LWOCBOywCal+pYNZ0nnzkubZ2RX9L0+1FoctDGYoXkKq2Ue95UvHR7afdcLcxr9h93SG18lpJ+g/3hVBXlw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=srs0=nmqu=b3=linux-m68k.org=gerg@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=srs0=nmqu=b3=linux-m68k.org=gerg@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fhldj5xcqz2xR4 for ; Fri, 27 Mar 2026 13:56:09 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 3B0DC60054; Fri, 27 Mar 2026 02:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62989C116C6; Fri, 27 Mar 2026 02:55:59 +0000 (UTC) Message-ID: Date: Fri, 27 Mar 2026 12:55:55 +1000 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of align To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , linux-pci@vger.kernel.org, Bjorn Helgaas , Guenter Roeck , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, Russell King , Geert Uytterhoeven , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Chris Zankel , Max Filippov , Madhavan Srinivasan , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , linux-kernel@vger.kernel.org References: <20260324165633.4583-1-ilpo.jarvinen@linux.intel.com> <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com> Content-Language: en-US From: Greg Ungerer In-Reply-To: <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 25/3/26 02:56, Ilpo Järvinen wrote: > Aligning res->start by align inside pcibios_align_resource() is > unnecessary because caller of pcibios_align_resource() is > __find_resource_space() that aligns res->start with align before > calling pcibios_align_resource(). > > Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever > result in changing start either because 0x300 bits would have not > survived the earlier alignment if align was large enough to have an > impact. > > Thus, remove the duplicated aligning from pcibios_align_resource(). > > Signed-off-by: Ilpo Järvinen LGTM. Acked-by: Greg Ungerer > --- > arch/m68k/kernel/pcibios.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c > index 1415f6e4e5ce..7e286ee1976b 100644 > --- a/arch/m68k/kernel/pcibios.c > +++ b/arch/m68k/kernel/pcibios.c > @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res, > if ((res->flags & IORESOURCE_IO) && (start & 0x300)) > start = (start + 0x3ff) & ~0x3ff; > > - start = (start + align - 1) & ~(align - 1); > - > return start; > } >