From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B13B9C88E50 for ; Mon, 14 Sep 2026 13:20:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hk5P42t1Kz2yjw; Mon, 14 Sep 2026 23:20:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1789392024; cv=none; b=Pfm2wRYau/EGfEZHfD1fkueQXopHw2yimjnX96hD9aoGmYAwRBjlsrlhYyo2YOnsm0zvVOnBEWcKk9XIvqGy4hUqM8QfKWh4NXnZ/xzzJC37mXLcTBIJ+QHaSHer7x4P5jTZg9QzmCKpej0ABaB2HS6kDcPSBaAZoEC2lMS2quBlHU7UQ4WYyrCwkmvYCBP1P33YYasbLV2kHHgpp/X016k+ye6ph4rmwE8Xcg68so3u6FoAvj0XRK7DgxgpXUDhJ/Lzh34zin8+OG7F1JSWZffpwfJhxYyTEM8mSRZ1CPe8wMBVRDLuulKakovpQUQVixE15neBoKOg6Hz2OSfqzw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1789392024; c=relaxed/relaxed; bh=FAExpTSQeOnURSVfE6PgdU+Z8ZSz89ZKBxqhzpBwsCE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BorMcs5/9WtnprqkE6FX2GlkDXDR2DuK3Qve++gS0F0jWptgRQASYCR/tAa+xLhk8x5e/9wQ9fqDUSRmM9h12BnI0ZqF6xHrIqnE666R8QXRnEslAoP73wenaclnUeeHGe0Zcd+BndXIZmp213LWElSA72EOABlw7C/s3MhL9SK67xZzjgY0+AjSAVE08umE3ja7n4a1lMPmWL63Zozmx84vsheVX6tZwRP5LqGHXTUstrPIzzGA7DV6ezoHWAU2YrRv96YZR6YAMeMYwdK5+iNhu805ndVd1M1WabVremz7ByiwDUOJjTXXi14tmaqKQqve+nT0U/dMeMOT4SpXww== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=ib5ybx5X; dkim-atps=neutral; spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=ssrish@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=ib5ybx5X; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=ssrish@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hk5P33Q38z2xSV for ; Mon, 14 Sep 2026 23:20:22 +1000 (AEST) Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68ED26nW223780; Mon, 14 Sep 2026 13:20:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=FAExpT SQeOnURSVfE6PgdU+Z8ZSz89ZKBxqhzpBwsCE=; b=ib5ybx5XPAf2cQqgEzmSWU mfBl5OKt1oxppkAX6WQdPx42qFtCOIccSArLWetJq1aNjhaZTCae9WcqK2OJp0ED c64hGBkDXt5qdSWbRyeLPXTOAgfbzgiPmat11PY78YDWcqTJo7KOBT2uKrCitJcF q/bekem+G6QyvN40bgcS/DqMoSzSfJnh5qWacSt9dOOPtmPIcE7NJ5a3qbozAJZl 6EApZzQdZVvf2tXO9FiUMBq++J1bfq3El7NSrvLXevMZw4uNbMV+5o0mnG2vLVDp l9/0kZmoXW01kT4LGZrH24mnnSW3263QwryVztT6UjJdAZ/vd5WCcAlknVNSrt5w == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gmxdq1kd9-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 14 Sep 2026 13:20:04 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68ED54P62386846; Mon, 14 Sep 2026 13:20:03 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gnk9j61mr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Sep 2026 13:20:03 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68EDK25b28574344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Sep 2026 13:20:02 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4691F58063; Mon, 14 Sep 2026 13:20:02 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C22D5805A; Mon, 14 Sep 2026 13:19:56 +0000 (GMT) Received: from [9.67.124.200] (unknown [9.67.124.200]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 14 Sep 2026 13:19:56 +0000 (GMT) Message-ID: Date: Mon, 14 Sep 2026 18:49:54 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init() To: Thorsten Blum , =?UTF-8?Q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Herbert Xu , "David S. Miller" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde Cc: linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260914081500.65737-2-blum@kernel.org> Content-Language: en-US From: Srish Srinivasan In-Reply-To: <20260914081500.65737-2-blum@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDE4NiBTYWx0ZWRfXzqLdAcXZbk5w bqDPyBJhUeGG0Fvm6cCZCVO1LAAajMu86rnFC7/yUQ7PuX5GOkzvNA2bGQI+qp2i4nPLlPAGe1s bkGTKk//sfgTqeabhSbBxmPxrwv1nsZoJfKzoReD30VgTp3W5pfseIGOeXW7j4Ykldet46YE5BX G6Kx260mDKYldKqeWqhzc7Fe74MfrZe18EoSg/GOWoSfnTQnu5XTYburefJVJ1snD44Mw2iOIbP 1tIXNzUiuOXWq1+ohdxnb8yKYUjsxvd06nQ7WFUloFMO9uYHYqNjSWxC+O8mwYHfvzOi7RfPG2c Ie5K9CL4BS73SdYdGfGg+6yligpDPyeFaXP/5y3ihApC0jPuBw6mDN5ALwsBdTBdOwqu3y2hPVl XMF/EcnlU+Aj7Unq8W7ImT2R30y0jN7Bzh9v3hc9DBSVUgjFy1f1y8w4T4h8OELvh35q8k2SvqX szo4qPIJt4iSvKJxtQw== X-Proofpoint-GUID: iDL1_mx-bwn_G7WfWm5EaZr9wvkI4rjm X-Authority-Analysis: v=2.4 cv=DobDa2/+ c=1 sm=1 tr=0 ts=6aa7f484 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=dDLX0a77UB6nXHVu2IYA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: v7f9fFXDbhU1-pvt1ABFUhTVqABWpZt6 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDE4NiBTYWx0ZWRfXwwTnRCTi6+iM 54M3goLSh1DR5Iyj0NG6+8EqqQ4DQQ7WS7A0RhpFtLaqWazNKOpVyh5+7selU37FosuwAUDKsTi Yvj4vSwnqwBU7K7E1UqEUdpWrGESUeA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_03,2026-09-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 clxscore=1011 adultscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140186 On 9/14/26 1:45 PM, Thorsten Blum wrote: > In p8_init(), remove the goto statement and return ret directly. > > Remove any redundant includes, add a missing space in MODULE_AUTHOR(), > and join the MODULE_DESCRIPTION() strings for better grepability. > > Also remove MODULE_VERSION(). It has never been updated and the kernel > release better reflects the module version. > > Signed-off-by: Thorsten Blum Tested-by: Srish Srinivasan > --- > arch/powerpc/crypto/vmx.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/arch/powerpc/crypto/vmx.c b/arch/powerpc/crypto/vmx.c > index 08da5311dfdf..8abc4db8ee4e 100644 > --- a/arch/powerpc/crypto/vmx.c > +++ b/arch/powerpc/crypto/vmx.c > @@ -8,12 +8,7 @@ > */ > > #include > -#include > -#include > -#include > #include > -#include > -#include > #include > > #include "aesp8-ppc.h" > @@ -24,7 +19,7 @@ static int __init p8_init(void) > > ret = crypto_register_skcipher(&p8_aes_cbc_alg); > if (ret) > - goto err; > + return ret; > > ret = crypto_register_skcipher(&p8_aes_ctr_alg); > if (ret) > @@ -40,7 +35,6 @@ static int __init p8_init(void) > crypto_unregister_skcipher(&p8_aes_ctr_alg); > err_unregister_aes_cbc: > crypto_unregister_skcipher(&p8_aes_cbc_alg); > -err: > return ret; > } > > @@ -54,8 +48,6 @@ static void __exit p8_exit(void) > module_cpu_feature_match(PPC_MODULE_FEATURE_VEC_CRYPTO, p8_init); > module_exit(p8_exit); > > -MODULE_AUTHOR("Marcelo Cerri"); > -MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions " > - "support on Power 8"); > +MODULE_AUTHOR("Marcelo Cerri "); > +MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions support on Power 8"); > MODULE_LICENSE("GPL"); > -MODULE_VERSION("1.0.0"); >