From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH v3] Create add_rtc() function to enable the RTC CMOS driver
Date: Fri, 22 Jun 2007 09:56:24 +0200 [thread overview]
Message-ID: <ba34492532ac9dfd43bd9f2ae427deef@kernel.crashing.org> (raw)
In-Reply-To: <20070622033158.GA21419@localhost.localdomain>
> Hrm. It seems rather specific. Can we do this more generally, by
> creating an of_platform device which binds to rtc nodes, then
> registers an appropriate platform device for each so that the generic
> rtc drivers pick them up. Obviously we'd need some sort of table
> mapping the device node compatible properties to the appropriate
> platform device names.
>> + * RTC_PORT(x) is hardcoded in asm/mc146818rtc.h. Verify that the
>> + * address provided by the device node matches.
>> + */
>> + if (res.start != RTC_PORT(0)) {
>> + of_node_put(np);
>> + return -ENODEV;
>> + }
>
> This looks totally bogus. If we have a device tree we should be using
> the address information from there, not using hardcoded magic. Sounds
> like asm/mc146818rtc.h needs some serious fixing.
Both of your comments would be nice extensions (and the right
way forwards), but Wade's patch is good as-is already.
Segher
next prev parent reply other threads:[~2007-06-22 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 0:15 [PATCH v2] Create add_rtc() function to enable the RTC CMOS driver Wade Farnsworth
2007-06-20 10:06 ` Segher Boessenkool
2007-06-20 16:21 ` Wade Farnsworth
2007-06-20 16:59 ` [PATCH v3] " Wade Farnsworth
2007-06-20 17:46 ` Segher Boessenkool
2007-06-22 3:31 ` David Gibson
2007-06-22 7:56 ` Segher Boessenkool [this message]
2007-06-25 3:33 ` David Gibson
2007-07-10 11:54 ` Paul Mackerras
2007-07-10 16:55 ` [PATCH v4] " Wade Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba34492532ac9dfd43bd9f2ae427deef@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).