linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Johns Daniel <johns.daniel@gmail.com>
To: afleming@freescale.com, linuxppc-dev@ozlabs.org, stable@kernel.org
Subject: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c
Date: Wed, 11 Mar 2009 10:50:56 -0500	[thread overview]
Message-ID: <ba5d9360903110850gbcb0d2y25f8756a19d46cda@mail.gmail.com> (raw)

A semicolon at the end of the macro means that the for loop has an
empty body, and so TSEC/MDIO will not work with older device trees.

This fix only applies to 2.6.28; apparently, this code is gone for
2.6.29, according to Grant Likely!

Signed-off-by: Johns Daniel <johns.daniel@gmail.com>
---
--- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig   2009-02-20
16:41:27.000000000 -0600
+++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c        2009-03-10
15:56:47.000000000 -0500
@@ -257,7 +257,7 @@
                gfar_mdio_of_init_one(np);

        /* try the deprecated version */
-       for_each_compatible_node(np, "mdio", "gianfar");
+       for_each_compatible_node(np, "mdio", "gianfar")
                gfar_mdio_of_init_one(np);

        return 0;
---

             reply	other threads:[~2009-03-11 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 15:50 Johns Daniel [this message]
2009-03-11 16:03 ` [PATCH] powerpc: Remove extra semicolon in fsl_soc.c Grant Likely
2009-03-11 16:05   ` [stable] " Greg KH
2009-03-13  6:03   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba5d9360903110850gbcb0d2y25f8756a19d46cda@mail.gmail.com \
    --to=johns.daniel@gmail.com \
    --cc=afleming@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).