From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41C5DC83038 for ; Tue, 1 Jul 2025 08:11:24 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4bWbMZ5zkbz2y2B; Tue, 1 Jul 2025 18:11:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1751357482; cv=none; b=TuTAWf3z6EiSXG8lbT/jTAxUTvIoSKZjjXWpTkE/tkqpsitns6hKQ+hS6vdQ3NZ3hNRxJ4Gzi6NXgxBTu3b1S+oQDeC8wU7LMnq5guOiv0mYsGQ7ci7Vbf8yaLz3CRClZWaRH8bRaWlq3GdP/DAM/Yf+THzKgtMpWZ7iU+RUnfu5+tU3wINFoTJo22auRCz7hPV5Kbv2+QcQOVw1PCgq3DuSQV7zDXkMtFWmG6k4CWMk092G8EOwDgqUm/nwHhvHcSmg6NXma4d1NhZkdXS/1lvjAWv17FORtxZEqCgG+xBNCJxXEnC+ewkZVVcSQl0OES5pRyRVfOiylfrzLxvxqA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1751357482; c=relaxed/relaxed; bh=YrqKfOfhORr/5vproY5ovuBEQCam7Cslax8BPi13vvQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GVghFH9XNMp74+5LsLkZoV7bFvz+/aTY64LCaWxjdCbNPeQTYxUDH9PHAZ3K3zr2PJQlwe0dkph84rEdXqG7obLG6Yb4EbGejNazcV9YAIh6Z+F73p1jIBQLuRHe3y855oBmARUrlHZnhL9Bep9o8cIK/fqSIv/mIq4e/5iL4mB32ONhB3NfMqd0HOu+88c/0noXWy4ISWk3mD4EfRMXKjirQ9AjVOUPb1MPUtyWSQQ6na/tce4F8cP9SeVVJifAjSllG3Egd8KmpNSG9qP43rD+uYSM7DlNwqBhbjx79os551QDKH6M0AXkS6MdmKWOLRiBOURZZfA5xhOhoNMpOQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VSvhskD3; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VUxOrJcg; dkim-atps=neutral; spf=pass (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VSvhskD3; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VUxOrJcg; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4bWbMX4hvZz2xHT for ; Tue, 1 Jul 2025 18:11:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751357476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YrqKfOfhORr/5vproY5ovuBEQCam7Cslax8BPi13vvQ=; b=VSvhskD3ixSpAjRFM02YDXA5fQr7by/BiCvONyik4YO5M+obxsQBND9uN9d0R1rrJhpZR6 /LsVoWojvody9M/fg7mx/Ok03WDxOF6/UN0V2cQ1v0/egGuIiAlA/8THcjJInABZ+PeK5E nm5xFMGVqILktuw7Uh0NTNVwiWWeqHY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751357477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YrqKfOfhORr/5vproY5ovuBEQCam7Cslax8BPi13vvQ=; b=VUxOrJcgvNr7+B89PWKlsQ1iuUS5h95JKMft+WsyfeBCkrF7qq5zQlt5ZCp4wQR/ZijkVD IN0Mm0faH9tNJ8Snh1qAIlpPDe6H3j0R524WdbpBFz1GXf4vKuK0UhYQdBp1klId99AFmF DX1zYq8IryshM7+mNKfB7czq9ibgoYY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-tzX4PkryOSebB7m-m_L3PQ-1; Tue, 01 Jul 2025 04:11:15 -0400 X-MC-Unique: tzX4PkryOSebB7m-m_L3PQ-1 X-Mimecast-MFC-AGG-ID: tzX4PkryOSebB7m-m_L3PQ_1751357474 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f3796779so2871509f8f.1 for ; Tue, 01 Jul 2025 01:11:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751357474; x=1751962274; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YrqKfOfhORr/5vproY5ovuBEQCam7Cslax8BPi13vvQ=; b=iDzqp0u65EcKDabKCfhATmXD33mjrFq29+/1gB57+OkPzogUzvIvkQ/y5f0Ynn/LcJ 2rHwfUReRI2SVv9shDnWHizb+7gmOLLokdjrA/yj9blc97YbnJIu61aPmkbXDF9dk1p9 4lQzrI94gy0MhOwjpKl/M+JqGck4uI3aoqWFeRKUj78NpVPumTrKnJJJbXWd9pOV4Bff p/PTWmkxGkvmUlj7Rpv9vIn3fAukCXrEBB2J9iCn27vckQuPmfhV3UzJl/eC3O9WVOql Pcb3TXleUgkiCUSZLaTI49ElhNHcO4vrM2se9oLOq7aW9mD3ars8aQc8EFWNWEQVEjUZ LX4Q== X-Forwarded-Encrypted: i=1; AJvYcCVfYa3MQKcjJq5jXoabfIghYsWP/GSZNpc4bAQ7bR9kc6w818mutA1K2o6ktquYhMZeY0VPNJc9T+c36Hg=@lists.ozlabs.org X-Gm-Message-State: AOJu0YxvXdmsXMc38VhSi2YoFrlYwQin5fUDLJK6IOG5LVG2Tzu9LQFW 5RZI4fOlSMxjkSs+16yDzf6AiwUoH36Wcj3r1/1w1liRBgvaZkzdXuXVz3rGC8CSbIR/NytK779 GahygAhkNtHX8dCCo1ghksKeLOtEQfdojDmJG5M6f3lDXTIEGDzfVQ3Eo7V96AXjKKVA= X-Gm-Gg: ASbGncuJNxbdUAbTCJGyEfmHaNXn+6+SJnSc7Hwwlq/45Y6fSNIod+Q6wOIGqcyaL8T FaGyOE5sNGBB7/CHkYGJgbAVLOzjkvAK5y25t02dPJZWhK7bWMk4POhLTzOthTcx3Sc8I3aULj0 LJ/0HmCuME7S2ENTZagpsSOEY4pLQCT0l+PlNxICZ4YgPP+xwrHOVlZBbiF/KM4rUdtrREXviF/ BCGyDyfvyix+8Gxmdu6w8fsJlOKsIdqstOahf8K/FOrCA4hJ50am8IBJCztBKmYUdvVyK0A82dX owfBLJQtPoz3KYkQ+MC+9Ibfzd5LZXz5IvJDnEQQ57mNAiMcV8AXXJFGc69q9k3gHEjyzfBCORo sOzjIVXj80Pb8adytP7NCYepTKHAXy39xFxZnq7xo01WUJgYWHA== X-Received: by 2002:adf:fdca:0:b0:3a4:e4ee:4c7b with SMTP id ffacd0b85a97d-3a90d5a7cfemr12842283f8f.15.1751357473981; Tue, 01 Jul 2025 01:11:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPya9SzQYm2Gmxkryry4rcIJONguISr6QtHQb7EIzTCLPQ+9unHQuu9F1m9XhBP7UVfQjAGg== X-Received: by 2002:adf:fdca:0:b0:3a4:e4ee:4c7b with SMTP id ffacd0b85a97d-3a90d5a7cfemr12842232f8f.15.1751357473490; Tue, 01 Jul 2025 01:11:13 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e52bb3sm12734059f8f.56.2025.07.01.01.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 01:11:12 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 10:11:10 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 05/29] mm/balloon_compaction: make PageOffline sticky until the page is freed To: Harry Yoo , Zi Yan Cc: Lorenzo Stoakes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-6-david@redhat.com> <6a6cde69-23de-4727-abd7-bae4c0918643@lucifer.local> <595C96DA-C652-455F-91DB-F7893B95124B@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ipuTSgFvezUV9AQq712K_wQkK8iOUnFbOLfzByJwl14_1751357474 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.07.25 08:13, Harry Yoo wrote: > On Mon, Jun 30, 2025 at 12:14:01PM -0400, Zi Yan wrote: >> On 30 Jun 2025, at 12:01, Lorenzo Stoakes wrote: >> >>> On Mon, Jun 30, 2025 at 02:59:46PM +0200, David Hildenbrand wrote: >>>> Let the page freeing code handle clearing the page type. >>> >>> Why is this advantageous? We want to keep the page marked offline for longer? >>> >>>> >>>> Acked-by: Zi Yan >>>> Acked-by: Harry Yoo >>>> Signed-off-by: David Hildenbrand >>> >>> On assumption this UINT_MAX stuff is sane :)) I mean this is straightforward I >>> guess: >> >> This is how page type is cleared. >> See: https://elixir.bootlin.com/linux/v6.15.4/source/include/linux/page-flags.h#L1013. >> >> I agree with you that patch 4 should have a comment in free_pages_prepare() >> about what the code is for and why UINT_MAX is used. > > Or instead of comment, maybe something like this: > > /* Clear any page type */ > static __always_inline void __ClearPageType(struct page *page) > { > VM_WARN_ON_ONCE_PAGE(!page_has_type(page), page); > page->page_type = UINT_MAX; > } > > in patch 4: > > if (unlikely(page_has_type(page))) > __ClearPageType(page); > I don't think we should do that. It's very specialized code that nobody should be reusing. And it will all change once Willy reworks the page_type vs. _mapcount overlay. -- Cheers, David / dhildenb