From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 753B3C02182 for ; Thu, 23 Jan 2025 10:13:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YdxcG5QpPz3029; Thu, 23 Jan 2025 21:13:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737627230; cv=none; b=co7v3bGB507oVnj5z6/sUpd+LpYxAT0WYL+iEvl2QstelJ5GLtr1LZWiIKGHplbZmTwfOgCO2tU6tup1Ztdeq5fG4WoDSInTzyx4tKFF6ddKx5JltsnMP4+M/zv62IoiDIELBMGery7xR2KToQ+jcjMHBcQp/Sz/rWAlwvVNPWfM8Rpu7pZ0wq0aMi3TrhdBsRguGa59BdDkTt++z+4ij0pY2Ij/Tuevp2U7uAVZnTxMW3ygrBVzlVaKty+NhCX9h9at9X6br2UDKLY07d3pGzHF2MwYgAqlFCVfEakJfq+xO742Epl0CBGs+Yf0dxxwjD52LHqcLGHn3ftx5fLevw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737627230; c=relaxed/relaxed; bh=QaHVpUMF9VvRhgT1Viq55MNbD/fhTLmDZvPpd9WdkmQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g5V9IhCcTlgCSorBwG3LmRWektPBsuVcToYTL837ZoUWizDnSKtaRvm3fx+c62ZWqgY26sAgsnLBltE+7d46f+39MhJjQsHgXh3QQtx0ACJHZxGwkozlk9a2gN3ObT+Nb/+YZMCzCePjtafmUoG5W+FkQ/sRd+352Pzm9IerNXmcH1gHq1rAXm9Mt+1Ep+Kkhdw7mdV355l2b71odj2N3I3Fq+1LzhDrYrD/DOh4cv6crCbESCbAul5L5c+OPWLNziL02W91dJcJhqoY1ZWcChJG58Qkp8pG6c+Hn323YpU20MQQf58FGrGxeTZogd+bGetuVUWHY/S/bgwP7mg0Mw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=H1SY72l3; dkim-atps=neutral; spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=hbathini@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=H1SY72l3; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=hbathini@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YdxcF4lD5z2xGp for ; Thu, 23 Jan 2025 21:13:49 +1100 (AEDT) Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50N3dFSc027470; Thu, 23 Jan 2025 10:13:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=QaHVpU MF9VvRhgT1Viq55MNbD/fhTLmDZvPpd9WdkmQ=; b=H1SY72l3gCDz2hcssOccg6 7IT5xTWgLNUxM3GnStFmW5/Tuiqlxew6A4EvGh1GAjhoKacmZI+Ef4pdyWAvrJy0 4+pgd42jCrpTVA9DKVsScLengsilBJTNFwzOHAdoI4Ztdl4BGhREQklO0Y1Hpv6j IBQkdHNbSRlq8D+eUi/R8cwjHQ2KjjRcXpJFcSuA7SuYfeAF4VV2pJoJUg27fKlN P4FPSKwA26EYGnXgIamKhIeFHuDeKovNWtp0p//QEUT8XALBQaVefZRcSA6DEDWh uYZwP+mzr4YQFLZvfrrHysFdk5VLp4ypZhgjdWAn89/nG9XiW9bZlMR/RRIPCf/A == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44b2xymt8m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jan 2025 10:13:38 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50NA0INY024268; Thu, 23 Jan 2025 10:13:37 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 448q0yd59k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jan 2025 10:13:36 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50NADXj960555546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Jan 2025 10:13:33 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 230FF201BE; Thu, 23 Jan 2025 10:13:33 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9424F201BD; Thu, 23 Jan 2025 10:13:31 +0000 (GMT) Received: from [9.203.114.244] (unknown [9.203.114.244]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Jan 2025 10:13:31 +0000 (GMT) Message-ID: Date: Thu, 23 Jan 2025 15:43:30 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] crash: remove an unused argument from reserve_crashkernel_generic() To: Sourabh Jain , linuxppc-dev@lists.ozlabs.org Cc: Andrew Morton , Madhavan Srinivasan , Mahesh Salgaonkar , Michael Ellerman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Baoquan He References: <20250121115442.1278458-1-sourabhjain@linux.ibm.com> <20250121115442.1278458-3-sourabhjain@linux.ibm.com> Content-Language: en-US From: Hari Bathini In-Reply-To: <20250121115442.1278458-3-sourabhjain@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: C9IR5QyMKH82KJiP0QCTHbVBDJ29JWgn X-Proofpoint-ORIG-GUID: C9IR5QyMKH82KJiP0QCTHbVBDJ29JWgn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-23_04,2025-01-22_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1011 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501230076 On 21/01/25 5:24 pm, Sourabh Jain wrote: > cmdline argument is not used in reserve_crashkernel_generic() so remove > it. Correspondingly, all the callers have been updated as well. > > No functional change intended. > Looks good to me. Acked-by: Hari Bathini > Cc: Andrew Morton > Cc: Hari Bathini > Cc: Madhavan Srinivasan > Cc: Mahesh Salgaonkar > Cc: Michael Ellerman > Cc: kexec@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Baoquan He > Signed-off-by: Sourabh Jain > --- > arch/arm64/mm/init.c | 6 ++---- > arch/loongarch/kernel/setup.c | 5 ++--- > arch/riscv/mm/init.c | 6 ++---- > arch/x86/kernel/setup.c | 6 ++---- > include/linux/crash_reserve.h | 11 +++++------ > kernel/crash_reserve.c | 9 ++++----- > 6 files changed, 17 insertions(+), 26 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index 9c0b8d9558fc..6c5a1ee4b5d3 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -98,21 +98,19 @@ static void __init arch_reserve_crashkernel(void) > { > unsigned long long low_size = 0; > unsigned long long crash_base, crash_size; > - char *cmdline = boot_command_line; > bool high = false; > int ret; > > if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) > return; > > - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), > + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), > &crash_size, &crash_base, > &low_size, &high); > if (ret) > return; > > - reserve_crashkernel_generic(cmdline, crash_size, crash_base, > - low_size, high); > + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); > } > > static phys_addr_t __init max_zone_phys(phys_addr_t zone_limit) > diff --git a/arch/loongarch/kernel/setup.c b/arch/loongarch/kernel/setup.c > index 56934fe58170..ece9c4266c3f 100644 > --- a/arch/loongarch/kernel/setup.c > +++ b/arch/loongarch/kernel/setup.c > @@ -259,18 +259,17 @@ static void __init arch_reserve_crashkernel(void) > int ret; > unsigned long long low_size = 0; > unsigned long long crash_base, crash_size; > - char *cmdline = boot_command_line; > bool high = false; > > if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) > return; > > - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), > + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), > &crash_size, &crash_base, &low_size, &high); > if (ret) > return; > > - reserve_crashkernel_generic(cmdline, crash_size, crash_base, low_size, high); > + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); > } > > static void __init fdt_setup(void) > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 8d167e09f1fe..16b81beb41bf 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -1392,21 +1392,19 @@ static void __init arch_reserve_crashkernel(void) > { > unsigned long long low_size = 0; > unsigned long long crash_base, crash_size; > - char *cmdline = boot_command_line; > bool high = false; > int ret; > > if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) > return; > > - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), > + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), > &crash_size, &crash_base, > &low_size, &high); > if (ret) > return; > > - reserve_crashkernel_generic(cmdline, crash_size, crash_base, > - low_size, high); > + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); > } > > void __init paging_init(void) > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index f1fea506e20f..15b6823556c8 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -469,14 +469,13 @@ static void __init memblock_x86_reserve_range_setup_data(void) > static void __init arch_reserve_crashkernel(void) > { > unsigned long long crash_base, crash_size, low_size = 0; > - char *cmdline = boot_command_line; > bool high = false; > int ret; > > if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) > return; > > - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), > + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), > &crash_size, &crash_base, > &low_size, &high); > if (ret) > @@ -487,8 +486,7 @@ static void __init arch_reserve_crashkernel(void) > return; > } > > - reserve_crashkernel_generic(cmdline, crash_size, crash_base, > - low_size, high); > + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); > } > > static struct resource standard_io_resources[] = { > diff --git a/include/linux/crash_reserve.h b/include/linux/crash_reserve.h > index 5a9df944fb80..1fe7e7d1b214 100644 > --- a/include/linux/crash_reserve.h > +++ b/include/linux/crash_reserve.h > @@ -32,13 +32,12 @@ int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, > #define CRASH_ADDR_HIGH_MAX memblock_end_of_DRAM() > #endif > > -void __init reserve_crashkernel_generic(char *cmdline, > - unsigned long long crash_size, > - unsigned long long crash_base, > - unsigned long long crash_low_size, > - bool high); > +void __init reserve_crashkernel_generic(unsigned long long crash_size, > + unsigned long long crash_base, > + unsigned long long crash_low_size, > + bool high); > #else > -static inline void __init reserve_crashkernel_generic(char *cmdline, > +static inline void __init reserve_crashkernel_generic( > unsigned long long crash_size, > unsigned long long crash_base, > unsigned long long crash_low_size, > diff --git a/kernel/crash_reserve.c b/kernel/crash_reserve.c > index a620fb4b2116..aff7c0fdbefa 100644 > --- a/kernel/crash_reserve.c > +++ b/kernel/crash_reserve.c > @@ -375,11 +375,10 @@ static int __init reserve_crashkernel_low(unsigned long long low_size) > return 0; > } > > -void __init reserve_crashkernel_generic(char *cmdline, > - unsigned long long crash_size, > - unsigned long long crash_base, > - unsigned long long crash_low_size, > - bool high) > +void __init reserve_crashkernel_generic(unsigned long long crash_size, > + unsigned long long crash_base, > + unsigned long long crash_low_size, > + bool high) > { > unsigned long long search_end = CRASH_ADDR_LOW_MAX, search_base = 0; > bool fixed_base = false;