Re: [PATCH] powerpc: Build fix for non SPARSEMEM_VMEMAP config

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 28/06/17 16:09, Aneesh Kumar K.V wrote:
> We can use pfn_to_page in realmode for other configs. Hence remove the
> CONFIG_FLATMEM ifdef


For CONFIG_SPARSEMEM and CONFIG_DISCONTIGMEM and others (I am struggling to
find the full list :) )? Are you sure about that? If I recall correctly, at
the time realmode_pfn_to_page() could not work for all of them, what changed?

> 
> Fixes: 8e0861fa3c4ed (powerpc: Prepare to support kernel handling of IOMMU map/unmap)
> 
> Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  arch/powerpc/mm/init_64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c
> index ec84b31c6c86..3dd507b4f8cd 100644
> --- a/arch/powerpc/mm/init_64.c
> +++ b/arch/powerpc/mm/init_64.c
> @@ -322,7 +322,7 @@ struct page *realmode_pfn_to_page(unsigned long pfn)
>  }
>  EXPORT_SYMBOL_GPL(realmode_pfn_to_page);
>  
> -#elif defined(CONFIG_FLATMEM)
> +#else

There is also a comment at the #endif with "FLATMEM", needs to be updated.


>  
>  struct page *realmode_pfn_to_page(unsigned long pfn)
>  {
> 


-- 
Alexey