From: Sourabh Jain <sourabhjain@linux.ibm.com>
To: mahesh@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan he <bhe@redhat.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v1 3/5] powerpc/kdump: preserve user-specified memory limit
Date: Thu, 9 Jan 2025 08:54:31 +0530 [thread overview]
Message-ID: <bbad32bd-20fb-4d7b-8744-25d4c3fa7f8e@linux.ibm.com> (raw)
In-Reply-To: <k2eoi22mh5lod4nzee3qfbaagh36yljcqwxcyvvewmzbktcual@mzleqvtlojj3>
Hello Mahesh,
On 08/01/25 22:36, Mahesh J Salgaonkar wrote:
> On 2025-01-08 15:44:56 Wed, Sourabh Jain wrote:
>> Commit 59d58189f3d9 ("crash: fix crash memory reserve exceed system
>> memory bug") fails crashkernel parsing if the crash size is found to be
>> higher than system RAM, which makes the memory_limit adjustment code
>> ineffective due to an early exit from reserve_crashkernel().
>>
>> Regardless lets not violated the user-specified memory limit by
>> adjusting it. Remove this adjustment to ensure all reservations stay
>> within the limit. Commit f94f5ac07983 ("powerpc/fadump: Don't update
>> the user-specified memory limit") did the same for fadump.
> Agreed.
>
> Reviewed-by: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Thanks for the review.
- Sourabh Jain
next prev parent reply other threads:[~2025-01-09 3:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 10:14 [PATCH RESEND v1 0/5] powerpc/crash: use generic crashkernel reservation Sourabh Jain
2025-01-08 10:14 ` [PATCH RESEND v1 1/5] crash: remove an unused argument from reserve_crashkernel_generic() Sourabh Jain
2025-01-08 11:16 ` Baoquan he
2025-01-09 3:48 ` Sourabh Jain
2025-01-08 10:14 ` [PATCH RESEND v1 2/5] crash: let arch decide crash memory export to iomem_resource Sourabh Jain
2025-01-08 11:25 ` Baoquan he
2025-01-08 12:02 ` Sourabh Jain
2025-01-08 10:14 ` [PATCH RESEND v1 3/5] powerpc/kdump: preserve user-specified memory limit Sourabh Jain
2025-01-08 17:06 ` Mahesh J Salgaonkar
2025-01-09 3:24 ` Sourabh Jain [this message]
2025-01-08 10:14 ` [PATCH RESEND v1 4/5] powerpc/crash: use generic crashkernel reservation Sourabh Jain
2025-01-08 17:05 ` Mahesh J Salgaonkar
2025-01-09 3:43 ` Sourabh Jain
2025-01-08 10:14 ` [PATCH RESEND v1 5/5] crash: option to let arch decide mem range is usable Sourabh Jain
2025-01-08 11:38 ` Baoquan he
2025-01-08 12:03 ` Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbad32bd-20fb-4d7b-8744-25d4c3fa7f8e@linux.ibm.com \
--to=sourabhjain@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hbathini@linux.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).