[PATCH] tty:hvc:Fix incorrect formatted output

[PATCH] tty:hvc:Fix incorrect formatted output

[liujing]

The termno parameter is defined as an unsigned int 
in hvc_opal_probe function,So when it output should 
be modified to %u format.

Signed-off-by: liujing <liujing@cmss.chinamobile.com>

diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
index 095c33ad10f8..1d2e7f2ce088 100644
--- a/drivers/tty/hvc/hvc_opal.c
+++ b/drivers/tty/hvc/hvc_opal.c
@@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev)
 		/* Instanciate now to establish a mapping index==vtermno */
 		hvc_instantiate(termno, termno, ops);
 	} else {
-		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n",
+		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n",
 		       dev->dev.of_node, termno);
 		return -ENXIO;
 	}
-- 
2.27.0

Re: [PATCH] tty:hvc:Fix incorrect formatted output

[Jiri Slaby]

On 07. 11. 24, 6:47, liujing wrote:
> The termno parameter is defined as an unsigned int
> in hvc_opal_probe function,

"The termno parameter is defined as an unsigned int in hvc_opal_probe()."

We place () after function names, then "function" is not needed.

 > So when it output should be modified to %u format.

I cannot parse this. Perhaps:
"So when it is output, a %u specifier should be used for formatting."
? But feel free to use your own words, but somehow spell (or chatgpt) 
check it.

> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
> 
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 095c33ad10f8..1d2e7f2ce088 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev)
>   		/* Instanciate now to establish a mapping index==vtermno */
>   		hvc_instantiate(termno, termno, ops);
>   	} else {
> -		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n",
> +		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n",
>   		       dev->dev.of_node, termno);

There are more occurrences of this. Care to fix them all?

thanks,
-- 
js
suse labs

Re: [PATCH] tty:hvc:Fix incorrect formatted output

[Jiri Slaby]

Also please fix the subject. See:
git log --oneline drivers/tty/hvc/hvc_opal.c

On 07. 11. 24, 8:10, Jiri Slaby wrote:
> On 07. 11. 24, 6:47, liujing wrote:
>> The termno parameter is defined as an unsigned int
>> in hvc_opal_probe function,
> 
> "The termno parameter is defined as an unsigned int in hvc_opal_probe()."
> 
> We place () after function names, then "function" is not needed.
> 
>  > So when it output should be modified to %u format.
> 
> I cannot parse this. Perhaps:
> "So when it is output, a %u specifier should be used for formatting."
> ? But feel free to use your own words, but somehow spell (or chatgpt) 
> check it.
> 
>> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
>>
>> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
>> index 095c33ad10f8..1d2e7f2ce088 100644
>> --- a/drivers/tty/hvc/hvc_opal.c
>> +++ b/drivers/tty/hvc/hvc_opal.c
>> @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device 
>> *dev)
>>           /* Instanciate now to establish a mapping index==vtermno */
>>           hvc_instantiate(termno, termno, ops);
>>       } else {
>> -        pr_err("hvc_opal: Device %pOF has duplicate terminal number 
>> #%d\n",
>> +        pr_err("hvc_opal: Device %pOF has duplicate terminal number 
>> #%u\n",
>>                  dev->dev.of_node, termno);
> 
> There are more occurrences of this. Care to fix them all?
> 
> thanks,

-- 
js
suse labs

[PATCH] tty: hvc: Fix incorrect formatted output

[liujing]

The termno parameter is defined as an unsigned int 
in hvc_opal_probe(), So the output format should be %u instead of %d.

Signed-off-by: liujing <liujing@cmss.chinamobile.com>

---
v1 -> V2: Modified the description of commit.

diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
index 095c33ad10f8..1d2e7f2ce088 100644
--- a/drivers/tty/hvc/hvc_opal.c
+++ b/drivers/tty/hvc/hvc_opal.c
@@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev)
 		/* Instanciate now to establish a mapping index==vtermno */
 		hvc_instantiate(termno, termno, ops);
 	} else {
-		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n",
+		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n",
 		       dev->dev.of_node, termno);
 		return -ENXIO;
 	}
-- 
2.27.0

Re: [PATCH] tty: hvc: Fix incorrect formatted output

[Jiri Slaby]

On 07. 11. 24, 8:33, liujing wrote:
> The termno parameter is defined as an unsigned int
> in hvc_opal_probe(), So the output format should be %u instead of %d.
> 
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
> 
> ---
> v1 -> V2: Modified the description of commit.
> 
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 095c33ad10f8..1d2e7f2ce088 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev)
>   		/* Instanciate now to establish a mapping index==vtermno */
>   		hvc_instantiate(termno, termno, ops);
>   	} else {
> -		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n",
> +		pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n",

Please re-read my _whole_ previous e-mail.

-- 
js
suse labs

Re: [PATCH] tty: hvc: Fix incorrect formatted output

[Jiri Slaby]

On 07. 11. 24, 8:47, Jiri Slaby wrote:
> On 07. 11. 24, 8:33, liujing wrote:
>> The termno parameter is defined as an unsigned int
>> in hvc_opal_probe(), So the output format should be %u instead of %d.
>>
>> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
>>
>> ---
>> v1 -> V2: Modified the description of commit.

Yet, this is a v2, but the subject does not say so.

-- 
js
suse labs