From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A63ACE95A61 for ; Sat, 7 Oct 2023 17:33:57 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wFggfl5S; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S2spq4R7Vz3vZd for ; Sun, 8 Oct 2023 04:33:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=rdunlap@infradead.org; receiver=lists.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S2snl32Nzz307V for ; Sun, 8 Oct 2023 04:32:56 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=aJVvBE4SP5c8uAtSdDAuWAVhLtX7ZDGEDfCptajDH6k=; b=wFggfl5SM9G9zYhKm7l+YGoy21 oqRvLUxgsvRf5bDmcQ3izmplXtWY3KQ+rSU5OYf3uN0FyrbnbgGHok1snt20q59SL5E80/9lu9fy3 1+hElBG2xZM0QUmg66Xjz6GthUS6gJM8a3npbi9fxUaEXk9Sw0X+cQty9L2Hqyr/VV2fT76f4Jpj7 XIUVecYZOwjhq/nwla/GYBYF0dl4Aqis4aZek2MQGSkvAXRVQX/x6gcp8jZYUDHlf8PbQDmtuZL40 3gQF5xrl01yAF1PxvDpHrLgIqxdlqEp5UwtTJea2WleKR3vSnskg7/XNUGXBuaSzWXX5F9URhTlIz cQiQ3Q+Q==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qpBAO-007lyk-11; Sat, 07 Oct 2023 17:32:40 +0000 Message-ID: Date: Sat, 7 Oct 2023 10:32:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning) Content-Language: en-US From: Randy Dunlap To: Michael Ellerman , Stephen Rothwell , Linux Next Mailing List , tanyuan@tinylab.org References: <20230920133714.351f83f9@canb.auug.org.au> <87il83m5k0.fsf@mail.lhotse> <47afe095-0dd9-47bc-a4d1-dcd66f87ac7c@infradead.org> In-Reply-To: <47afe095-0dd9-47bc-a4d1-dcd66f87ac7c@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev , Linux Kernel Mailing List , Nicholas Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Michael, On 9/21/23 21:51, Randy Dunlap wrote: > > > On 9/21/23 17:10, Michael Ellerman wrote: >> Randy Dunlap writes: >>> On 9/19/23 20:37, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20230919: >>>> >>>> The mm tree lost its boot warning. >>>> >>>> The drm-misc tree gained a conflict against Linus' tree. >>>> >>>> Non-merge commits (relative to Linus' tree): 6006 >>>> 3996 files changed, 459968 insertions(+), 111742 deletions(-) >>>> >>>> ---------------------------------------------------------------------------- >>> >>> 4 out of 10 randconfigs have this warning: >>> >>> WARNING: unmet direct dependencies detected for ADB_CUDA >>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] >>> Selected by [y]: >>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] >>> >>> WARNING: unmet direct dependencies detected for ADB_CUDA >>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] >>> Selected by [y]: >>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] >>> >>> WARNING: unmet direct dependencies detected for ADB_CUDA >>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] >>> Selected by [y]: >>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] >> >> Crud. Caused by: >> >> a3ef2fef198c ("powerpc/32: Add dependencies of POWER_RESET for pmac32") >> >> I was suspicious of that select, I should have been *more* suspicious :) >> >> I think this is a fix. The PPC32 isn't needed because ADB depends on (PPC_PMAC && PPC32). > > Yes, that fixes the problem. Thanks. > > Tested-by: Randy Dunlap > Acked-by: Randy Dunlap > Will you be merging this fix? Thanks. >> >> diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig >> index 8bdae0caf21e..84f101ec53a9 100644 >> --- a/arch/powerpc/platforms/powermac/Kconfig >> +++ b/arch/powerpc/platforms/powermac/Kconfig >> @@ -2,7 +2,7 @@ >> config PPC_PMAC >> bool "Apple PowerMac based machines" >> depends on PPC_BOOK3S && CPU_BIG_ENDIAN >> - select ADB_CUDA if POWER_RESET && PPC32 >> + select ADB_CUDA if POWER_RESET && ADB >> select MPIC >> select FORCE_PCI >> select PPC_INDIRECT_PCI if PPC32 >> >> cheers > -- ~Randy