From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE34C43331 for ; Tue, 31 Mar 2020 03:07:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1F952072D for ; Tue, 31 Mar 2020 03:07:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1F952072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48rvPw1Ww3zDqkX for ; Tue, 31 Mar 2020 14:07:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.191; helo=huawei.com; envelope-from=yuehaibing@huawei.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48rvN60ZcSzDqN2 for ; Tue, 31 Mar 2020 14:05:39 +1100 (AEDT) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DB44D73EF08DFFDA918F; Tue, 31 Mar 2020 11:05:31 +0800 (CST) Received: from [127.0.0.1] (10.173.223.234) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 31 Mar 2020 11:05:26 +0800 Subject: Re: [PATCH] powerpc/44x: Make AKEBONO depends on NET To: Michael Ellerman , , , References: <20200330143153.32800-1-yuehaibing@huawei.com> <87pnctuyq3.fsf@mpe.ellerman.id.au> From: Yuehaibing Message-ID: Date: Tue, 31 Mar 2020 11:05:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87pnctuyq3.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.223.234] X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair@popple.id.au, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2020/3/31 8:58, Michael Ellerman wrote: > YueHaibing writes: >> Fix Kconfig warnings: >> >> WARNING: unmet direct dependencies detected for NETDEVICES >> Depends on [n]: NET [=n] >> Selected by [y]: >> - AKEBONO [=y] && PPC_47x [=y] >> >> WARNING: unmet direct dependencies detected for ETHERNET >> Depends on [n]: NETDEVICES [=y] && NET [=n] >> Selected by [y]: >> - AKEBONO [=y] && PPC_47x [=y] >> >> AKEBONO select NETDEVICES and ETHERNET unconditionally, > > It shouldn't do that, that's the job of a defconfig. > > It might want to enable NET_VENDOR_IBM iff the config already has NET > and other dependencies enabled. > > So the patch below might work? Yes, It works for me, Thanks! Tested-by: YueHaibing # build-tested > > cheers > > diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig > index 25ebe634a661..32aac4f40f1b 100644 > --- a/arch/powerpc/platforms/44x/Kconfig > +++ b/arch/powerpc/platforms/44x/Kconfig > @@ -207,9 +207,7 @@ config AKEBONO > select PPC4xx_HSTA_MSI > select I2C > select I2C_IBM_IIC > - select NETDEVICES > - select ETHERNET > - select NET_VENDOR_IBM > + imply NET_VENDOR_IBM > select IBM_EMAC_EMAC4 if IBM_EMAC > select USB if USB_SUPPORT > select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > > > >> If NET is not set, build fails. Add this dependcy to fix this. >> >> Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") >> Signed-off-by: YueHaibing >> --- >> arch/powerpc/platforms/44x/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig >> index 25ebe634a661..394f662d7df2 100644 >> --- a/arch/powerpc/platforms/44x/Kconfig >> +++ b/arch/powerpc/platforms/44x/Kconfig >> @@ -199,6 +199,7 @@ config FSP2 >> config AKEBONO >> bool "IBM Akebono (476gtr) Support" >> depends on PPC_47x >> + depends on NET >> select SWIOTLB >> select 476FPE >> select PPC4xx_PCI_EXPRESS >> -- >> 2.17.1 > > . >