From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36C4FC77B7C for ; Mon, 23 Jun 2025 15:28:02 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4bQsR44ZTtz30VV; Tue, 24 Jun 2025 01:28:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1750692480; cv=none; b=AAbZv9kia4Z3NYko9I39I9TUwpJzGZ+gsuTAynAkKJfw2AU/GcMwPqeULuub6n1GiW4975BNSQpuyOx9QgXFiOHbgFwIeuG8SN0Lh0xVSxdGqxz+trKCCg19/gH5Ru3UIDwHFWvCNqNfxW1VerdbXJV7SnTIpbWSG1AcMlCp9nFhdrY9XSURmY8OiA8He8xcMGfNCjzmIYXsYKxSTSMa61QvEj6H2HMFVMZSs0uf0axzXDUYMnlAU6tMdZejQvEd2+m3aMOPAMNy6/N5AzRARbUAg7G8Ph16Symr9KKQgT6VPhODNkPXgBzMxKR8FLkiYsXOH+TvDA+EEMX6yn3a0g== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1750692480; c=relaxed/relaxed; bh=Pxej4Be5/c9j1n89M+jkXuuoHAyPKQExUDiEWr44btc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h5Pt0OXIlwKOxh3f5ckNuX9a/PA0TrOVk9dcmEwx7DT/aNruNMds+6KMQ9pbhalKZFxEjAJNpDJLrexxBfAe7FxsUggSUQ+OxJfy8j15ZN/Qfjof/vZ0lgTOdT3Ik5nlLIy9IJBUHi0XqoW9yo2y/Yz6aG/Ds+0IarsLgmSVglBHH8sjf4S/UlPVGvopA9GeYEMcz9+N1nHq+ct08h7PWENMocyhZZZSGaRHOF61NE0fzWau33C5XwAvwMGH08N/s6k91SeSVaevA2BPbZ4RXiqlIXLDSIlCpahVdtw8d3VMT9pSbKiPCKsj5bJZVAhP7x9rUJyIBV2T26YauFio+w== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=L0guYrXa; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=L0guYrXa; dkim-atps=neutral; spf=pass (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=L0guYrXa; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=L0guYrXa; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4bQsR358mWz30Tm for ; Tue, 24 Jun 2025 01:27:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750692476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Pxej4Be5/c9j1n89M+jkXuuoHAyPKQExUDiEWr44btc=; b=L0guYrXa9rUSF9atjdyuJbVjzgRclMOylruLfjSuVFbodZJYsDdssICwP0IHPVLg6+j/0b LzGRLCtTQ8yx7YzuhJD3O4tn0NTZPpi0u6AP650aqwQ4nTy4OGu4XnviCm5Ki1HzzEYJq7 p4ayL0XWN+8CMG8/I9AKysNcXGkkFds= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750692476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Pxej4Be5/c9j1n89M+jkXuuoHAyPKQExUDiEWr44btc=; b=L0guYrXa9rUSF9atjdyuJbVjzgRclMOylruLfjSuVFbodZJYsDdssICwP0IHPVLg6+j/0b LzGRLCtTQ8yx7YzuhJD3O4tn0NTZPpi0u6AP650aqwQ4nTy4OGu4XnviCm5Ki1HzzEYJq7 p4ayL0XWN+8CMG8/I9AKysNcXGkkFds= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-QyPTKnfDOaa8UFxTKcf8Aw-1; Mon, 23 Jun 2025 11:27:55 -0400 X-MC-Unique: QyPTKnfDOaa8UFxTKcf8Aw-1 X-Mimecast-MFC-AGG-ID: QyPTKnfDOaa8UFxTKcf8Aw_1750692473 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d6768d4dso29437765e9.2 for ; Mon, 23 Jun 2025 08:27:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750692473; x=1751297273; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Pxej4Be5/c9j1n89M+jkXuuoHAyPKQExUDiEWr44btc=; b=DfziSr1dENku7DNVv0WsHLgIK+3cEUWQhVrEa4oeL3lR1wOi4Jdje/15VNJ0gCFtME gGGUwa2lInGM4zpAlLCIKXY20iSJhkHUNp3w/ND4C+MLuLHJK1dom+Wqud6lqL2+XuAh 4Xes/yi06z1Btd4FOD8NbjXo9uvKbIz98lDHmosWeaF3iwgsIuVi2bnONfYIT7zYY22o +1mDEHF4hcogppZeIn+ReI+wxwL8Y1fJHOt1eNVPpupIT3t42I/pe2WeLBGijtxJyy/z tu4C74etcyd6fI9eM7ZiliXT249yClW1LFOv1s8frmxeB5uhYQ3TEphON3kLhJFgms9Q nR5g== X-Forwarded-Encrypted: i=1; AJvYcCVz7sA4KptatqZO2NyJ/SfvPkb8M1zwaBC9I7Q3CEbNbsxknVjWPYqw1pAkGH1V3sM5FOYzX4BWbHomCnA=@lists.ozlabs.org X-Gm-Message-State: AOJu0YyagcwC4iYLBHfJTmVNS6vG7FREd3LQbr5cTrAG/UvtCSA3+H5d 27jtHhKxnOu2YAw7VqMICNrvQo2keL+Yq+Pj1qdewPkDUrFKRo6gtyEPyQZZZPoHCJGWyxCNWw2 7nxsv+Y9s+GL4SAKAz1WoyIuRo8Q919xBMwOMcpD3BKWkduskxoKbhZQ+5TyWEmyJlto= X-Gm-Gg: ASbGncvZuueoLNS9WVajr0UsL785SYWpKPvQR4AiGaeeWOP7gPmaGtPsVBWp+N+5eAx evZTmtKvlbgn7/+iugLj2NIv8kXhnFtOzFT7LWz5BBgtA34VzHmcOm9HvExvkiJCuvr/fdaE8pg 4tGBR92EqprA9BONk9zXmV+gY+JQLiPLyrM/R5o7CHIIzL1KvB90uSwtUvMmUsaP+fG6Femz4cS Y4x0AVEGVwoeYszYkRHcnZbYyHMgns+5cOEhrOxzEzWydSAGbajjnUSQ3VM4w4SntZNnvB1661k R1Nw1qr6PM8/g2R8BSVJxhkgXxxCGCWmpiv6N7kdzgWg+778Vw8/Vz3VIdPN/mKtb2qc55wksDS 9WurYvAtdteasitNgyQu0hYoAQGIlPFzvrCgLR45aOUReaaDmZQ== X-Received: by 2002:a05:6000:480f:b0:3a4:da87:3a73 with SMTP id ffacd0b85a97d-3a6d12dee06mr8313659f8f.42.1750692472665; Mon, 23 Jun 2025 08:27:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdT39TbThk3Qh/5ilj30MJfKQ2I2zikQzZNduY5teMOhv+k+uk/nLRmFEoy8dlARo9Q3L/mw== X-Received: by 2002:a05:6000:480f:b0:3a4:da87:3a73 with SMTP id ffacd0b85a97d-3a6d12dee06mr8313543f8f.42.1750692470720; Mon, 23 Jun 2025 08:27:50 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646cb5ecsm117373425e9.8.2025.06.23.08.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 08:27:49 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 17:27:47 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 04/29] mm/page_alloc: allow for making page types sticky until freed To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-5-david@redhat.com> <6E57AE2C-7754-4269-B16A-A39D168C5285@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6E57AE2C-7754-4269-B16A-A39D168C5285@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ab4p04xXI_ujIUD914oU3KQ3FG50bBxk0Fy6EGEXzJo_1750692473 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18.06.25 20:43, Zi Yan wrote: > On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > >> Let's allow for not clearing a page type before freeing a page to the >> buddy. >> >> We'll focus on having a type set on the first page of a larger >> allocation only. >> >> With this change, we can reliably identify typed folios even though >> they might be in the process of getting freed, which will come in handy >> in migration code (at least in the transition phase). >> >> Signed-off-by: David Hildenbrand >> --- >> mm/page_alloc.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 858bc17653af9..44e56d31cfeb1 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -1380,6 +1380,9 @@ __always_inline bool free_pages_prepare(struct page *page, >> mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); >> page->mapping = NULL; >> } >> + if (unlikely(page_has_type(page))) >> + page->page_type = UINT_MAX; >> + >> if (is_check_pages_enabled()) { >> if (free_page_is_bad(page)) >> bad++; > > Should we be pedantic to only do this for PageOffline and PageZsmalloc > and warn for the rest page types? I think we should just allow any page types. Limiting it to specific types sounds like some use-after-free check that probably shouldn't be handled that way. -- Cheers, David / dhildenb