[Bug 205303] New: Compilation for PPC64 fails on warning in watchdog.o

[Bug 205303] New: Compilation for PPC64 fails on warning in watchdog.o

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=205303

            Bug ID: 205303
           Summary: Compilation for PPC64 fails on warning in watchdog.o
           Product: Platform Specific/Hardware
           Version: 2.5
    Kernel Version: 5.3.7
          Hardware: PPC-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: blocking
          Priority: P1
         Component: PPC-64
          Assignee: platform_ppc-64@kernel-bugs.osdl.org
          Reporter: payphoneed@gmail.com
        Regression: No

Kernel compilation of 5.3.7 on PowerPC 64bit fails with a compiler warning
treated as an error.

arch/powerpc/kernel/watchdog.c: In function *watchdog_smp_panic*:
arch/powerpc/kernel/watchdog.c:175:4: error: implicit declaration of function
*smp_send_nmi_ipi*: did you mean *smp_send_stop*?
[-Werror=implicit-function-declaration]

SMP and Watchdog Timer Support are both disabled in this kernel configuration.

If additional information is necessary please ask.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 205303] Compilation for PPC64 fails on warning in watchdog.o

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=205303

--- Comment #1 from Edward Swiftwood (payphoneed@gmail.com) ---
I failed to mention, the machine is an Apple iMac G5 "PowerMac8,1", PPC970FX @
1600MHz. (https://everymac.com/systems/apple/imac/specs/imac_g5_1.6_17.html)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 205303] Compilation for PPC64 fails on warning in watchdog.o

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=205303

A. Wilcox (awilfox@adelielinux.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awilfox@adelielinux.org

--- Comment #2 from A. Wilcox (awilfox@adelielinux.org) ---
This is because CONFIG_HARDLOCK_DETECTOR is on and CONFIG_NMI_IPI is off.

CONFIG_HARDLOCK_DETECTOR pulls in CONFIG_PPC_WATCHDOG, which unconditionally
uses smp_send_nmi_ipi (and I believe requires such to work properly). 
CONFIG_PPC_WATCHDOG doesn't depend on CONFIG_NMI_IPI which it probably should. 
And then CONFIG_HARDLOCK_DETECTOR_ARCH should probably depend on CONFIG_NMI_IPI
or CONFIG_PPC_WATCHDOG.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 205303] Compilation for PPC64 fails on warning in watchdog.o

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=205303

Michael Ellerman (michael@ellerman.id.au) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |michael@ellerman.id.au
         Resolution|---                         |CODE_FIX

--- Comment #3 from Michael Ellerman (michael@ellerman.id.au) ---
This was fixed by:

4fe529449d85 ("powerpc: Fix HAVE_HARDLOCKUP_DETECTOR_ARCH build configuration")

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.