From: Geoff Levand <geoff@infradead.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v3 1/2] net/ps3_gelic: Add gelic_descr structures
Date: Sat, 17 Jul 2021 15:36:27 -0700 [thread overview]
Message-ID: <c0a78c3f-0934-bc29-147d-0b3e14efb70b@infradead.org> (raw)
In-Reply-To: <20210711160330.Horde.YmbaUrNaGLYM4ADZvVr_gA1@messagerie.c-s.fr>
Hi Christophe,
On 7/11/21 7:03 AM, Christophe Leroy wrote:
>
> Your patch has a lot of cosmetic changes. Several of them are just wrong. The other ones belong to another patch. This patch should focus only on the changes it targets.
>
> Your patch is way too big and addresses several different topics. Should be split in several patches.
>
> I suggest you run checkpatch.pl --strict on your patch
>
Thanks for the review. I'll create a follow up patch set with
your comments in mind.
-Geoff
next prev parent reply other threads:[~2021-07-17 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 4:15 [PATCH v3 0/2] DMA fixes for PS3 gelic network driver Geoff Levand
2021-07-11 4:15 ` [PATCH v3 1/2] net/ps3_gelic: Add gelic_descr structures Geoff Levand
2021-07-11 14:03 ` Christophe Leroy
2021-07-17 22:36 ` Geoff Levand [this message]
2021-07-11 4:15 ` [PATCH v3 2/2] net/ps3_gelic: Cleanups, improve logging Geoff Levand
2021-07-11 14:10 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0a78c3f-0934-bc29-147d-0b3e14efb70b@infradead.org \
--to=geoff@infradead.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).