* Re: [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
@ 2007-06-25 8:47 Yuri Tikhonov
2007-06-25 9:11 ` Segher Boessenkool
0 siblings, 1 reply; 7+ messages in thread
From: Yuri Tikhonov @ 2007-06-25 8:47 UTC (permalink / raw)
To: linuxppc-dev
Hi Dale, Kumar,
Thank you for your comments. All they make sense. Here is an update.
--
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index c3ce0bd..37c37a9 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -16,8 +16,6 @@ obj-$(CONFIG_FSL_SOC) += fsl_soc.o
obj-$(CONFIG_FSL_PCIE) += fsl_pcie.o
obj-$(CONFIG_TSI108_BRIDGE) += tsi108_pci.o tsi108_dev.o
obj-$(CONFIG_QUICC_ENGINE) += qe_lib/
-mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
-obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
# contains only the suspend handler for time
obj-$(CONFIG_PM) += timer.o
@@ -26,6 +24,8 @@ ifeq ($(CONFIG_PPC_MERGE),y)
obj-$(CONFIG_PPC_I8259) += i8259.o
obj-$(CONFIG_PPC_83xx) += ipic.o
obj-$(CONFIG_4xx) += uic.o
+mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
+obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
endif
# Temporary hack until we have migrated to asm-powerpc
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
2007-06-25 8:47 [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix Yuri Tikhonov
@ 2007-06-25 9:11 ` Segher Boessenkool
2007-06-25 9:51 ` Yuri Tikhonov
0 siblings, 1 reply; 7+ messages in thread
From: Segher Boessenkool @ 2007-06-25 9:11 UTC (permalink / raw)
To: Yuri Tikhonov; +Cc: linuxppc-dev
> +mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
> +obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o
> mv64x60_dev.o
How about
mv64x60-pci-$(CONFIG_PCI) += mv64x60_pci.o
mv64x60-objs := $(mv64x60-pci-y) mv64x60_pic.o
mv64x60_dev.o
obj-$(CONFIG_MV64X60) += mv64x60.o
so you can build it is a module, too (although other things
might be preventing that right now)?
Segher
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
2007-06-25 9:11 ` Segher Boessenkool
@ 2007-06-25 9:51 ` Yuri Tikhonov
2007-06-25 10:14 ` Segher Boessenkool
0 siblings, 1 reply; 7+ messages in thread
From: Yuri Tikhonov @ 2007-06-25 9:51 UTC (permalink / raw)
To: Segher Boessenkool; +Cc: linuxppc-dev
Hi Segher,
The mv64x60 driver has no support for compiling as a module. Built-in only.
And I think there is no much sense in making the driver which provide you
with such a base stuff as a boot console, ethernet, etc. to be a LKM.
Regards, Yuri.
On Monday 25 June 2007 13:11, you wrote:
> > +mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
> > +obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o
> > mv64x60_dev.o
>
> How about
>
> mv64x60-pci-$(CONFIG_PCI) += mv64x60_pci.o
> mv64x60-objs := $(mv64x60-pci-y) mv64x60_pic.o
> mv64x60_dev.o
> obj-$(CONFIG_MV64X60) += mv64x60.o
>
> so you can build it is a module, too (although other things
> might be preventing that right now)?
>
>
> Segher
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
2007-06-25 9:51 ` Yuri Tikhonov
@ 2007-06-25 10:14 ` Segher Boessenkool
0 siblings, 0 replies; 7+ messages in thread
From: Segher Boessenkool @ 2007-06-25 10:14 UTC (permalink / raw)
To: Yuri Tikhonov; +Cc: linuxppc-dev
> The mv64x60 driver has no support for compiling as a module. Built-in
> only.
Yeah I expected that that is the case right now. Could be
fixed later though.
> And I think there is no much sense in making the driver which provide
> you
> with such a base stuff as a boot console, ethernet, etc. to be a LKM.
That's orthogonal to expressing it as one "module" in Kbuild,
which is really just about grouping highly interdependent
stuff together.
But anyway, your patch looks good, I was just suggesting to
clean it up some more. You don't have to do it now if you
don't want to, I'm sure it will happen later :-)
[Oh, and don't top-post.]
>>> +mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
>>> +obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o
>>> mv64x60_dev.o
>>
>> How about
>>
>> mv64x60-pci-$(CONFIG_PCI) += mv64x60_pci.o
>> mv64x60-objs := $(mv64x60-pci-y) mv64x60_pic.o
>> mv64x60_dev.o
>> obj-$(CONFIG_MV64X60) += mv64x60.o
>>
>> so you can build it is a module, too (although other things
>> might be preventing that right now)?
Segher
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
@ 2007-06-24 11:52 Yuri Tikhonov
2007-06-24 22:46 ` Dale Farnsworth
0 siblings, 1 reply; 7+ messages in thread
From: Yuri Tikhonov @ 2007-06-24 11:52 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Stefan Roese
This patch fixes the issue of erroneously involving the
arch/powerpc/sysdev/mv64x60*.c files into the compilation
process for ppc- (not powerpc-) based platforms (e.g.,
P3M750).
Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
--
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index c3ce0bd..25eaa14 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -17,7 +17,9 @@ obj-$(CONFIG_FSL_PCIE) += fsl_pcie.o
obj-$(CONFIG_TSI108_BRIDGE) += tsi108_pci.o tsi108_dev.o
obj-$(CONFIG_QUICC_ENGINE) += qe_lib/
mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
+ifeq ($(CONFIG_PPC_MERGE),y)
obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
+endif
# contains only the suspend handler for time
obj-$(CONFIG_PM) += timer.o
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
2007-06-24 11:52 Yuri Tikhonov
@ 2007-06-24 22:46 ` Dale Farnsworth
2007-06-25 1:49 ` Kumar Gala
0 siblings, 1 reply; 7+ messages in thread
From: Dale Farnsworth @ 2007-06-24 22:46 UTC (permalink / raw)
To: yur, linuxppc-dev
In article <200706241552.31483.yur@emcraft.com> you write:
> This patch fixes the issue of erroneously involving the
> arch/powerpc/sysdev/mv64x60*.c files into the compilation
> process for ppc- (not powerpc-) based platforms (e.g.,
> P3M750).
>
> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
>
> --
>
> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
> index c3ce0bd..25eaa14 100644
> --- a/arch/powerpc/sysdev/Makefile
> +++ b/arch/powerpc/sysdev/Makefile
> @@ -17,7 +17,9 @@ obj-$(CONFIG_FSL_PCIE) += fsl_pcie.o
> obj-$(CONFIG_TSI108_BRIDGE) += tsi108_pci.o tsi108_dev.o
> obj-$(CONFIG_QUICC_ENGINE) += qe_lib/
> mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
Shouldn't the above line also be placed inside the of following ifeq ?
> +ifeq ($(CONFIG_PPC_MERGE),y)
> obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
> +endif
>
> # contains only the suspend handler for time
> obj-$(CONFIG_PM) += timer.o
Thanks,
-Dale
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
2007-06-24 22:46 ` Dale Farnsworth
@ 2007-06-25 1:49 ` Kumar Gala
0 siblings, 0 replies; 7+ messages in thread
From: Kumar Gala @ 2007-06-25 1:49 UTC (permalink / raw)
To: Dale Farnsworth; +Cc: linuxppc-dev
On Jun 24, 2007, at 5:46 PM, Dale Farnsworth wrote:
> In article <200706241552.31483.yur@emcraft.com> you write:
>> This patch fixes the issue of erroneously involving the
>> arch/powerpc/sysdev/mv64x60*.c files into the compilation
>> process for ppc- (not powerpc-) based platforms (e.g.,
>> P3M750).
>>
>> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
>>
>> --
>>
>> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/
>> Makefile
>> index c3ce0bd..25eaa14 100644
>> --- a/arch/powerpc/sysdev/Makefile
>> +++ b/arch/powerpc/sysdev/Makefile
>> @@ -17,7 +17,9 @@ obj-$(CONFIG_FSL_PCIE) += fsl_pcie.o
>> obj-$(CONFIG_TSI108_BRIDGE) += tsi108_pci.o tsi108_dev.o
>> obj-$(CONFIG_QUICC_ENGINE) += qe_lib/
>> mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
>
> Shouldn't the above line also be placed inside the of following ifeq ?
>
>> +ifeq ($(CONFIG_PPC_MERGE),y)
>> obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
>> +endif
>>
>> # contains only the suspend handler for time
>> obj-$(CONFIG_PM) += timer.o
Also, lets just move these into the existing ifeq
($CONFIG_PPC_MERGE,y) block in that makefile rather than introducing
a new one.
- k
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-06-25 10:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-25 8:47 [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix Yuri Tikhonov
2007-06-25 9:11 ` Segher Boessenkool
2007-06-25 9:51 ` Yuri Tikhonov
2007-06-25 10:14 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2007-06-24 11:52 Yuri Tikhonov
2007-06-24 22:46 ` Dale Farnsworth
2007-06-25 1:49 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).