From: Segher Boessenkool <segher@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, Chen Gong <g.chen@freescale.com>,
paulus@samba.org
Subject: Re: [PATCH 1/3] Add a new member name to structure irq_host
Date: Wed, 1 Aug 2007 01:42:58 +0200 [thread overview]
Message-ID: <c18c835d8538e7412d36d9ddf5b62eb6@kernel.crashing.org> (raw)
In-Reply-To: <1185923183.5380.0.camel@concordia.ozlabs.ibm.com>
>>> In that case, I would display the node full path.
>>
>> Those tend to be quite long, in the cases where there are
>> multiple interrupt controllers in the system; and really
>> useless otherwise. I think the interrupt controllers should
>> still just fill in the names "manually".
>
> They tend to be long, but they're unique, which is what you want,
Yeah -- easy enough to add a sequence number to just about
anything though.
> and they're only for debugging anyway.
Oh, I thought it would be used wherever the user gets told something
about the interrupt controller -- like when the interrupt tree would
be shown in sysfs (yes that's hypothetical still ;-) )
>> It's a good thing to have an of_node in the irq_host struct
>> anyway, though :-)
>
> I posted patches for that last week.
I know, and thank you :-)
Segher
next prev parent reply other threads:[~2007-07-31 23:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 11:13 [PATCH 0/3] Add virq mapping debugfs for PowerPC Chen Gong
2007-07-23 11:13 ` [PATCH 1/3] Add a new member name to structure irq_host Chen Gong
2007-07-23 11:13 ` [PATCH 2/3] Add irq host name for all powerpc interrupt controllors Chen Gong
2007-07-23 11:13 ` [PATCH 3/3] Add irq debugfs and virq_mapping for getting the virq Chen Gong
2007-07-23 22:04 ` [PATCH 1/3] Add a new member name to structure irq_host Benjamin Herrenschmidt
2007-07-23 23:22 ` Michael Ellerman
2007-07-23 23:36 ` Benjamin Herrenschmidt
2007-07-24 4:06 ` Chen Gong-B11801
2007-07-24 4:33 ` Benjamin Herrenschmidt
2007-07-24 9:25 ` Zhang Wei-r63237
2007-07-24 9:36 ` Benjamin Herrenschmidt
2007-07-25 7:03 ` Zhang Wei-r63237
2007-07-31 19:42 ` Segher Boessenkool
2007-07-31 21:44 ` Benjamin Herrenschmidt
2007-07-31 22:13 ` Segher Boessenkool
2007-07-31 23:06 ` Michael Ellerman
2007-07-31 23:42 ` Segher Boessenkool [this message]
2007-07-23 11:55 ` [PATCH 0/3] Add virq mapping debugfs for PowerPC Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c18c835d8538e7412d36d9ddf5b62eb6@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=g.chen@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).