Re: [PATCH 04/57] microblaze_v7: Open firmware files

Re: [PATCH 04/57] microblaze_v7: Open firmware files

[Arnd Bergmann]

On Wednesday 18 March 2009, monstr@monstr.eu wrote:
> From: Michal Simek <monstr@monstr.eu>
>=20
>=20
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> ---
> =A0arch/microblaze/include/asm/of_device.h =A0 | =A0 45 ++
> =A0arch/microblaze/include/asm/of_platform.h | =A0 64 ++
> =A0arch/microblaze/include/asm/prom.h =A0 =A0 =A0 =A0| =A0313 ++++++++
> =A0arch/microblaze/kernel/of_device.c =A0 =A0 =A0 =A0| =A0115 +++
> =A0arch/microblaze/kernel/of_platform.c =A0 =A0 =A0| =A0201 +++++
> =A0arch/microblaze/kernel/prom.c =A0 =A0 =A0 =A0 =A0 =A0 | 1147 +++++++++=
++++++++++++++++++++
> =A0arch/microblaze/kernel/prom_parse.c =A0 =A0 =A0 | 1025 +++++++++++++++=
+++++++++++
> =A07 files changed, 2910 insertions(+), 0 deletions(-)
> =A0create mode 100644 arch/microblaze/include/asm/of_device.h
> =A0create mode 100644 arch/microblaze/include/asm/of_platform.h
> =A0create mode 100644 arch/microblaze/include/asm/prom.h
> =A0create mode 100644 arch/microblaze/kernel/of_device.c
> =A0create mode 100644 arch/microblaze/kernel/of_platform.c
> =A0create mode 100644 arch/microblaze/kernel/prom.c
> =A0create mode 100644 arch/microblaze/kernel/prom_parse.c

Since these files are derived from the powerpc versions, what is the
plan on them? IIRC, you had them in a common directory in an earlier
version. Are you planning to merge them at some point in the future
or do you intend to maintain a fork?

	Arnd <><

Re: [PATCH 04/57] microblaze_v7: Open firmware files

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

Hi Arnd,

nice to hear you.

On Wednesday 18 March 2009, monstr@monstr.eu wrote:
> > From: Michal Simek <monstr@monstr.eu>
> >
> >
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
> > ---
> >  arch/microblaze/include/asm/of_device.h   |   45 ++
> >  arch/microblaze/include/asm/of_platform.h |   64 ++
> >  arch/microblaze/include/asm/prom.h        |  313 ++++++++
> >  arch/microblaze/kernel/of_device.c        |  115 +++
> >  arch/microblaze/kernel/of_platform.c      |  201 +++++
> >  arch/microblaze/kernel/prom.c             | 1147
> +++++++++++++++++++++++++++++
> >  arch/microblaze/kernel/prom_parse.c       | 1025
> ++++++++++++++++++++++++++
> >  7 files changed, 2910 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/microblaze/include/asm/of_device.h
> >  create mode 100644 arch/microblaze/include/asm/of_platform.h
> >  create mode 100644 arch/microblaze/include/asm/prom.h
> >  create mode 100644 arch/microblaze/kernel/of_device.c
> >  create mode 100644 arch/microblaze/kernel/of_platform.c
> >  create mode 100644 arch/microblaze/kernel/prom.c
> >  create mode 100644 arch/microblaze/kernel/prom_parse.c
>
> Since these files are derived from the powerpc versions, what is the
> plan on them? IIRC, you had them in a common directory in an earlier
> version. Are you planning to merge them at some point in the future
> or do you intend to maintain a fork?


yes, these files are defived from PPC version. Yes, I added them to generic
location and in this version
are in arch folder. It is easier for me to have them in arch folder till
Microblaze will be in  linus tree.
And then create patch which will synchronize them.

I prefer to have this code in generic location as much as possible but first
stage should be add microblaze code to tree and
then add it to generic location and remove it from all archs which use it.

Thanks,
Michal





>
>
>        Arnd <><
>

[-- Attachment #2: Type: text/html, Size: 2477 bytes --]

Re: [PATCH 04/57] microblaze_v7: Open firmware files

[Anton Vorontsov]

On Mon, Mar 23, 2009 at 07:51:23PM +0100, Arnd Bergmann wrote:
> On Wednesday 18 March 2009, monstr@monstr.eu wrote:
> > From: Michal Simek <monstr@monstr.eu>
> > 
> > 
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
> > ---
> >  arch/microblaze/include/asm/of_device.h   |   45 ++
> >  arch/microblaze/include/asm/of_platform.h |   64 ++
> >  arch/microblaze/include/asm/prom.h        |  313 ++++++++
> >  arch/microblaze/kernel/of_device.c        |  115 +++
> >  arch/microblaze/kernel/of_platform.c      |  201 +++++
> >  arch/microblaze/kernel/prom.c             | 1147 +++++++++++++++++++++++++++++
> >  arch/microblaze/kernel/prom_parse.c       | 1025 ++++++++++++++++++++++++++
> >  7 files changed, 2910 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/microblaze/include/asm/of_device.h
> >  create mode 100644 arch/microblaze/include/asm/of_platform.h
> >  create mode 100644 arch/microblaze/include/asm/prom.h
> >  create mode 100644 arch/microblaze/kernel/of_device.c
> >  create mode 100644 arch/microblaze/kernel/of_platform.c
> >  create mode 100644 arch/microblaze/kernel/prom.c
> >  create mode 100644 arch/microblaze/kernel/prom_parse.c
> 
> Since these files are derived from the powerpc versions, what is the
> plan on them? IIRC, you had them in a common directory in an earlier
> version. Are you planning to merge them at some point in the future
> or do you intend to maintain a fork?

Actually, it's trivial to factor out all the common code out of
arch/powerpc/ to drivers/of/.

It took me approx. 4 hours to factor out the code and make a
proof-of-concept FDT support for a little-endian ARM platform. ;-)
(The device tree was only describing a cpu and a nor flash, though.
No support for interrupt- and gpio-controllers. And no support for
U-Boot, I just built the dtb file into the kernel).

I never got around to clean it up and send though, but for sure,
there is absolutely no reason to duplicate the code across the
platforms.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

Re: [PATCH 04/57] microblaze_v7: Open firmware files

[Michal Simek]

Arnd Bergmann wrote:
> On Wednesday 18 March 2009, monstr@monstr.eu wrote:
>> From: Michal Simek <monstr@monstr.eu>
>>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>>  arch/microblaze/include/asm/of_device.h   |   45 ++
>>  arch/microblaze/include/asm/of_platform.h |   64 ++
>>  arch/microblaze/include/asm/prom.h        |  313 ++++++++
>>  arch/microblaze/kernel/of_device.c        |  115 +++
>>  arch/microblaze/kernel/of_platform.c      |  201 +++++
>>  arch/microblaze/kernel/prom.c             | 1147 +++++++++++++++++++++++++++++
>>  arch/microblaze/kernel/prom_parse.c       | 1025 ++++++++++++++++++++++++++
>>  7 files changed, 2910 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/microblaze/include/asm/of_device.h
>>  create mode 100644 arch/microblaze/include/asm/of_platform.h
>>  create mode 100644 arch/microblaze/include/asm/prom.h
>>  create mode 100644 arch/microblaze/kernel/of_device.c
>>  create mode 100644 arch/microblaze/kernel/of_platform.c
>>  create mode 100644 arch/microblaze/kernel/prom.c
>>  create mode 100644 arch/microblaze/kernel/prom_parse.c
> 
> Since these files are derived from the powerpc versions, what is the
> plan on them? IIRC, you had them in a common directory in an earlier
> version. Are you planning to merge them at some point in the future
> or do you intend to maintain a fork?

yes, these files are defived from PPC version. Yes, I added them to generic
location and in this version are in arch folder. It is easier for me to have
them in arch folder till Microblaze will be in linus tree.
And then create patch which will synchronize them.

I prefer to have this code in generic location as much as possible but first
stage from my perspective should be add microblaze code to tree and then add it
to generic location and remove it from all archs which use it.

Thanks,
Michal

> 	Arnd <><


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854

Re: [PATCH 04/57] microblaze_v7: Open firmware files

[Benjamin Herrenschmidt]

On Mon, 2009-03-23 at 23:53 +0300, Anton Vorontsov wrote:
> It took me approx. 4 hours to factor out the code and make a
> proof-of-concept FDT support for a little-endian ARM platform. ;-)
> (The device tree was only describing a cpu and a nor flash, though.
> No support for interrupt- and gpio-controllers. And no support for
> U-Boot, I just built the dtb file into the kernel).

ARM could benefit tremendously I believe from a similar virtualized
interrupt mapping & OF tree to powerpc for their gazillions of weirdly
cascaded interrupt controller setups :-)

Ben.