From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F43C433F5 for ; Wed, 2 Feb 2022 13:46:51 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JpjlF4gmSz3bbS for ; Thu, 3 Feb 2022 00:46:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DkU8Rpw7; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DkU8Rpw7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DkU8Rpw7; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DkU8Rpw7; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JpjkL5lLFz2xrt for ; Thu, 3 Feb 2022 00:46:00 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643809557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxruncnGKSYEtQADjLUNkNWhCcGBbzpK2sbDwkeQUpo=; b=DkU8Rpw78T3QRSsSfeTel/rw9Ah6qfxCS4j08kyO/akcm+r2HoDdZvontPKJz98SSrhkrq RjjhA6x12oBPdYUIO2eq3WQah7pghe5rfAyUnNs0ydnpusbUxHr2kVBvifqTPJJXSN65Gr RGMl+2+/2hPHrrCFYovyk+DYhLzIKvE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643809557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxruncnGKSYEtQADjLUNkNWhCcGBbzpK2sbDwkeQUpo=; b=DkU8Rpw78T3QRSsSfeTel/rw9Ah6qfxCS4j08kyO/akcm+r2HoDdZvontPKJz98SSrhkrq RjjhA6x12oBPdYUIO2eq3WQah7pghe5rfAyUnNs0ydnpusbUxHr2kVBvifqTPJJXSN65Gr RGMl+2+/2hPHrrCFYovyk+DYhLzIKvE= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-jT9cVls7NJa88PxLSWmxMw-1; Wed, 02 Feb 2022 08:45:54 -0500 X-MC-Unique: jT9cVls7NJa88PxLSWmxMw-1 Received: by mail-ed1-f72.google.com with SMTP id w3-20020a50c443000000b0040696821132so10400874edf.22 for ; Wed, 02 Feb 2022 05:45:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=YxruncnGKSYEtQADjLUNkNWhCcGBbzpK2sbDwkeQUpo=; b=NOj54r/6rzRBH18EOuFpV/FAsKHgGrqMSabE5ZoOrkZbj6n1SryAxtS/wzqB13W7G9 DWUfdFNWrJBjijyJIlQg0fXcKdhUx53NF6Vit8ALQ6CJGbXcDktYq6SJBAzyt7pCY4k/ Cj2ksHixbzQ4TXx81Hy7CQm5/3vdwvPyK4MId1yuTJvyC4OcUPxEWVLiAmvAcC7hIipe hqqWod3w5aI9aS+3wVBMavsaWnbvjaWj1VQEZ6hjNhikFsErJgOYp4J4PZkU/DpO3iWS H89K/Jo/XSd+kzDqUzmg/URI7Wl/4OqURSnyhlGSE2e4OCJPqa+cKwRPUE7RvA5xmGln x0lw== X-Gm-Message-State: AOAM531yqC/XmWFqiZxaJNTnsUlDDbxkvmk6rCDxT6Z6L0GizppchR9t k39UTVFKm5+DV8M6JGgc/aw4coW6EL/11OASAdWrGquGGnB8vDK6C06JqZtuRAVdzd7iqauRwZp eOp3BqffLzgbnxbdEWvUXhOX2YQ== X-Received: by 2002:a05:6402:5248:: with SMTP id t8mr30084269edd.14.1643809552842; Wed, 02 Feb 2022 05:45:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqE4L2UK0676VaeKIuCkwGMt3tw/zzsCSLR83dbtSZbWUp25WGEt3s5690JhdDTieh82ha0w== X-Received: by 2002:a05:6402:5248:: with SMTP id t8mr30084241edd.14.1643809552570; Wed, 02 Feb 2022 05:45:52 -0800 (PST) Received: from ?IPV6:2003:cb:c709:f800:a55c:e484:3cd9:3632? (p200300cbc709f800a55ce4843cd93632.dip0.t-ipconnect.de. [2003:cb:c709:f800:a55c:e484:3cd9:3632]) by smtp.gmail.com with ESMTPSA id z8sm15746580ejc.151.2022.02.02.05.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 05:45:52 -0800 (PST) Message-ID: Date: Wed, 2 Feb 2022 14:45:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() To: linux-kernel@vger.kernel.org References: <20220128151540.164759-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220128151540.164759-1-david@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , linux-ia64@vger.kernel.org, "Rafael J. Wysocki" , Dave Hansen , linux-mm@kvack.org, Rich Felker , Paul Mackerras , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , linux-s390@vger.kernel.org, Yoshinori Sato , linux-sh@vger.kernel.org, x86@kernel.org, Ingo Molnar , Catalin Marinas , Albert Ou , Vasily Gorbik , Heiko Carstens , Borislav Petkov , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Oscar Salvador , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 28.01.22 16:15, David Hildenbrand wrote: > ... and call node_dev_init() after memory_dev_init() from driver_init(), > so before any of the existing arch/subsys calls. All online nodes should > be known at that point. > > This is in line with memory_dev_init(), which initializes the memory > device subsystem and creates all memory block devices. > > Similar to memory_dev_init(), panic() if anything goes wrong, we don't > want to continue with such basic initialization errors. > > The important part is that node_dev_init() gets called after > memory_dev_init() and after cpu_dev_init(), but before any of the > relevant archs call register_cpu() to register the new cpu device under > the node device. The latter should be the case for the current users > of topology_init(). > > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Thomas Bogendoerfer > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "Rafael J. Wysocki" > Cc: x86@kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-ia64@vger.kernel.org > Cc: linux-mips@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: David Hildenbrand If there are no further comments, then I'll resend as !RFC with a slightly extended patch description, testing at least under arm64 and ppc64 as they are relatively easy to test for me. -- Thanks, David / dhildenb