From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E78EAC433B4 for ; Fri, 16 Apr 2021 13:28:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4820C61073 for ; Fri, 16 Apr 2021 13:28:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4820C61073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FMH8d6dGHz3c6v for ; Fri, 16 Apr 2021 23:28:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Z94XpQHv; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aWU2PJWf; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=pbonzini@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Z94XpQHv; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aWU2PJWf; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FMH874n4vz30Cy for ; Fri, 16 Apr 2021 23:27:50 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618579665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JAKUqXFHXuyIOfRcOhTnPnVKgo/XPbGiNpXU9KPW1QA=; b=Z94XpQHvuhQ3w8zOHIMkRRau4BO+WQaM+PRypVmTn+TDqAfgrIFOge9nX+cGMuX7r+ELEn HFheITuz4wJACJltQu5Nfn3yJ6Z0ZNVrXnADmVeoyK6RJa0TRCymaRBEnB228xdN7JVcVM lrNh8SlHhOu/vnAlZCc2VOvgpJD+BMM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618579666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JAKUqXFHXuyIOfRcOhTnPnVKgo/XPbGiNpXU9KPW1QA=; b=aWU2PJWfaAucIpxu3Q8DgkHMD+KRJDXCR5gqKVhZYkRBFOFbcQ3jWQYjIRfefU9qRaPpby tjaH33B49Jo5OCUyrkd8yEBM1abDhUT5gVg43F+mM+YYQ7LgLkHMgwLIhg7Zwmi97MNhfp NY/PjSoQREUdnfHgJti6SQSwzUykPQY= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247--yg4zKJDMQ-ueDeB6tHN6Q-1; Fri, 16 Apr 2021 09:27:43 -0400 X-MC-Unique: -yg4zKJDMQ-ueDeB6tHN6Q-1 Received: by mail-ej1-f71.google.com with SMTP id lf6-20020a1709071746b029037cee5e31c4so2008143ejc.13 for ; Fri, 16 Apr 2021 06:27:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JAKUqXFHXuyIOfRcOhTnPnVKgo/XPbGiNpXU9KPW1QA=; b=o6dBukP07f/9+pzdrhoVOarIcHH0W+zzafQH9sfguguEly/OzJwNXBsrfH9xSaPHNZ cfliv/uCMU2m6tqFo26mfK5GsmD4YM2x9DtEf02V7393ojrrnKzem8jtqZgtYuONREfs /HILjG6aJrjimU/H8MJTnAbHZfh/U+wfFzoiWpwFAevOeK8RSMukoi1xUb1tlCntKr8k FPTd5Kj8TpaHcB/S8OSC3X3KhCkMF/ko64VXgj7vXVhInKodNzf3ijmWamRlXYpqx81E PPYJVAeedhxlUN7+OmB3GO6K7sgA76ThZ9PrseX1a/0A6FhjmNkJQPgfPv3UpEG5dMxb JeoA== X-Gm-Message-State: AOAM533SQWNcXL4+o6dcx8aqKfyElQ+EgwApsW7nr8lanpc3RIlMzjQd LCbnNP5WWY9HdJdISvLQ9Bk256gTaz+zCly3d0x92BWUCRgJXAAZF4UA4bfNb+feYMEwK5DSNkb NQ4AyqbZx0d+iv32+J5MDEnGlEw== X-Received: by 2002:a17:906:3e4a:: with SMTP id t10mr7812301eji.553.1618579662296; Fri, 16 Apr 2021 06:27:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6UeUn5HRMxz6UHppX8f3UHpv0mBTcngffZpbHmagQPNNqqfWIQKVS47kiiMglIJ9lySwYmg== X-Received: by 2002:a17:906:3e4a:: with SMTP id t10mr7812280eji.553.1618579662121; Fri, 16 Apr 2021 06:27:42 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id p7sm4198620eja.103.2021.04.16.06.27.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 06:27:41 -0700 (PDT) Subject: Re: [PATCH v2] tools: do not include scripts/Kbuild.include To: Christian Borntraeger , Masahiro Yamada , linux-kbuild@vger.kernel.org References: <20210416130051.239782-1-masahiroy@kernel.org> From: Paolo Bonzini Message-ID: Date: Fri, 16 Apr 2021 15:27:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , kvm@vger.kernel.org, Alexei Starovoitov , Paul Mackerras , linux-kselftest@vger.kernel.org, Shuah Khan , Janosch Frank , Daniel Borkmann , John Fastabend , Andrii Nakryiko , clang-built-linux@googlegroups.com, Yonghong Song , KP Singh , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 16/04/21 15:26, Christian Borntraeger wrote: > > > On 16.04.21 15:00, Masahiro Yamada wrote: >> Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to >> scripts/Makefile.compiler"), some kselftests fail to build. >> >> The tools/ directory opted out Kbuild, and went in a different >> direction. They copy any kind of files to the tools/ directory >> in order to do whatever they want in their world. >> >> tools/build/Build.include mimics scripts/Kbuild.include, but some >> tool Makefiles included the Kbuild one to import a feature that is >> missing in tools/build/Build.include: >> >>   - Commit ec04aa3ae87b ("tools/thermal: tmon: use "-fstack-protector" >>     only if supported") included scripts/Kbuild.include from >>     tools/thermal/tmon/Makefile to import the cc-option macro. >> >>   - Commit c2390f16fc5b ("selftests: kvm: fix for compilers that do >>     not support -no-pie") included scripts/Kbuild.include from >>     tools/testing/selftests/kvm/Makefile to import the try-run macro. >> >>   - Commit 9cae4ace80ef ("selftests/bpf: do not ignore clang >>     failures") included scripts/Kbuild.include from >>     tools/testing/selftests/bpf/Makefile to import the .DELETE_ON_ERROR >>     target. >> >>   - Commit 0695f8bca93e ("selftests/powerpc: Handle Makefile for >>     unrecognized option") included scripts/Kbuild.include from >>     tools/testing/selftests/powerpc/pmu/ebb/Makefile to import the >>     try-run macro. >> >> Copy what they need into tools/build/Build.include, and make them >> include it instead of scripts/Kbuild.include. >> >> Link: >> https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f45a1@linux.ibm.com/ >> >> Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to >> scripts/Makefile.compiler") >> Reported-by: Janosch Frank >> Reported-by: Christian Borntraeger >> Signed-off-by: Masahiro Yamada > > looks better. > Tested-by: Christian Borntraeger > Thank you very much Masahiro, this look great. Paolo