From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AEEEC43334 for ; Wed, 13 Jul 2022 14:43:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LjgNF69YDz3cGC for ; Thu, 14 Jul 2022 00:43:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HaOk0QSz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=rdunlap@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HaOk0QSz; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LjgMT19DKz2x9J for ; Thu, 14 Jul 2022 00:42:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=68ViflEzlXDx+7TKBapr6Ak8Jvjo25dHgw/5Ff89KiA=; b=HaOk0QSze3GgDOQtZ2NA1ChzrB usRgqoTT6zsaUHt8WwxG5NjIR/C3QKzIvOK8QiwZV49eD3cKcM7pshfOyxDFZNMJeyx+1uiE1u1BA igLOsmbFzYzVF5usNyifn9hftgG908/stYIT7ZbwHLL0GeHjXupvFUkBk7ICROmWcAw8zjYp1tXhA uDcu1qQYoaf0rleXhptUIFl8LKxfKeSPSritkl1naMbWV5AjZ6UwrMCaZe4ju+8EIJ97aUanDeFrN SqiNIZhfvbl7jBpBlurF8NVlxua+/AcW0sGs2XFfR0dk5APgiJSXgRHedNwzikoyi1xuiwgU5zat5 6Hm6vLOw==; Received: from [2601:1c0:6280:3f0::a6b3] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBdZQ-004coL-AJ; Wed, 13 Jul 2022 14:42:32 +0000 Message-ID: Date: Wed, 13 Jul 2022 07:42:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 4/4] pseries/mobility: set NMI watchdog factor during LPM Content-Language: en-US To: Laurent Dufour , mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, wim@linux-watchdog.org, linux@roeck-us.net, nathanl@linux.ibm.com References: <20220712143202.23144-1-ldufour@linux.ibm.com> <20220712143202.23144-5-ldufour@linux.ibm.com> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, haren@linux.vnet.ibm.com, linux-watchdog@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, On 7/13/22 03:56, Laurent Dufour wrote: > Le 12/07/2022 à 18:25, Randy Dunlap a écrit : >> Hi-- >> >> On 7/12/22 07:32, Laurent Dufour wrote: >>> >>> Reviewed-by: Nicholas Piggin >>> Signed-off-by: Laurent Dufour >>> --- >>> Documentation/admin-guide/sysctl/kernel.rst | 12 ++++++ >>> arch/powerpc/platforms/pseries/mobility.c | 43 +++++++++++++++++++++ >>> 2 files changed, 55 insertions(+) >>> >>> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst >>> index ddccd1077462..0bb0b7f27e96 100644 >>> --- a/Documentation/admin-guide/sysctl/kernel.rst >>> +++ b/Documentation/admin-guide/sysctl/kernel.rst >>> @@ -592,6 +592,18 @@ to the guest kernel command line (see >>> Documentation/admin-guide/kernel-parameters.rst). >>> >> >> This entire block should be in kernel-parameters.txt, not .rst, >> and it should be formatted like everything else in the .txt file. My apologies. I misread the file name. I don't see a problem with this part of the patch or its location. > Thanks for reviewing this patch. > > I'll apply your requests in the next version. > > However, regarding the change in kernel-parameters.txt, I'm confused. The > newly introduced parameter is only exposed through sysctl. Not as a kernel > boot option. In that case, should it be mentioned in kernel-parameters.txt? > > Documentation/process/4.Coding.rst says: > The file :ref:`Documentation/admin-guide/kernel-parameters.rst > ` describes all of the kernel's boot-time parameters. > Any patch which adds new parameters should add the appropriate entries to > this file. > > And Documentation/process/submit-checklist.rst says: > 16) All new kernel boot parameters are documented in > ``Documentation/admin-guide/kernel-parameters.rst``. > > What are the rules about editing .txt or .rst files? Yeah, that's a little confusing. kernel-parameters.txt in included in kernel-parameters.rst when 'make htmldocs' is run, so the produced output looks like it is from the .rst file. Kernel boot parameters should be added to the .txt file. The .rst file is just intro material. Thanks. -- ~Randy