From: Disha Goel <disgoel@linux.vnet.ibm.com>
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
acme@kernel.org, jolsa@kernel.org
Cc: irogers@google.com, maddy@linux.vnet.ibm.com,
rnsastry@linux.ibm.com, linux-perf-users@vger.kernel.org,
kjain@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries
Date: Thu, 05 May 2022 16:19:17 +0530 [thread overview]
Message-ID: <c3c66a0ef4a5441bd469e4d4e2c8f8a137d929a7.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20220505094000.58220-1-atrajeev@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]
-----Original Message-----
From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@kernel.org, disgoel@linux.vnet.ibm.com
Cc: mpe@ellerman.id.au, linux-perf-users@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, maddy@linux.vnet.ibm.com,
rnsastry@linux.ibm.com, kjain@linux.ibm.com, irogers@google.com
Subject: [PATCH V2 0/2] Fix session topology test for powerpc and add
utility function to get cpuinfo entries
Date: Thu, 5 May 2022 15:09:58 +0530
The session topology test fails in powerpc pSeries platform.Test
logs:<<>>Session topology : FAILED!<<>>
This test uses cpu topology information and in powerpc,some of the
topology info is restricted in environmentlike virtualized platform.
Hence this test needs to beskipped in pSeries platform for powerpc. The
informationabout platform is available in /proc/cpuinfo.
Patch 1 adds generic utility function in "util/header.c"to read
/proc/cpuinfo for any entry. Though the testcasefix needs value from
"platform" entry, making this as ageneric function to return value for
any entry from the/proc/cpuinfo file which can be used commonly in
futureusecases.
Patch 2 uses the newly added utility function to look forplatform and
skip the test in pSeries platform for powerpc.
Athira Rajeev (2): tools/perf: Add utility function to read
/proc/cpuinfo for any field tools/perf/tests: Fix session topology
test to skip the test in guest environment
Changelog: V1 -> v2: Addressed review comments from Kajol. Use "strim"
to remove space from string. Also use "feof" to check for EOF instead
of using new variable "ret".
Tested the patches on powervm and powernv, verified perf test session
topology test with the patch set.Tested-by: Disha Goel <
disgoel@linux.vnet.ibm.com>
tools/perf/tests/topology.c | 17 ++++++++++++
tools/perf/util/header.c | 53 +++++++++++++++++++++++++++++++++++++
tools/perf/util/header.h | 1 + 3 files changed, 71 insertions(+)
[-- Attachment #2: Type: text/html, Size: 3474 bytes --]
next prev parent reply other threads:[~2022-05-05 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 9:39 [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries Athira Rajeev
2022-05-05 9:39 ` [PATCH V2 1/2] tools/perf: Add utility function to read /proc/cpuinfo for any field Athira Rajeev
2022-05-05 17:24 ` Arnaldo Carvalho de Melo
2022-05-06 9:33 ` Athira Rajeev
2022-05-10 13:38 ` Athira Rajeev
2022-05-10 17:08 ` Arnaldo Carvalho de Melo
2022-05-05 9:40 ` [PATCH V2 2/2] tools/perf/tests: Fix session topology test to skip the test in guest environment Athira Rajeev
2022-05-06 2:40 ` Michael Ellerman
2022-05-05 10:49 ` Disha Goel [this message]
2022-05-05 10:52 ` [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3c66a0ef4a5441bd469e4d4e2c8f8a137d929a7.camel@linux.vnet.ibm.com \
--to=disgoel@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=rnsastry@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).