linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* gen550_dbg.c cannot handle 16 or 32 bit access to UART registers
@ 2005-08-09 22:23 Shawn Jin
  0 siblings, 0 replies; only message in thread
From: Shawn Jin @ 2005-08-09 22:23 UTC (permalink / raw)
  To: ppcembed

Hi,

The arch/ppc/syslib/gen550_dbg.c assumes UART registers are all
accessed in bytes. However in some designs the bus connected to UART
can only be addressed in 32 or 16 bits. So some flexibility is
desirable. And the change is kinda trivial.

Before making this trivial change, I'm confused about two sets of
defintions on io_type. In <linux/serial.h>, the following are defined.
#define SERIAL_IO_PORT=090
#define SERIAL_IO_HUB6=091
#define SERIAL_IO_MEM=092

However in <linux/serial_core.h>, these are defined.
#define UPIO_PORT=09=09(0)
#define UPIO_HUB6=09=09(1)
#define UPIO_MEM=09=09(2)
#define UPIO_MEM32=09=09(3)

Which set of defintion is better to be used in defining
SERIAL_PORT_DFNS? Currently gen550_gdb.c use SERAIL_IO_XXXX macros.
Either adding a new macro SERIAL_IO_MEM32 in <linux/serial.h> or just
use what are already there.

Are these two sets duplicated? If they are, maybe one of them will be
deprecated soon.

Regards,
-Shawn.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-08-09 22:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-09 22:23 gen550_dbg.c cannot handle 16 or 32 bit access to UART registers Shawn Jin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).