From: Shawn Jin <shawnxjin@gmail.com>
To: Shawn Jin <shawnxjin@gmail.com>, ppcembed <linuxppc-embedded@ozlabs.org>
Subject: Re: writel(), readl() in <asm-ppc/io.h>
Date: Sun, 14 Aug 2005 11:16:38 -0700 [thread overview]
Message-ID: <c3d0340b05081411164dcc694e@mail.gmail.com> (raw)
In-Reply-To: <20050814042556.GB23952@gate.ebshome.net>
> > The problem is that read*()/write*() are misused in some places, e.g.,
> > serial drivers such as serial8250. The serial_in() and serial_out()
> > call read*() and write*() respectively. So what's your recommendation
> > in such a case?
>=20
> Why do you think this is a problem? Why do you think they are
> misused? Please explain.
IMHO, serial_in() and serial_out() should be able to handle all the
possilbilities. But the current implementation cannot achieve this by
simply calling read*() and write*() in the case that UART control
registers are 32-bit or 16-bit wide and can only be acessed in 32/16
bits in some big endian systems. As Matt pointed out before, read*()
and write*() are designed for PCI access only.
Regards,
-Shawn.
next prev parent reply other threads:[~2005-08-14 18:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-13 1:11 writel(), readl() in <asm-ppc/io.h> Shawn Jin
2005-08-13 3:33 ` Matt Porter
2005-08-14 3:56 ` Shawn Jin
2005-08-14 4:25 ` Eugene Surovegin
2005-08-14 18:16 ` Shawn Jin [this message]
2005-08-14 16:14 ` Matt Porter
2005-08-14 16:36 ` Arthur Othieno
2005-08-14 18:53 ` Shawn Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3d0340b05081411164dcc694e@mail.gmail.com \
--to=shawnxjin@gmail.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).