From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/82xx: Select FSL_SOC
Date: Fri, 15 Sep 2023 05:05:21 +0000 [thread overview]
Message-ID: <c481fa91-0cfb-1c19-2da7-cf768bc56aea@csgroup.eu> (raw)
In-Reply-To: <87led86zaq.fsf@mail.lhotse>
Le 15/09/2023 à 02:43, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@csgroup.eu> writes:
>> It used to be impossible to select CONFIG_CPM2 without selecting
>> CONFIG_FSL_SOC at the same time because CONFIG_CPM2 was dependent
>> on CONFIG_8260 and CONFIG_8260 was selecting CONFIG_FSL_SOC.
>>
>> But after commit eb5aa2137275 ("powerpc/82xx: Remove CONFIG_8260
>> and CONFIG_8272") CONFIG_CPM2 depends on CONFIG_MPC82xx instead
> ^
> CONFIG_PPC_82xx
>
> All the references to CONFIG_MPC82xx should be CONFIG_PPC_82xx right?
> I can update when applying.
Ah right, I mixed things up. This is CONFIG_PPC_82xx, CONFIG_PPC_8xx,
CONFIG_PPC_83xx and CONFIG_PPC_MPC512x
>
> cheers
>
>
>> but CONFIG_MPC82xx doesn't directly selects CONFIG_FSL_SOC.
>>
>> Fix it by forcing CONFIG_MPC82xx to select CONFIG_FSL_SOC just
>> like already done by MPC8xx, MPC512x, MPC83xx, PPC_86xx.
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Fixes: eb5aa2137275 ("powerpc/82xx: Remove CONFIG_8260 and CONFIG_8272")
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> ---
>> arch/powerpc/platforms/82xx/Kconfig | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/82xx/Kconfig b/arch/powerpc/platforms/82xx/Kconfig
>> index d9f1a2a83158..1824536cf6f2 100644
>> --- a/arch/powerpc/platforms/82xx/Kconfig
>> +++ b/arch/powerpc/platforms/82xx/Kconfig
>> @@ -2,6 +2,7 @@
>> menuconfig PPC_82xx
>> bool "82xx-based boards (PQ II)"
>> depends on PPC_BOOK3S_32
>> + select FSL_SOC
>>
>> if PPC_82xx
>>
>> @@ -9,7 +10,6 @@ config EP8248E
>> bool "Embedded Planet EP8248E (a.k.a. CWH-PPC-8248N-VE)"
>> select CPM2
>> select PPC_INDIRECT_PCI if PCI
>> - select FSL_SOC
>> select PHYLIB if NETDEVICES
>> select MDIO_BITBANG if PHYLIB
>> help
>> @@ -22,7 +22,6 @@ config MGCOGE
>> bool "Keymile MGCOGE"
>> select CPM2
>> select PPC_INDIRECT_PCI if PCI
>> - select FSL_SOC
>> help
>> This enables support for the Keymile MGCOGE board.
>>
>> --
>> 2.41.0
next prev parent reply other threads:[~2023-09-15 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 15:23 [PATCH] powerpc/82xx: Select FSL_SOC Christophe Leroy
2023-09-14 19:30 ` Randy Dunlap
2023-09-15 0:43 ` Michael Ellerman
2023-09-15 5:05 ` Christophe Leroy [this message]
2023-09-15 7:25 ` Michael Ellerman
2023-09-21 9:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c481fa91-0cfb-1c19-2da7-cf768bc56aea@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).