From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A8CC433E0 for ; Mon, 29 Jun 2020 08:34:35 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 347182336E for ; Mon, 29 Jun 2020 08:34:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 347182336E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49wLPz6s5bzDqQx for ; Mon, 29 Jun 2020 18:34:31 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=anshuman.khandual@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 49wLN74ZyvzDqN3 for ; Mon, 29 Jun 2020 18:32:53 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 77D68D6E; Mon, 29 Jun 2020 01:32:52 -0700 (PDT) Received: from [10.163.83.176] (unknown [10.163.83.176]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94C2D3F71E; Mon, 29 Jun 2020 01:32:41 -0700 (PDT) Subject: Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests To: Alexander Gordeev , Gerald Schaefer References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> <20200624110539.GC24934@oc3871087118.ibm.com> <20200624134808.0c460862@thinkpad> <20200624144015.GD24934@oc3871087118.ibm.com> From: Anshuman Khandual Message-ID: Date: Mon, 29 Jun 2020 14:02:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200624144015.GD24934@oc3871087118.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, Heiko Carstens , linux-mm@kvack.org, Paul Mackerras , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Jonathan Corbet , x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , ziy@nvidia.com, Catalin Marinas , linux-snps-arc@lists.infradead.org, Vasily Gorbik , Borislav Petkov , Paul Walmsley , "Kirill A . Shutemov" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, christophe.leroy@c-s.fr, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 06/24/2020 08:10 PM, Alexander Gordeev wrote: > On Wed, Jun 24, 2020 at 01:48:08PM +0200, Gerald Schaefer wrote: >> On Wed, 24 Jun 2020 13:05:39 +0200 >> Alexander Gordeev wrote: >> >>> On Wed, Jun 24, 2020 at 08:43:10AM +0530, Anshuman Khandual wrote: >>> >>> [...] >>> >>>> Hello Gerald/Christophe/Vineet, >>>> >>>> It would be really great if you could give this series a quick test >>>> on s390/ppc/arc platforms respectively. Thank you. >>> >>> That worked for me with the default and debug s390 configurations. >>> Would you like to try with some particular options or combinations >>> of the options? >> >> It will be enabled automatically on all archs that set >> ARCH_HAS_DEBUG_VM_PGTABLE, which we do for s390 unconditionally. >> Also, DEBUG_VM has to be set, which we have only in the debug config. >> So only the s390 debug config will have it enabled, you can check >> dmesg for "debug_vm_pgtable" to see when / where it was run, and if it >> triggered any warnings. > > Yes, that is what I did ;) > > I should have been more clear. I wonder whether Anshuman has in > mind other options which possibly makes sense to set or unset > and check how it goes with non-standard configurations. After enabling CONFIG_DEBUG_VM either explicitly or via DEBUG_VM, ideally any memory config combination on s390 which can change platform page table helpers (validated with CONFIG_DEBUG_VM) should also get tested. Recently, there was a kernel crash on ppc64 [1] and a build failure on ppc32 [2] for some particular configs. Hence it will be great if you could run this test on multiple s390 configurations. [1] 787d563b8642f35c5 ("mm/debug_vm_pgtable: fix kernel crash by checking for THP support") [2] 9449c9cb420b249eb ("mm/debug_vm_pgtable: fix build failure with powerpc 8xx") - Anshuman