From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1AEAC55165 for ; Thu, 30 Jul 2026 13:08:31 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4h9qJZ1Wqwz2yDs; Thu, 30 Jul 2026 23:08:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785416910; cv=none; b=aXWENTWGnP5sOvr39afNiuLsQRMmM1mbRTd8uGXFq1p168JFd4dNGrfIempk4Dd6YO4xY3aTRdwcGN7T8yGG14UZzVv3rcOctaIAxmcGSEBvdkoYhFHf58oZKnDw6Zhj/q4FVgGSzD1GnsOizeNR/UF3yjSC3Z7qb9IMnMnrmGg+uIhCmy/bloVndh3L2hDMUT8e7s+c9cSbQMq/5DGuqrt50QChfAy5v48ujipW77LKyMKX8Fs9zfP6CrUe/Dxl3LDvh++5pcd4sSKw/7zTlYr9jsz5mFo0A9dRPLFzuYuQ6pDo+Qw9GK3FDjCV3ZhM/icZ4nb5qcPsEKiVsYQK9Q== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785416910; c=relaxed/relaxed; bh=u8zch5DmNk58Rw/ACUH+ptO4cOhIAPQGkh8Kp7jvTDo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f10sLX86a4rTakem3Nf9kC2hnszZ9rrEASZ+9DXslwvhMWTqFkr6GK5SJ1063cqlp9wzuSfHr0udxRiJWbHc9sb69PgUucb8s5qQgFaMfFZtuET24d8tJ9CpgxX+1nBg0/u8NIyossmAWeQEK1ipejXs75LLa4Q6VUq/YTprbSU5/oGaHGJOc7RHFsZoY86ZdQQhRdEMNJ7DmUSnTDfXPerTEvGCEYrxrKBNlJ/elThgprkkwF9K2dBbaKQcH1vcsR3an9iSYCrSr5vR7e+nFXC7DBIDmo908tj7dmYMVVEIzUDHESlDLVb1CO8Tv86Af3v1c/q1cFJrHBLVI3h+Kw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=RMYdfH8Q; dkim-atps=neutral; spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=hbathini@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=RMYdfH8Q; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=hbathini@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4h9qJY3gsVz2xRs for ; Thu, 30 Jul 2026 23:08:29 +1000 (AEST) Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UAHbo82708719; Thu, 30 Jul 2026 13:08:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=u8zch5 DmNk58Rw/ACUH+ptO4cOhIAPQGkh8Kp7jvTDo=; b=RMYdfH8QSeYqYi82xF8cZG 5OBajZhuJxfNMvRKj20CFsDogB/Y9WqxdftKsz8hySzMC4RhQ3L6rmwsgILzFhwN ULmSVuzD58zIiF8iAYvs0YF+xddbxi2r2sZWWWfpEve8MFs19F0Ox7J7fN3JcWCS u2e9li9ijemicVSbKhcDATcfhsS2WWI+IAeocr5xnu4MM03T2TtaE4bU+9xYudwm r5bf1QJ3vMzvilNmDU4Cv+O15lvm2megp0mNFgeZsDdH9lUTxUJPlm/nIMATgxni a1tO8leWxDXZ+Z6bI6jD3nTC5TwOAfe3nMxzaCSSTFPmPjjavfTv2VD4PQnWy/VA == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fmuw7qu2r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Jul 2026 13:08:04 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66UCuOrx019237; Thu, 30 Jul 2026 13:08:03 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fn7uwbjjv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Jul 2026 13:08:03 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66UD7x1S16712054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Jul 2026 13:07:59 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6AA8D2004B; Thu, 30 Jul 2026 13:07:59 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D470820043; Thu, 30 Jul 2026 13:07:55 +0000 (GMT) Received: from [9.124.210.70] (unknown [9.124.210.70]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 30 Jul 2026 13:07:55 +0000 (GMT) Message-ID: Date: Thu, 30 Jul 2026 18:37:54 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] powerpc64/bpf: Fix build break for arch_bpf_timed_may_goto To: Saket Kumar Bhaskar , bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, chleroy@kernel.org, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com References: Content-Language: en-US From: Hari Bathini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: aqzt8hE_M2rQIWFLqgp3b0dvEuElntKB X-Proofpoint-ORIG-GUID: egI5O4Y6d7wnw4oBHdjcVH2G3QsxkYqg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA5NiBTYWx0ZWRfX6O1sHYUFN3ao QT63XzF5DVr4QyDKaFYJ03gVSN0wLS3Fu+i5kjSgsayiHsGYG+4fkZygqxzprjrgPlfoL5IGvf3 /SLsBxrdnx0U8vo6h4ww0dFuAaDtbB35fl8u+4AKmm9+VQR8yu5yUH+YuIKBt0yZ4XTwcE2iBRE xbUEV3Cl/ZUoaXvVQXp7aYHQqvbW+b+5co+ccogtqmzygeS8MkxTsCXYaOJt17284dnxB27gZBh wgGDmbbHlvrn7Z1DQmDAn6Hr357bEFEQs5j1tM37REvRCJ5inrLs7/5SxZU8P7bPYddSi2NpSX1 5HNAE4sW6ZVjDdChHu2DhbpBXIQbzIkccXlZD3OhTTZh/6h3Q6n7ayUy5sBBSi+uNj5eXw3Lk2f POagM0Tfbne8TVq3gs/T/Y5eKpLOhJ1ZsHiNTrJIIGC2LKS0sF9t2ZraSfrr57uQvlSVwf9GE5s j0e3radeDbKzfKBYQqQ== X-Authority-Analysis: v=2.4 cv=SKFykuvH c=1 sm=1 tr=0 ts=6a6b4cb5 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=VwQbUJbxAAAA:8 a=rbBgSRKb6kQpm1DpxiIA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA5NiBTYWx0ZWRfX2YpFvWcSETzj 9Q4Zti2fkP2w5DT1mGfwMjDto5RgMYVnO4VKvT2PByJrlXvKuTACFM2qjVqTsKLQTX70bPR9MSH mRDdMNLhq6cTmXfHQjVw3ar/Fkw7uPg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_03,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300096 On 30/07/26 11:16 am, Saket Kumar Bhaskar wrote: > With CONFIG_PPC_KERNEL_PCREL enabled, calling bpf_check_timed_may_goto() > using a bl instruction results in a link-time failure: > > arch/powerpc/net/bpf_timed_may_goto.o: in function `arch_bpf_timed_may_goto': > (.text+0x28): call to `bpf_check_timed_may_goto' lacks nop, can't restore toc > > Use CFUNC() macro instead of direct 'bl' to properly annotate the call > to bpf_check_timed_may_goto(). On PCREL builds, CFUNC() expands to > 'bl name@notoc', informing the linker that TOC restoration is not > needed, avoiding the "lacks nop, can't restore toc" linker error. > Reviewed-by: Hari Bathini > Fixes: b55b6b9ad76c ("powerpc64/bpf: Add powerpc64 JIT support for timed may_goto") > Signed-off-by: Saket Kumar Bhaskar > Reviewed-by: Christophe Leroy (CS GROUP) > --- > arch/powerpc/net/bpf_timed_may_goto.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/net/bpf_timed_may_goto.S b/arch/powerpc/net/bpf_timed_may_goto.S > index 6fd8b1c9f4ac..84ecf6fa7f5d 100644 > --- a/arch/powerpc/net/bpf_timed_may_goto.S > +++ b/arch/powerpc/net/bpf_timed_may_goto.S > @@ -36,7 +36,7 @@ SYM_FUNC_START(arch_bpf_timed_may_goto) > * BPF_REG_FP is r31; BPF_REG_AX is r12 (stack offset in bytes). > */ > add r3, r31, r12 > - bl bpf_check_timed_may_goto > + bl CFUNC(bpf_check_timed_may_goto) > > /* Put return value back into AX */ > mr r12, r3