* [PATCH] powerpc/pseries/pmem: fix a set but not used value
@ 2019-04-07 1:54 Qian Cai
2019-04-07 6:17 ` Mukesh Ojha
2019-04-21 14:19 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Qian Cai @ 2019-04-07 1:54 UTC (permalink / raw)
To: mpe, benh, paulus; +Cc: Qian Cai, linuxppc-dev, oohall, linux-kernel
The commit 4c5d87db4978 ("powerpc/pseries: PAPR persistent memory
support") set a local variable "count" in dlpar_hp_pmem() but never
use it.
arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem':
arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count'
set but not used [-Wunused-but-set-variable]
Signed-off-by: Qian Cai <cai@lca.pw>
---
arch/powerpc/platforms/pseries/pmem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/pmem.c b/arch/powerpc/platforms/pseries/pmem.c
index 27f0a915c8a9..f860a897a9e0 100644
--- a/arch/powerpc/platforms/pseries/pmem.c
+++ b/arch/powerpc/platforms/pseries/pmem.c
@@ -106,7 +106,7 @@ static ssize_t pmem_drc_remove_node(u32 drc_index)
int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)
{
- u32 count, drc_index;
+ u32 drc_index;
int rc;
/* slim chance, but we might get a hotplug event while booting */
@@ -123,7 +123,6 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)
return -EINVAL;
}
- count = hp_elog->_drc_u.drc_count;
drc_index = hp_elog->_drc_u.drc_index;
lock_device_hotplug();
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/pseries/pmem: fix a set but not used value
2019-04-07 1:54 [PATCH] powerpc/pseries/pmem: fix a set but not used value Qian Cai
@ 2019-04-07 6:17 ` Mukesh Ojha
2019-04-21 14:19 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-04-07 6:17 UTC (permalink / raw)
To: Qian Cai, mpe, benh, paulus; +Cc: linuxppc-dev, oohall, linux-kernel
On 4/7/2019 7:24 AM, Qian Cai wrote:
> The commit 4c5d87db4978 ("powerpc/pseries: PAPR persistent memory
> support") set a local variable "count" in dlpar_hp_pmem() but never
> use it.
>
> arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem':
> arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count'
> set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> arch/powerpc/platforms/pseries/pmem.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pseries/pmem.c b/arch/powerpc/platforms/pseries/pmem.c
> index 27f0a915c8a9..f860a897a9e0 100644
> --- a/arch/powerpc/platforms/pseries/pmem.c
> +++ b/arch/powerpc/platforms/pseries/pmem.c
> @@ -106,7 +106,7 @@ static ssize_t pmem_drc_remove_node(u32 drc_index)
>
> int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)
> {
> - u32 count, drc_index;
> + u32 drc_index;
> int rc;
>
> /* slim chance, but we might get a hotplug event while booting */
> @@ -123,7 +123,6 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)
> return -EINVAL;
> }
>
> - count = hp_elog->_drc_u.drc_count;
> drc_index = hp_elog->_drc_u.drc_index;
>
> lock_device_hotplug();
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: powerpc/pseries/pmem: fix a set but not used value
2019-04-07 1:54 [PATCH] powerpc/pseries/pmem: fix a set but not used value Qian Cai
2019-04-07 6:17 ` Mukesh Ojha
@ 2019-04-21 14:19 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-04-21 14:19 UTC (permalink / raw)
To: Qian Cai, benh, paulus; +Cc: linuxppc-dev, oohall, Qian Cai, linux-kernel
On Sun, 2019-04-07 at 01:54:47 UTC, Qian Cai wrote:
> The commit 4c5d87db4978 ("powerpc/pseries: PAPR persistent memory
> support") set a local variable "count" in dlpar_hp_pmem() but never
> use it.
>
> arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem':
> arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count'
> set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e663e1e06089773cdab03023563aead6
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-21 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-07 1:54 [PATCH] powerpc/pseries/pmem: fix a set but not used value Qian Cai
2019-04-07 6:17 ` Mukesh Ojha
2019-04-21 14:19 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).