From: Scott Wood <oss@buserror.net>
To: Darren Stevens <darren@stevens-zone.net>, linuxppc-dev@lists.ozlabs.org
Cc: chzigotzky@xenosoft.de
Subject: Re: [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED
Date: Fri, 08 May 2020 15:37:45 -0500 [thread overview]
Message-ID: <c4ca1e6aed1fcb73acda5d8a43954f05f890db6d.camel@buserror.net> (raw)
In-Reply-To: <20200507221550.6b02a290@Cyrus.lan>
On Thu, 2020-05-07 at 22:15 +0100, Darren Stevens wrote:
> The Cyrus board has its HDD LED connected to a GPIO pin. Add a device
> tree entry for this.
>
> Signed-off-By: Darren Stevens <darren@stevens-zone.net>
>
> ---
> arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f
> 100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> +++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> @@ -83,6 +83,16 @@
> gpios = <&gpio0 2 1>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + hdd {
> + label = "Disk Activity";
> + gpios = <&gpio0 5 0>;
> + linux,default-trigger =
> "disk-activity";
> + };
Documentation/devicetree/bindings/leds/common.yaml says that label is
deprecated, and to "use 'function' and 'color' properties instead".
Also, please CC devicetree@vger.kernel.org on these patches.
-Scott
prev parent reply other threads:[~2020-05-08 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:15 [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED Darren Stevens
2020-05-08 20:37 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ca1e6aed1fcb73acda5d8a43954f05f890db6d.camel@buserror.net \
--to=oss@buserror.net \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).