From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E49C38A2A for ; Fri, 8 May 2020 20:42:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 343F121775 for ; Fri, 8 May 2020 20:42:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 343F121775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=buserror.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Jj221rCzzDr96 for ; Sat, 9 May 2020 06:42:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=buserror.net (client-ip=165.227.176.147; helo=baldur.buserror.net; envelope-from=oss@buserror.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=buserror.net Received: from baldur.buserror.net (baldur.buserror.net [165.227.176.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49JhzD2zCfzDrFn for ; Sat, 9 May 2020 06:40:07 +1000 (AEST) Received: from [2601:449:8480:af0:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jX9kg-0000Ri-N0; Fri, 08 May 2020 15:37:52 -0500 Message-ID: From: Scott Wood To: Darren Stevens , linuxppc-dev@lists.ozlabs.org Date: Fri, 08 May 2020 15:37:45 -0500 In-Reply-To: <20200507221550.6b02a290@Cyrus.lan> References: <20200507221550.6b02a290@Cyrus.lan> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2601:449:8480:af0:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: darren@stevens-zone.net, linuxppc-dev@lists.ozlabs.org, chzigotzky@xenosoft.de X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chzigotzky@xenosoft.de Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 2020-05-07 at 22:15 +0100, Darren Stevens wrote: > The Cyrus board has its HDD LED connected to a GPIO pin. Add a device > tree entry for this. > > Signed-off-By: Darren Stevens > > --- > arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts > b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f > 100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts > +++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts > @@ -83,6 +83,16 @@ > gpios = <&gpio0 2 1>; > }; > > + leds { > + compatible = "gpio-leds"; > + > + hdd { > + label = "Disk Activity"; > + gpios = <&gpio0 5 0>; > + linux,default-trigger = > "disk-activity"; > + }; Documentation/devicetree/bindings/leds/common.yaml says that label is deprecated, and to "use 'function' and 'color' properties instead". Also, please CC devicetree@vger.kernel.org on these patches. -Scott