linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, xemul@parallels.com,
	linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
	benh@kernel.crashing.org, aneesh.kumar@linux.vnet.ibm.com,
	paulus@samba.org
Cc: criu@openvz.org
Subject: [PATCH 2/3] mm: clear_soft_dirty_pmd requires THP
Date: Fri, 16 Oct 2015 14:07:07 +0200	[thread overview]
Message-ID: <c56e0cee475c34bda846ffbf1cc0e541ccb6b9b4.1444995096.git.ldufour@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1444995096.git.ldufour@linux.vnet.ibm.com>
In-Reply-To: <cover.1444995096.git.ldufour@linux.vnet.ibm.com>

Don't build clear_soft_dirty_pmd() if the transparent huge pages are
not enabled.

Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
CC: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 fs/proc/task_mmu.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index c9454ee39b28..fa847a982a9f 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -762,7 +762,14 @@ static inline void clear_soft_dirty(struct vm_area_struct *vma,
 		set_pte_at(vma->vm_mm, addr, pte, ptent);
 	}
 }
+#else
+static inline void clear_soft_dirty(struct vm_area_struct *vma,
+		unsigned long addr, pte_t *pte)
+{
+}
+#endif
 
+#if defined(CONFIG_MEM_SOFT_DIRTY) && defined(CONFIG_TRANSPARENT_HUGEPAGE)
 static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
 		unsigned long addr, pmd_t *pmdp)
 {
@@ -776,14 +783,7 @@ static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
 
 	set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
 }
-
 #else
-
-static inline void clear_soft_dirty(struct vm_area_struct *vma,
-		unsigned long addr, pte_t *pte)
-{
-}
-
 static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
 		unsigned long addr, pmd_t *pmdp)
 {
-- 
1.9.1

  parent reply	other threads:[~2015-10-16 12:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 12:07 [PATCH 0/3] mm/powerpc: enabling memory soft dirty tracking Laurent Dufour
2015-10-16 12:07 ` [PATCH 1/3] mm: clearing pte in clear_soft_dirty() Laurent Dufour
2015-10-16 15:00   ` Benjamin Herrenschmidt
2015-10-17 12:12   ` Aneesh Kumar K.V
2015-10-16 12:07 ` Laurent Dufour [this message]
2015-10-17 12:14   ` [PATCH 2/3] mm: clear_soft_dirty_pmd requires THP Aneesh Kumar K.V
2015-10-16 12:07 ` [PATCH 3/3] powerpc/mm: Add page soft dirty tracking Laurent Dufour
2015-10-17 12:19   ` Aneesh Kumar K.V
2015-10-17 13:24     ` Benjamin Herrenschmidt
2015-10-16 21:11 ` [PATCH 0/3] mm/powerpc: enabling memory " Andrew Morton
2015-10-17  2:15   ` Benjamin Herrenschmidt
2015-10-17 12:07   ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c56e0cee475c34bda846ffbf1cc0e541ccb6b9b4.1444995096.git.ldufour@linux.vnet.ibm.com \
    --to=ldufour@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=criu@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).