linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Paul Mackerras <paulus@ozlabs.org>,
	David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE
Date: Tue, 12 Mar 2019 15:10:58 +0100	[thread overview]
Message-ID: <c574ab63-32db-5404-f201-ab9f9becc311@kaod.org> (raw)
In-Reply-To: <20190225045931.GB20501@blackberry>

On 2/25/19 5:59 AM, Paul Mackerras wrote:
> On Mon, Feb 25, 2019 at 11:35:27AM +1100, David Gibson wrote:
>> On Fri, Feb 22, 2019 at 12:28:27PM +0100, Cédric Le Goater wrote:
>>> +	xc->xive = xive;
>>> +	xc->vcpu = vcpu;
>>> +	xc->server_num = cpu;
>>> +	xc->vp_id = xive->vp_base + cpu;
>>
>> Hrm.  This ties the internal VP id to the userspace chosen server
>> number, which isn't ideal.  It puts a constraint on those server
>> numbers that you wouldn't otherwise have.
> 
> We should probably do the same as the xics-on-xive code, which is to
> put the server number through kvmppc_pack_vcpu_id(), which is a
> folding function that maps the QEMU vcpu id (which is the server
> number) down to the range 0..KVM_MAX_VCPUS-1, and works for the
> allocation patterns used in the various vSMT modes.

yes. I will see how it goes.

Thanks,

C.

  reply	other threads:[~2019-03-12 14:28 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 11:28 [PATCH v2 00/16] KVM: PPC: Book3S HV: add XIVE native exploitation mode Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 01/16] powerpc/xive: add OPAL extensions for the XIVE native exploitation support Cédric Le Goater
2019-02-24 23:42   ` David Gibson
2019-02-25  3:50   ` Michael Ellerman
2019-02-25 10:11     ` Cédric Le Goater
2019-02-26  4:21       ` David Gibson
2019-03-12 18:25         ` Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 02/16] KVM: PPC: Book3S HV: add a new KVM device for the XIVE native exploitation mode Cédric Le Goater
2019-02-25  0:08   ` David Gibson
2019-03-12 11:14     ` Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE Cédric Le Goater
2019-02-25  0:35   ` David Gibson
2019-02-25  4:59     ` Paul Mackerras
2019-03-12 14:10       ` Cédric Le Goater [this message]
2019-03-12 14:03     ` Cédric Le Goater
2019-03-13  4:05       ` David Gibson
2019-02-25  4:35   ` Paul Mackerras
2019-03-13  8:34     ` Cédric Le Goater
2019-03-14  2:29       ` David Gibson
2019-02-22 11:28 ` [PATCH v2 04/16] KVM: PPC: Book3S HV: XIVE: add a control to initialize a source Cédric Le Goater
2019-02-25  2:10   ` David Gibson
2019-02-26  4:25     ` Paul Mackerras
2019-02-26 23:20       ` David Gibson
2019-03-12 15:19     ` Cédric Le Goater
2019-03-14  2:15       ` David Gibson
2019-02-25  5:30   ` Paul Mackerras
2019-02-22 11:28 ` [PATCH v2 05/16] KVM: PPC: Book3S HV: XIVE: add a control to configure " Cédric Le Goater
2019-02-25  2:21   ` David Gibson
2019-02-22 11:28 ` [PATCH v2 06/16] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration Cédric Le Goater
2019-02-25  2:39   ` David Gibson
2019-03-12 17:00     ` Cédric Le Goater
2019-03-13  4:03       ` David Gibson
2019-03-13  8:46         ` Cédric Le Goater
2019-03-14  3:29           ` David Gibson
2019-02-26  5:24   ` Paul Mackerras
2019-03-13  9:40     ` Cédric Le Goater
2019-03-14  2:32       ` David Gibson
2019-03-14  7:11         ` Cédric Le Goater
2019-03-15  0:29           ` David Gibson
2019-02-22 11:28 ` [PATCH v2 07/16] KVM: PPC: Book3S HV: XIVE: add a global reset control Cédric Le Goater
2019-02-25  2:43   ` David Gibson
2019-02-22 11:28 ` [PATCH v2 08/16] KVM: PPC: Book3S HV: XIVE: add a control to sync the sources Cédric Le Goater
2019-02-25  2:45   ` David Gibson
2019-02-22 11:28 ` [PATCH v2 09/16] KVM: PPC: Book3S HV: XIVE: add a control to dirty the XIVE EQ pages Cédric Le Goater
2019-02-25  2:53   ` David Gibson
2019-03-13 11:48     ` Cédric Le Goater
2019-03-14  2:33       ` David Gibson
2019-02-22 11:28 ` [PATCH v2 10/16] KVM: PPC: Book3S HV: XIVE: add get/set accessors for the VP XIVE state Cédric Le Goater
2019-02-25  3:31   ` David Gibson
2019-03-13 13:19     ` Cédric Le Goater
2019-03-14  3:09       ` David Gibson
2019-03-14  7:08         ` Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 11/16] KVM: introduce a 'mmap' method for KVM devices Cédric Le Goater
2019-02-25  3:33   ` David Gibson
2019-02-25 10:57     ` Cédric Le Goater
2019-02-26 12:52       ` Paolo Bonzini
2019-02-26 23:22         ` David Gibson
2019-02-22 11:28 ` [PATCH v2 12/16] KVM: PPC: Book3S HV: XIVE: add a TIMA mapping Cédric Le Goater
2019-02-25  3:42   ` David Gibson
2019-02-22 11:28 ` [PATCH v2 13/16] KVM: PPC: Book3S HV: XIVE: add a mapping for the source ESB pages Cédric Le Goater
2019-02-25  3:47   ` David Gibson
2019-02-22 11:28 ` [PATCH v2 14/16] KVM: PPC: Book3S HV: XIVE: add passthrough support Cédric Le Goater
2019-02-25  4:13   ` David Gibson
2019-02-22 11:28 ` [PATCH v2 15/16] KVM: introduce a KVM_DESTROY_DEVICE ioctl Cédric Le Goater
2019-02-25  4:15   ` David Gibson
2019-03-13  8:02     ` Cédric Le Goater
2019-03-15 17:57       ` Paolo Bonzini
2019-02-22 11:28 ` [PATCH v2 16/16] KVM: PPC: Book3S HV: XIVE: clear the vCPU interrupt presenters Cédric Le Goater
2019-02-25  4:18   ` David Gibson
2019-03-13  8:17     ` Cédric Le Goater
2019-03-14  2:26       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c574ab63-32db-5404-f201-ab9f9becc311@kaod.org \
    --to=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).