* [PATCH] platforms: 52xx: Remove space after '(' and before ')' [not found] <tencent_ADAD5C6DD5F9824047356B25D53801910A06@qq.com> @ 2023-07-18 9:02 ` hanyu001 2023-07-18 14:08 ` Andy Shevchenko 0 siblings, 1 reply; 2+ messages in thread From: hanyu001 @ 2023-07-18 9:02 UTC (permalink / raw) To: agust, mpe, npiggin, christophe.leroy, andriy.shevchenko, bhelgaas, kw, mika.westerberg Cc: linuxppc-dev, linux-kernel The patch fixes the following errors detected by checkpatch: platforms/52xx/mpc52xx_pci.c:346:ERROR: space prohibited after that open parenthesis '(' platforms/52xx/mpc52xx_pci.c:347:ERROR: space prohibited after that open parenthesis '(' platforms/52xx/mpc52xx_pci.c:348:ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Yu Han <hanyu001@208suo.com> --- arch/powerpc/platforms/52xx/mpc52xx_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pci.c b/arch/powerpc/platforms/52xx/mpc52xx_pci.c index 0ca4401ba781..452723f8ba53 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_pci.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_pci.c @@ -343,9 +343,9 @@ mpc52xx_pci_fixup_resources(struct pci_dev *dev) /* The PCI Host bridge of MPC52xx has a prefetch memory resource fixed to 1Gb. Doesn't fit in the resource system so we remove it */ - if ( (dev->vendor == PCI_VENDOR_ID_MOTOROLA) && - ( dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200 - || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B) ) { + if ((dev->vendor == PCI_VENDOR_ID_MOTOROLA) && + (dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200 + || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B)) { struct resource *res = &dev->resource[1]; res->start = res->end = res->flags = 0; } ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platforms: 52xx: Remove space after '(' and before ')' 2023-07-18 9:02 ` [PATCH] platforms: 52xx: Remove space after '(' and before ')' hanyu001 @ 2023-07-18 14:08 ` Andy Shevchenko 0 siblings, 0 replies; 2+ messages in thread From: Andy Shevchenko @ 2023-07-18 14:08 UTC (permalink / raw) To: hanyu001 Cc: kw, linuxppc-dev, linux-kernel, npiggin, bhelgaas, agust, mika.westerberg On Tue, Jul 18, 2023 at 05:02:39PM +0800, hanyu001@208suo.com wrote: > The patch fixes the following errors detected by checkpatch: > > platforms/52xx/mpc52xx_pci.c:346:ERROR: space prohibited after that open > parenthesis '(' > platforms/52xx/mpc52xx_pci.c:347:ERROR: space prohibited after that open > parenthesis '(' > platforms/52xx/mpc52xx_pci.c:348:ERROR: space prohibited before that close > parenthesis ')' First of all, your patch is mangled and may not be applied. Second, we usually don't do this kind of patches at all. Besides the fact that we don't run checkpatch on the files which are already in upstream (esp. so-o-o old as this one). NAK. ... > + if ((dev->vendor == PCI_VENDOR_ID_MOTOROLA) && > + (dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200 > + || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B)) { Also note, you can move this to use pci_match_id(). That kind of patch might be approved. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-18 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_ADAD5C6DD5F9824047356B25D53801910A06@qq.com>
2023-07-18 9:02 ` [PATCH] platforms: 52xx: Remove space after '(' and before ')' hanyu001
2023-07-18 14:08 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).