linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v2]: Fix e500 v2 core reboot bug
Date: Mon, 4 Jun 2007 12:37:05 +0200	[thread overview]
Message-ID: <c6f611e5eaff31a78979752ecd49e5f2@kernel.crashing.org> (raw)
In-Reply-To: <1180947682.10048.23.camel@localhost.localdomain>

>>>> guts@e00000 {

>> If "guts" is some kind of official name (i.e., the
>> block is called that in the user manual), it looks
>> okay to me.
> No! It is not official name. It is provided by Kumar. It should be a
> abbr. standing for "Global Utilities" as far as my understand.

So the official name is "global utilities block"?

>> Otherwise, please change; in fact, just
>> change the name anyway (not the compatible), to
>> "shared-soc-regs" or something like that;
> I can not agree with you. "shared-soc-regs" can not describe the
> property of this kind of register.
> The official description for this set of registers:
>
> "The global utilities block controls power management, I/O device
> enabling, power-on-reset (POR) configuration monitoring, 
> general-purpose
> I/O signal configuration, alternate function selection for multiplexed
> signals, and clock control.
>
> gub (Kumar's style?): global utilities block
> or
> global-uti-regs or global-uti (Segher's style?)
> may be better.

"global-utilities" sounds fine to me, although the
name doesn't actually say anything.  Let's avoid
abbr.s unless they are very widely known.

>>  "name"
>> should be descriptive (but terse).
>>
> Agree!
> But we should reach a agreement!

Nah, you guys just need to come up with a good name :-)
I would just call it "control" perhaps ;-)

It doesn't matter much, but "name" should be human-
readable, human-understandable, and short.  A made-up
acronym doesn't work (although I like "guts", sure --
put it in your "compatible" property ;-) )


Segher

  reply	other threads:[~2007-06-04 10:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29  2:36 [PATCH v2]: Fix e500 v2 core reboot bug Zang Roy-r61911
2007-05-29 17:38 ` Andy Fleming
2007-05-29 19:29 ` Kumar Gala
2007-05-30  2:34   ` Zang Roy-r61911
2007-05-30  2:40     ` Kumar Gala
2007-05-30  5:46       ` Zang Roy-r61911
2007-05-30 12:25         ` Kumar Gala
2007-05-30 13:49           ` Kumar Gala
2007-05-30 15:21             ` Segher Boessenkool
2007-05-31  5:32               ` Zang Roy-r61911
2007-05-31  5:52               ` Benjamin Herrenschmidt
2007-05-31  3:40             ` Zang Roy-r61911
2007-06-04  8:28             ` Zang Roy-r61911
2007-06-04  8:41               ` Segher Boessenkool
2007-06-04  9:01                 ` Zang Roy-r61911
2007-06-04 10:37                   ` Segher Boessenkool [this message]
2007-06-05  2:15                     ` Zang Roy-r61911
2007-05-31  2:38           ` Zang Roy-r61911
2007-06-12  9:08 ` [PATCH v3]: " Zang Roy-r61911
2007-06-12 16:18   ` Timur Tabi
2007-06-13  4:44   ` Segher Boessenkool
2007-06-13  5:45     ` Zang Roy-r61911
2007-06-13  6:24       ` Zang Roy-r61911
2007-06-13  6:43         ` Zang Roy-r61911
2007-06-13  6:57           ` Segher Boessenkool
2007-06-13  7:04             ` Segher Boessenkool
2007-06-13  6:16     ` Zang Roy-r61911
2007-06-13  6:28       ` Segher Boessenkool
2007-06-13  6:31         ` Zang Roy-r61911

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6f611e5eaff31a78979752ecd49e5f2@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=tie-fei.zang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).