From: Sohil Mehta <sohil.mehta@intel.com>
To: <ira.weiny@intel.com>, <linux-api@vger.kernel.org>
Cc: Florian Weimer <fweimer@redhat.com>,
x86@kernel.org, clemensb@chromium.org, jkummerow@chromium.org,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, ahaas@chromium.org,
gdeepti@chromium.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, manoskouk@chromium.org,
thibaudm@chromium.org
Subject: Re: [RFC PATCH 4/6] pkeys: Lift pkey hardware check for pkey_alloc()
Date: Thu, 16 Jun 2022 12:31:02 -0700 [thread overview]
Message-ID: <c88e73b2-69cf-4f74-2776-3644f48edfe5@intel.com> (raw)
In-Reply-To: <20220610233533.3649584-5-ira.weiny@intel.com>
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index ba5592655ee3..56d35de33725 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -773,6 +773,9 @@ SYSCALL_DEFINE2(pkey_alloc, unsigned long, flags, unsigned long, init_val)
> int pkey;
> int ret;
>
> + if (!arch_pkeys_enabled())
> + return -ENOSPC;
> +
See comments in patch 3/6. Since we are modifying (fixing) old behavior,
should we just return ENOSYS to make this consistent?
Sohil
> /* No flags supported yet. */
> if (flags)
> return -EINVAL;
next prev parent reply other threads:[~2022-06-16 19:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 23:35 [RFC PATCH 0/6] User pkey minor bug fixes ira.weiny
2022-06-10 23:35 ` [RFC PATCH 1/6] testing/pkeys: Add command line options ira.weiny
2022-06-13 22:31 ` Sohil Mehta
2022-06-13 23:41 ` Ira Weiny
2022-06-10 23:35 ` [RFC PATCH 2/6] testing/pkeys: Don't use uninitialized variable ira.weiny
2022-06-13 22:48 ` Sohil Mehta
2022-06-13 23:59 ` Ira Weiny
2022-06-10 23:35 ` [RFC PATCH 3/6] testing/pkeys: Add additional test for pkey_alloc() ira.weiny
2022-06-16 19:25 ` Sohil Mehta
2022-06-16 20:24 ` Dave Hansen
2022-06-10 23:35 ` [RFC PATCH 4/6] pkeys: Lift pkey hardware check " ira.weiny
2022-06-16 19:31 ` Sohil Mehta [this message]
2022-06-10 23:35 ` [RFC PATCH 5/6] pkeys: Up level pkey_free() checks ira.weiny
2022-06-13 9:14 ` Christophe Leroy
2022-06-10 23:35 ` [RFC PATCH 6/6] pkeys: Change mm_pkey_free() to void ira.weiny
2022-06-13 9:17 ` Christophe Leroy
2022-06-13 16:16 ` Ira Weiny
2022-06-13 22:05 ` [RFC PATCH 0/6] User pkey minor bug fixes Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c88e73b2-69cf-4f74-2776-3644f48edfe5@intel.com \
--to=sohil.mehta@intel.com \
--cc=ahaas@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=clemensb@chromium.org \
--cc=dave.hansen@linux.intel.com \
--cc=fweimer@redhat.com \
--cc=gdeepti@chromium.org \
--cc=ira.weiny@intel.com \
--cc=jkummerow@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manoskouk@chromium.org \
--cc=thibaudm@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).