From: Sandipan Das <sandipan@linux.ibm.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: ravi.bangoria@linux.ibm.com, ananth@linux.ibm.com,
jniethe5@gmail.com, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, dja@axtens.net
Subject: Re: [PATCH v3 1/2] powerpc: sstep: Fix load-store and update emulation
Date: Thu, 4 Feb 2021 13:29:08 +0530 [thread overview]
Message-ID: <c946a40c-63d5-868f-8e75-5e84a931e437@linux.ibm.com> (raw)
In-Reply-To: <20210204073954.GH210@DESKTOP-TDPLP67.localdomain>
On 04/02/21 1:09 pm, Naveen N. Rao wrote:
> [...]
>
> I'm afraid there is one more thing. scripts/checkpatch.pl reports:
>
> WARNING: 'an userspace' may be misspelled - perhaps 'a userspace'?
> #52:
> While an userspace program having an instruction word like
> ^^^^^^^^^^^^
>
> ERROR: switch and case should be at the same indent
> #96: FILE: arch/powerpc/lib/sstep.c:3021:
> + switch (GETTYPE(op->type)) {
> + case LOAD:
> [...]
> + case STORE:
> + case LOAD_FP:
> + case STORE_FP:
>
>
Yikes! Thanks for pointing that out. Sending v4.
- Sandipan
prev parent reply other threads:[~2021-02-04 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 7:14 [PATCH v3 1/2] powerpc: sstep: Fix load-store and update emulation Sandipan Das
2021-02-04 7:14 ` [PATCH v3 2/2] powerpc: sstep: Fix darn emulation Sandipan Das
2021-02-04 7:23 ` [PATCH v3 1/2] powerpc: sstep: Fix load-store and update emulation Sandipan Das
2021-02-04 7:39 ` Naveen N. Rao
2021-02-04 7:59 ` Sandipan Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c946a40c-63d5-868f-8e75-5e84a931e437@linux.ibm.com \
--to=sandipan@linux.ibm.com \
--cc=ananth@linux.ibm.com \
--cc=dja@axtens.net \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).