* BRG setting error
@ 2005-09-29 9:06 Borsodi Petr
2005-09-29 12:48 ` Dan Malek
0 siblings, 1 reply; 2+ messages in thread
From: Borsodi Petr @ 2005-09-29 9:06 UTC (permalink / raw)
To: linuxppc-embedded
Hi all,
I found an error in Baud Rate Generator setting for MPC82XX processors.
The CD field of im_brgcx (x =3D 1..8) register is set to wrong value. =
This
field must be set to divisor lowered by 1, in according with doc for
MPC8272 or similar. I have searched 2.4.31 and 2.6.12 kernels.
Please check these functions:
linux-2.4.31\arch\ppc\boot\simple\m8260_tty.c: serial_init
linux-2.4.31\arch\ppc\cpm2_io\commproc.c: cpm2_setbrg
linux-2.4.31\arch\ppc\cpm2_io\commproc.c: cpm2_fastbrg
linux-2.6.12\arch\ppc\boot\simple\m8260_tty.c: serial_init
linux-2.6.12\arch\ppc\syslib\cpm2_common.c: cpm2_setbrg
linux-2.6.12\arch\ppc\syslib\cpm2_common.c: cpm2_fastbrg
This problem is shown only for small divider - for normal UART baud
rates the deviation is slight.
(I think that better approach is round the divisor to nearest value).
Best regards
Petr Borsodi, SW Development
S.ICZ a.s., J.S. Baara 40, 370 01 Ceske Budejovice, Czech Republic
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: BRG setting error
2005-09-29 9:06 BRG setting error Borsodi Petr
@ 2005-09-29 12:48 ` Dan Malek
0 siblings, 0 replies; 2+ messages in thread
From: Dan Malek @ 2005-09-29 12:48 UTC (permalink / raw)
To: Borsodi Petr; +Cc: linuxppc-embedded
On Sep 29, 2005, at 5:06 AM, Borsodi Petr wrote:
> I found an error in Baud Rate Generator setting for MPC82XX processors.
How about a patch we can apply? Declaring a bug and hoping
someone else will fix it isn't likely to happen :-)
Thanks.
-- Dan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-09-29 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-29 9:06 BRG setting error Borsodi Petr
2005-09-29 12:48 ` Dan Malek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).