[PATCH] selftest/lkdtm: Don't pollute 'git status'

linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] selftest/lkdtm: Don't pollute 'git status'
@ 2020-02-06  8:11 Christophe Leroy
  2020-02-20 14:58 ` Christophe Leroy
  2020-02-20 23:18 ` Kees Cook
  0 siblings, 2 replies; 4+ messages in thread
From: Christophe Leroy @ 2020-02-06  8:11 UTC (permalink / raw)
  To: Kees Cook, Shuah Khan; +Cc: linux-mm, linuxppc-dev, linux-kernel

Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
added generation of lkdtm test scripts.

Ignore those generated scripts when performing 'git status'

Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 .gitignore | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.gitignore b/.gitignore
index b849a72d69d5..bb05dce58f8e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -100,6 +100,10 @@ modules.order
 /include/ksym/
 /arch/*/include/generated/
 
+# Generated lkdtm tests
+/tools/testing/selftests/lkdtm/*.sh
+!/tools/testing/selftests/lkdtm/run.sh
+
 # stgit generated dirs
 patches-*
 
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftest/lkdtm: Don't pollute 'git status'
  2020-02-06  8:11 [PATCH] selftest/lkdtm: Don't pollute 'git status' Christophe Leroy
@ 2020-02-20 14:58 ` Christophe Leroy
  2020-02-20 15:49   ` Shuah Khan
  2020-02-20 23:18 ` Kees Cook
  1 sibling, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2020-02-20 14:58 UTC (permalink / raw)
  To: Kees Cook, Shuah Khan; +Cc: linux-mm, linuxppc-dev, linux-kernel

ping

On 02/06/2020 08:11 AM, Christophe Leroy wrote:
> Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> added generation of lkdtm test scripts.
> 
> Ignore those generated scripts when performing 'git status'
> 
> Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Without this, 'git status' now reports the following crap and real 
problems are drowned in the middle, that's annoying.

On branch saf3000-5.6
Untracked files:
   (use "git add <file>..." to include in what will be committed)
	tools/testing/selftests/lkdtm/ACCESS_NULL.sh
	tools/testing/selftests/lkdtm/ACCESS_USERSPACE.sh
	tools/testing/selftests/lkdtm/ATOMIC_TIMING.sh
	tools/testing/selftests/lkdtm/BUG.sh
	tools/testing/selftests/lkdtm/CFI_FORWARD_PROTO.sh
	tools/testing/selftests/lkdtm/CORRUPT_LIST_ADD.sh
	tools/testing/selftests/lkdtm/CORRUPT_LIST_DEL.sh
	tools/testing/selftests/lkdtm/CORRUPT_STACK.sh
	tools/testing/selftests/lkdtm/CORRUPT_STACK_STRONG.sh
	tools/testing/selftests/lkdtm/CORRUPT_USER_DS.sh
	tools/testing/selftests/lkdtm/DOUBLE_FAULT.sh
	tools/testing/selftests/lkdtm/EXCEPTION.sh
	tools/testing/selftests/lkdtm/EXEC_DATA.sh
	tools/testing/selftests/lkdtm/EXEC_KMALLOC.sh
	tools/testing/selftests/lkdtm/EXEC_NULL.sh
	tools/testing/selftests/lkdtm/EXEC_RODATA.sh
	tools/testing/selftests/lkdtm/EXEC_STACK.sh
	tools/testing/selftests/lkdtm/EXEC_USERSPACE.sh
	tools/testing/selftests/lkdtm/EXEC_VMALLOC.sh
	tools/testing/selftests/lkdtm/EXHAUST_STACK.sh
	tools/testing/selftests/lkdtm/HARDLOCKUP.sh
	tools/testing/selftests/lkdtm/HUNG_TASK.sh
	tools/testing/selftests/lkdtm/LOOP.sh
	tools/testing/selftests/lkdtm/OVERWRITE_ALLOCATION.sh
	tools/testing/selftests/lkdtm/PANIC.sh
	tools/testing/selftests/lkdtm/READ_AFTER_FREE.sh
	tools/testing/selftests/lkdtm/READ_BUDDY_AFTER_FREE.sh
	tools/testing/selftests/lkdtm/REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh
	tools/testing/selftests/lkdtm/REFCOUNT_ADD_NOT_ZERO_SATURATED.sh
	tools/testing/selftests/lkdtm/REFCOUNT_ADD_OVERFLOW.sh
	tools/testing/selftests/lkdtm/REFCOUNT_ADD_SATURATED.sh
	tools/testing/selftests/lkdtm/REFCOUNT_ADD_ZERO.sh
	tools/testing/selftests/lkdtm/REFCOUNT_DEC_AND_TEST_NEGATIVE.sh
	tools/testing/selftests/lkdtm/REFCOUNT_DEC_AND_TEST_SATURATED.sh
	tools/testing/selftests/lkdtm/REFCOUNT_DEC_NEGATIVE.sh
	tools/testing/selftests/lkdtm/REFCOUNT_DEC_SATURATED.sh
	tools/testing/selftests/lkdtm/REFCOUNT_DEC_ZERO.sh
	tools/testing/selftests/lkdtm/REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh
	tools/testing/selftests/lkdtm/REFCOUNT_INC_NOT_ZERO_SATURATED.sh
	tools/testing/selftests/lkdtm/REFCOUNT_INC_OVERFLOW.sh
	tools/testing/selftests/lkdtm/REFCOUNT_INC_SATURATED.sh
	tools/testing/selftests/lkdtm/REFCOUNT_INC_ZERO.sh
	tools/testing/selftests/lkdtm/REFCOUNT_SUB_AND_TEST_NEGATIVE.sh
	tools/testing/selftests/lkdtm/REFCOUNT_SUB_AND_TEST_SATURATED.sh
	tools/testing/selftests/lkdtm/REFCOUNT_TIMING.sh
	tools/testing/selftests/lkdtm/SLAB_FREE_CROSS.sh
	tools/testing/selftests/lkdtm/SLAB_FREE_DOUBLE.sh
	tools/testing/selftests/lkdtm/SLAB_FREE_PAGE.sh
	tools/testing/selftests/lkdtm/SOFTLOCKUP.sh
	tools/testing/selftests/lkdtm/SPINLOCKUP.sh
	tools/testing/selftests/lkdtm/STACKLEAK_ERASING.sh
	tools/testing/selftests/lkdtm/STACK_GUARD_PAGE_LEADING.sh
	tools/testing/selftests/lkdtm/STACK_GUARD_PAGE_TRAILING.sh
	tools/testing/selftests/lkdtm/UNALIGNED_LOAD_STORE_WRITE.sh
	tools/testing/selftests/lkdtm/UNSET_SMEP.sh
	tools/testing/selftests/lkdtm/USERCOPY_HEAP_SIZE_FROM.sh
	tools/testing/selftests/lkdtm/USERCOPY_HEAP_SIZE_TO.sh
	tools/testing/selftests/lkdtm/USERCOPY_HEAP_WHITELIST_FROM.sh
	tools/testing/selftests/lkdtm/USERCOPY_HEAP_WHITELIST_TO.sh
	tools/testing/selftests/lkdtm/USERCOPY_KERNEL.sh
	tools/testing/selftests/lkdtm/USERCOPY_KERNEL_DS.sh
	tools/testing/selftests/lkdtm/USERCOPY_STACK_BEYOND.sh
	tools/testing/selftests/lkdtm/USERCOPY_STACK_FRAME_FROM.sh
	tools/testing/selftests/lkdtm/USERCOPY_STACK_FRAME_TO.sh
	tools/testing/selftests/lkdtm/WARNING.sh
	tools/testing/selftests/lkdtm/WARNING_MESSAGE.sh
	tools/testing/selftests/lkdtm/WRITE_AFTER_FREE.sh
	tools/testing/selftests/lkdtm/WRITE_BUDDY_AFTER_FREE.sh
	tools/testing/selftests/lkdtm/WRITE_KERN.sh
	tools/testing/selftests/lkdtm/WRITE_RO.sh
	tools/testing/selftests/lkdtm/WRITE_RO_AFTER_INIT.sh

nothing added to commit but untracked files present (use "git add" to track)


Thanks
Christophe


> ---
>   .gitignore | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index b849a72d69d5..bb05dce58f8e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -100,6 +100,10 @@ modules.order
>   /include/ksym/
>   /arch/*/include/generated/
>   
> +# Generated lkdtm tests
> +/tools/testing/selftests/lkdtm/*.sh
> +!/tools/testing/selftests/lkdtm/run.sh
> +
>   # stgit generated dirs
>   patches-*
>   
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftest/lkdtm: Don't pollute 'git status'
  2020-02-20 14:58 ` Christophe Leroy
@ 2020-02-20 15:49   ` Shuah Khan
  0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2020-02-20 15:49 UTC (permalink / raw)
  To: Christophe Leroy, Kees Cook
  Cc: linux-mm, linuxppc-dev, linux-kernel,
	open list:KERNEL SELFTEST FRAMEWORK, Shuah Khan

On 2/20/20 7:58 AM, Christophe Leroy wrote:
> ping
> 
> On 02/06/2020 08:11 AM, Christophe Leroy wrote:
>> Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
>> added generation of lkdtm test scripts.
>>
>> Ignore those generated scripts when performing 'git status'
>>
>> Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> 
> Without this, 'git status' now reports the following crap and real 
> problems are drowned in the middle, that's annoying.
> 

I will pull this in. Please cc linux-kselftest mailing list in the
future.

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftest/lkdtm: Don't pollute 'git status'
  2020-02-06  8:11 [PATCH] selftest/lkdtm: Don't pollute 'git status' Christophe Leroy
  2020-02-20 14:58 ` Christophe Leroy
@ 2020-02-20 23:18 ` Kees Cook
  1 sibling, 0 replies; 4+ messages in thread
From: Kees Cook @ 2020-02-20 23:18 UTC (permalink / raw)
  To: Christophe Leroy; +Cc: linux-mm, linuxppc-dev, linux-kernel, Shuah Khan

On Thu, Feb 06, 2020 at 08:11:39AM +0000, Christophe Leroy wrote:
> Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> added generation of lkdtm test scripts.
> 
> Ignore those generated scripts when performing 'git status'
> 
> Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Ah! Yes, a very good idea. Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  .gitignore | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index b849a72d69d5..bb05dce58f8e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -100,6 +100,10 @@ modules.order
>  /include/ksym/
>  /arch/*/include/generated/
>  
> +# Generated lkdtm tests
> +/tools/testing/selftests/lkdtm/*.sh
> +!/tools/testing/selftests/lkdtm/run.sh
> +
>  # stgit generated dirs
>  patches-*
>  
> -- 
> 2.25.0
> 

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-02-20 23:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-06  8:11 [PATCH] selftest/lkdtm: Don't pollute 'git status' Christophe Leroy
2020-02-20 14:58 ` Christophe Leroy
2020-02-20 15:49   ` Shuah Khan
2020-02-20 23:18 ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).