From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CF1C3A589 for ; Fri, 16 Aug 2019 02:40:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CA6F2064A for ; Fri, 16 Aug 2019 02:40:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CA6F2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 468ncF1N1WzDrHY for ; Fri, 16 Aug 2019 12:40:29 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 468nZL51fNzDr86 for ; Fri, 16 Aug 2019 12:38:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by bilbo.ozlabs.org (Postfix) with ESMTP id 468nZL1vM7z8tT1 for ; Fri, 16 Aug 2019 12:38:50 +1000 (AEST) Received: by ozlabs.org (Postfix) id 468nZL1h23z9sNy; Fri, 16 Aug 2019 12:38:50 +1000 (AEST) Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=hbathini@linux.ibm.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 468nZK1Ysyz9sNp for ; Fri, 16 Aug 2019 12:38:48 +1000 (AEST) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7G2bJAl030346 for ; Thu, 15 Aug 2019 22:38:45 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2udkufg1h0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 15 Aug 2019 22:38:45 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Aug 2019 03:38:43 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 16 Aug 2019 03:38:39 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7G2ccJR49938584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Aug 2019 02:38:38 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2FF4B4C040; Fri, 16 Aug 2019 02:38:38 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA0BC4C044; Fri, 16 Aug 2019 02:38:35 +0000 (GMT) Received: from [9.102.3.193] (unknown [9.102.3.193]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 16 Aug 2019 02:38:35 +0000 (GMT) Subject: Re: [PATCH v4 18/25] powernv/fadump: process architected register state data provided by firmware To: mahesh@linux.vnet.ibm.com References: <156327668777.27462.5297279227799429100.stgit@hbathini.in.ibm.com> <156327684839.27462.10598087583845179638.stgit@hbathini.in.ibm.com> <20190814171503.6mpm2r63ildemyyz@in.ibm.com> From: Hari Bathini Date: Fri, 16 Aug 2019 08:08:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814171503.6mpm2r63ildemyyz@in.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19081602-4275-0000-0000-000003599CCF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19081602-4276-0000-0000-0000386BB3BB Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-16_01:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908160027 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ananth N Mavinakayanahalli , Mahesh J Salgaonkar , Nicholas Piggin , linuxppc-dev , Oliver , Vasant Hegde , Stewart Smith , Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 14/08/19 10:45 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:04:08 Tue, Hari Bathini wrote: >> From: Hari Bathini >> >> Firmware provides architected register state data at the time of crash. >> Process this data and build CPU notes to append to ELF core. >> >> Signed-off-by: Hari Bathini >> Signed-off-by: Vasant Hegde >> --- >> arch/powerpc/kernel/fadump-common.h | 4 + >> arch/powerpc/platforms/powernv/opal-fadump.c | 197 ++++++++++++++++++++++++-- >> arch/powerpc/platforms/powernv/opal-fadump.h | 39 +++++ >> 3 files changed, 228 insertions(+), 12 deletions(-) >> > [...] >> @@ -430,6 +577,32 @@ int __init opal_fadump_dt_scan(struct fw_dump *fadump_conf, ulong node) >> return 1; >> } >> >> + ret = opal_mpipl_query_tag(OPAL_MPIPL_TAG_CPU, &addr); >> + if ((ret != OPAL_SUCCESS) || !addr) { >> + pr_err("Failed to get CPU metadata (%lld)\n", ret); >> + return 1; >> + } >> + >> + addr = be64_to_cpu(addr); >> + pr_debug("CPU metadata addr: %llx\n", addr); >> + >> + opal_cpu_metadata = __va(addr); >> + r_opal_cpu_metadata = (void *)addr; >> + fadump_conf->cpu_state_data_version = >> + be32_to_cpu(r_opal_cpu_metadata->cpu_data_version); >> + if (fadump_conf->cpu_state_data_version != >> + HDAT_FADUMP_CPU_DATA_VERSION) { >> + pr_err("CPU data format version (%lu) mismatch!\n", >> + fadump_conf->cpu_state_data_version); >> + return 1; >> + } I think cpu data version mismatch check should still be done early on? >> + fadump_conf->cpu_state_entry_size = >> + be32_to_cpu(r_opal_cpu_metadata->cpu_data_size); >> + fadump_conf->cpu_state_destination_addr = >> + be64_to_cpu(r_opal_cpu_metadata->region[0].dest); >> + fadump_conf->cpu_state_data_size = >> + be64_to_cpu(r_opal_cpu_metadata->region[0].size); >> + > > opal_fadump_dt_scan isn't the right place to do this. Can you please move above > cpu related data processing to opal_fadump_build_cpu_notes() ? I will move the above cpu related data processing to opal_fadump_build_cpu_notes(). Thanks Hari