From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50FB1C61DF7 for ; Thu, 23 Nov 2023 22:26:22 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=HJ/x96Wd; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Sbt4X75mkz3vkg for ; Fri, 24 Nov 2023 09:26:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=HJ/x96Wd; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.dk (client-ip=2607:f8b0:4864:20::42b; helo=mail-pf1-x42b.google.com; envelope-from=axboe@kernel.dk; receiver=lists.ozlabs.org) Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SbpSn0MbHz3cVm for ; Fri, 24 Nov 2023 06:43:33 +1100 (AEDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6c48fad2f6dso206956b3a.0 for ; Thu, 23 Nov 2023 11:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1700768610; x=1701373410; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WpkzZHg09ad7VkHOnG/quo/T41ONjJ1411UTG4haLXU=; b=HJ/x96WdZ8atySxxHNI2zxgfXZOKvmhsUTGxHpk4SmMIPZdD/DpckGgMt3PZmeWfmY urfXKGdGndoEogc45+9ZAcEyHDq+nISAhQl3jvxeNOW5XTGtNzK14ZZxpCvqKtI3hKtw mV+JrHSIvvE+h6hxvz/8G87TGPIhEwwwPL/H9KioXuI+A5aGPEuomR+H+i7+8svBnNdl n8GzZfwCaIzyXWL77HYN958GwlL9MlyVSsV4UKcnw3OvYfEfLDTr7bX1xgoRENr3f8ge hDwLJ24Z6stDFWez3Cfv0VmkIAKSaRgjYecFIUFgIZBBEp52KVmwLiIcaiQ/lSOCTjRp luaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700768610; x=1701373410; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WpkzZHg09ad7VkHOnG/quo/T41ONjJ1411UTG4haLXU=; b=pzuq8ZCvqO6FyjZDLKPc6hO8X+iZ3Wz3heMmfL27laMm9Sd+pvKTTfikA2dB+kKwFL OR1b8L81SuTX5hLdKFOUrsW8cd0m5PXJFpfTGZgu0R2Fqk6R14eRAf14XESCVp7oiyZe JbpPMX9605cGkiPtVRhgTs5xSXLVzy6ZXCsdtjw1zTk1HSFJdlMWN8z92ljKpvDuBFWf w7VFZp3Tpd/qMQNw7tmV/UXEayWwacrvIruU4wdwT6BHST/put4OmrGk/t6O0IqkQJJH 8EzDamygKuRS8IhEoKcsML5Va6ujvUrIspyQLPxJumL08w9izx0vmQXAj93VGoEEAlBZ 6ZFg== X-Gm-Message-State: AOJu0YzFo8w5XYsp1facTfKGWHBEq1hDin7cxvTqjfElfJuc7/28AGOK wT8W+8aLb+EZAUY3y6tQCPVBng== X-Google-Smtp-Source: AGHT+IEPG4J941SLrpY4uC/ri/G2ja2akCNdtY4pHEKeo+HpcNnwpEYC41wSse9D2H40uEI86qohgw== X-Received: by 2002:a05:6a00:9381:b0:6bc:ff89:a2fc with SMTP id ka1-20020a056a00938100b006bcff89a2fcmr544106pfb.2.1700768610318; Thu, 23 Nov 2023 11:43:30 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id n17-20020a056a0007d100b006cb65cfde6dsm1567524pfu.200.2023.11.23.11.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 11:43:29 -0800 (PST) Message-ID: Date: Thu, 23 Nov 2023 12:43:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/4] eventfd: simplify signal helpers Content-Language: en-US To: Christian Brauner , linux-fsdevel@vger.kernel.org References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> From: Jens Axboe In-Reply-To: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 24 Nov 2023 09:22:20 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aio@kvack.org, linux-usb@vger.kernel.org, Jan Kara , Matthew Rosato , Paul Durrant , Tom Rix , Jason Wang , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, Kirti Wankhede , Paolo Bonzini , Vineeth Vijayan , Diana Craciun , netdev@vger.kernel.org, Alexander Gordeev , David Airlie , Christoph Hellwig , Xuan Zhuo , Shakeel Butt , Vasily Gorbik , Leon Romanovsky , Harald Freudenberger , Fei Li , x86@kernel.org, Roman Gushchin , Halil Pasic , Jason Gunthorpe , Ingo Molnar < mingo@redhat.com>, intel-gfx@lists.freedesktop.org, Christian Borntraeger , linux-fpga@vger.kernel.org, Zhi Wang , Wu Hao , Jason Herne , Eric Farman , Dave Hansen , Andrew Donnellan , Arnd Bergmann , linux-s390@vger.kernel.org, Heiko Carstens , Johannes Weiner , linuxppc-dev@lists.ozlabs.org, Zhenyu Wang , Eric Auger , Alex Williamson , Moritz Fischer , Jani Nikula , kvm@vger.kernel.org, Rodrigo Vivi , cgroups@vger.kernel.org, Thomas Gleixner , virtualization@lists.linux-foundation.org, intel-gvt-dev@lists.freedesktop.org, io-uring@vger.kernel.org, Tony Krowiak , Tvrtko Ursulin , Pavel Begunkov , Sean Christopherson , Oded Gabbay , Muchun Song , Peter Oberparleiter , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Benjamin LaHaise , "Michael S. Tsirkin" , Sven Schnelle , Daniel Vetter , Greg Kroah-Hartman , Frederic Barrat , Borislav Petkov , Vitaly Kuznetsov , David Woodhouse , Xu Yilun Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 11/22/23 5:48 AM, Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > significantly. They can be made void and not take any unnecessary > arguments. > > I've added a few more simplifications based on Sean's suggestion. > > Signed-off-by: Christian Brauner > > Changes in v2: > - further simplify helpers > - Link to v1: https://lore.kernel.org/r/20230713-vfs-eventfd-signal-v1-0-7fda6c5d212b@kernel.org Only oddity I spotted was the kerneldoc, which someone else already brought up. Reviewed-by: Jens Axboe -- Jens Axboe