From: Randy Dunlap <rdunlap@infradead.org>
To: Christoph Hellwig <hch@lst.de>, Thomas Gleixner <tglx@linutronix.de>
Cc: Mark Gross <mark.gross@intel.com>, Tejun Heo <tj@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] timers: provide a "modern" variant of timers
Date: Tue, 16 May 2017 12:29:16 -0700 [thread overview]
Message-ID: <cba2a61d-00cd-f4a1-d7ce-e7249a60fee8@infradead.org> (raw)
In-Reply-To: <20170516114812.10660-3-hch@lst.de>
On 05/16/17 04:48, Christoph Hellwig wrote:
> diff --git a/include/linux/timer.h b/include/linux/timer.h
> index e6789b8757d5..87afe52c8349 100644
> --- a/include/linux/timer.h
> +++ b/include/linux/timer.h
\
> @@ -126,6 +146,32 @@ static inline void init_timer_on_stack_key(struct timer_list *timer,
> init_timer_on_stack_key((_timer), (_flags), NULL, NULL)
> #endif
>
> +/**
> + * prepare_timer - initialize a timer before first use
> + * @timer: timer structure to prepare
> + * @func: callback to be called when the timer expires
> + * @flags %TIMER_* flags that control timer behavior
missing ':' on @flags:
> + *
> + * This function initializes a timer_list structure so that it can
> + * be used (by calling add_timer() or mod_timer()).
> + */
> +static inline void prepare_timer(struct timer_list *timer,
> + void (*func)(struct timer_list *timer), u32 flags)
> +{
--
~Randy
next prev parent reply other threads:[~2017-05-16 19:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 11:48 RFC: better timer interface Christoph Hellwig
2017-05-16 11:48 ` [PATCH 1/9] timers: remove the fn and data arguments to call_timer_fn Christoph Hellwig
2017-05-16 11:48 ` [PATCH 2/9] timers: provide a "modern" variant of timers Christoph Hellwig
2017-05-16 19:29 ` Randy Dunlap [this message]
2017-05-16 20:03 ` Arnd Bergmann
2017-05-18 8:24 ` Christoph Hellwig
2017-05-18 8:41 ` Christoph Hellwig
2017-05-18 8:57 ` Arnd Bergmann
2017-05-21 7:00 ` Christoph Hellwig
2017-05-21 12:29 ` Arnd Bergmann
2017-05-21 17:57 ` Thomas Gleixner
2017-05-21 18:23 ` Al Viro
2017-05-19 10:48 ` David Laight
2017-05-21 6:57 ` 'Christoph Hellwig'
2017-05-16 11:48 ` [PATCH 3/9] kthread: remove unused macros Christoph Hellwig
2017-05-17 12:09 ` Petr Mladek
2017-05-18 8:22 ` Christoph Hellwig
2017-05-16 11:48 ` [PATCH 4/9] workqueue: switch to modern timers Christoph Hellwig
2017-05-16 11:48 ` [PATCH 5/9] powerpc/numa: switch topology_timer to modern timer Christoph Hellwig
2017-05-16 11:48 ` [PATCH 6/9] s390: switch topology_timer to a " Christoph Hellwig
2017-05-16 11:48 ` [PATCH 7/9] s390: switch lgr timer " Christoph Hellwig
2017-05-16 11:48 ` [PATCH 8/9] tlclk: switch switchover_timer " Christoph Hellwig
2017-05-16 11:48 ` [PATCH 9/9] timers: remove old timer initialization macros Christoph Hellwig
2017-05-16 19:43 ` Arnd Bergmann
2017-05-18 8:25 ` Christoph Hellwig
2017-05-16 15:45 ` RFC: better timer interface Arnd Bergmann
2017-05-16 15:51 ` Christoph Hellwig
2017-05-16 20:26 ` Arnd Bergmann
2017-05-18 8:27 ` Christoph Hellwig
2017-05-21 17:13 ` Thomas Gleixner
2017-05-21 18:14 ` Thomas Gleixner
2017-05-22 11:26 ` Arnd Bergmann
2017-05-22 19:24 ` Thomas Gleixner
2017-05-23 11:36 ` David Laight
2017-05-23 11:58 ` Thomas Gleixner
2017-05-23 12:51 ` David Laight
2017-05-23 13:02 ` Thomas Gleixner
2017-05-22 13:32 ` Arnd Bergmann
2017-05-22 19:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba2a61d-00cd-f4a1-d7ce-e7249a60fee8@infradead.org \
--to=rdunlap@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.gross@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).