linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nageswara Sastry <rnsastry@linux.ibm.com>
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	mpe@ellerman.id.au, acme@kernel.org, jolsa@kernel.org
Cc: kjain@linux.ibm.com, maddy@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] powerpc/perf: Add instruction and data address registers to extended regs
Date: Mon, 21 Jun 2021 09:39:55 +0530	[thread overview]
Message-ID: <cbc124ff-3415-a3c3-95c4-a4f99152b17f@linux.ibm.com> (raw)
In-Reply-To: <1624200360-1429-1-git-send-email-atrajeev@linux.vnet.ibm.com>



On 20/06/21 8:15 pm, Athira Rajeev wrote:
> Patch set adds PMU registers namely Sampled Instruction Address Register
> (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs
> in PowerPC. These registers provides the instruction/data address and
> adding these to extended regs helps in debug purposes.
> 
> Patch 1/2 adds SIAR and SDAR as part of the extended regs mask.
> Patch 2/2 includes perf tools side changes to add the SPRs to
> sample_reg_mask to use with -I? option.
> 
> Athira Rajeev (2):
>    powerpc/perf: Expose instruction and data address registers as part of
>      extended regs
>    tools/perf: Add perf tools support to expose instruction and data
>      address registers as part of extended regs


Tested with the following scenarios on P9, P10 - PowerVM environment
1. perf record -I? - shows added - sdar, siar
2. perf record -I <workload> and perf report -D - shows added - sdar, 
siar with and with out counts.

Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com>


>   arch/powerpc/include/uapi/asm/perf_regs.h       | 12 +++++++-----
>   arch/powerpc/perf/perf_regs.c                   |  4 ++++
>   tools/arch/powerpc/include/uapi/asm/perf_regs.h | 12 +++++++-----
>   tools/perf/arch/powerpc/include/perf_regs.h     |  2 ++
>   tools/perf/arch/powerpc/util/perf_regs.c        |  2 ++
>   5 files changed, 22 insertions(+), 10 deletions(-)
> 

-- 
Thanks and Regards
R.Nageswara Sastry

  parent reply	other threads:[~2021-06-21  4:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 14:45 [PATCH 0/2] powerpc/perf: Add instruction and data address registers to extended regs Athira Rajeev
2021-06-20 14:45 ` [PATCH 1/2] powerpc/perf: Expose instruction and data address registers as part of " Athira Rajeev
2021-09-08  5:17   ` Michael Ellerman
2021-09-09  2:48     ` Athira Rajeev
2021-09-20  7:13       ` Michael Ellerman
2021-09-21  3:01         ` Athira Rajeev
2021-06-20 14:46 ` [PATCH 2/2] tools/perf: Add perf tools support to expose " Athira Rajeev
2021-06-21  4:09 ` Nageswara Sastry [this message]
2021-09-02  7:34 ` [PATCH 0/2] powerpc/perf: Add instruction and data address registers to " kajoljain
2021-09-06  2:43   ` Athira Rajeev
2021-09-11 19:09     ` Arnaldo Carvalho de Melo
2021-09-20  6:54       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbc124ff-3415-a3c3-95c4-a4f99152b17f@linux.ibm.com \
    --to=rnsastry@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=jolsa@kernel.org \
    --cc=kjain@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).